MAINTAINERS | 2 ++ pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes roms/vbootrom | 2 +- 5 files changed, 3 insertions(+), 1 deletion(-)
The following changes since commit c1c58cee16380f81f88fbde6b12f247b376839e2: Merge tag 'pull-target-arm-20260115' of https://gitlab.com/pm215/qemu into staging (2026-01-16 09:33:20 +1100) are available in the Git repository at: https://github.com/jamin-aspeed/qemu.git tags/pull-vbootrom-20260116 for you to fetch changes up to 107253db5886ec9c0173ffdcb1671a51695a20d5: pc-bios: Update vbootrom image to commit 1c8e9510b22c (2026-01-16 15:09:53 +0800) ---------------------------------------------------------------- vbootrom update pull request ---------------------------------------------------------------- Jamin Lin (3): MAINTAINERS: Update ASPEED entry roms/vbootrom: Update to commit 1c8e9510b22c pc-bios: Update vbootrom image to commit 1c8e9510b22c MAINTAINERS | 2 ++ pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes roms/vbootrom | 2 +- 5 files changed, 3 insertions(+), 1 deletion(-) -- 2.43.0
On 1/16/26 10:30, Jamin Lin wrote: > ---------------------------------------------------------------- > vbootrom update pull request > > ---------------------------------------------------------------- Hi Jamin! I've become curious. You sent a pull request (and second one), listing multiple people in To: and Cc: fields. Usually, this is done when you're sending a patch series for review. For a pull request, usually it's enough to list qemu-devel@nongnu.org in the To: field, and maybe the current person who's managing the master branch, who's merging the pull requests. Listing multiple people for the pull request makes not much sense, since a pullreq is something which is (almost) cast in stone already, it is being merged as-is, there's no way to comment on it or to modify it - since the whole pull request is being applied to the master branch as-is. And another question is why did you add my address to the list of recipients? Is it for me to review the changes, or to pick them up through qemu-trivial tree (in which case it shouldn't be pull request), or to pick it up for qemu-stable? Thanks, /mjt
+ Cedric Hi Michael, > Subject: Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c > > On 1/16/26 10:30, Jamin Lin wrote: > > ---------------------------------------------------------------- > > vbootrom update pull request > > > > ---------------------------------------------------------------- > > Hi Jamin! > > I've become curious. > > You sent a pull request (and second one), listing multiple people in To: and Cc: > fields. Usually, this is done when you're sending a patch series for review. > For a pull request, usually it's enough to list qemu-devel@nongnu.org in the To: > field, and maybe the current person who's managing the master branch, who's > merging the pull requests. Listing multiple people for the pull request makes > not much sense, since a pullreq is something which is (almost) cast in stone > already, it is being merged as-is, there's no way to comment on it or to modify > it - since the whole pull request is being applied to the master branch as-is. > Got it, thanks for the clarification. This is my first time sending a pull request, so I’m still learning the QEMU PR workflow. Thank you for pointing this out. I created this pull request because it updates the pre-built VBOOTROM image. The patch size is quite large, and both my maintainer and reviewer (Cedric) suggested that I submit it as a pull request instead of a regular patch series. Since I understood that the pull request still needs to be reviewed, I used git send-email together with get_maintainer.pl to include the relevant maintainers and reviewers. git send-email -cc jamin_lin@aspeedtech.com -cc troy_lee@aspeedtech.com -cc kane_chen@aspeedtech.com --to-cmd "./scripts/get_maintainer.pl ../v3-patch/*.patch" > And another question is why did you add my address to the list of recipients? > Is it for me to review the changes, or to pick them up through qemu-trivial tree > (in which case it shouldn't be pull request), or to pick it up for qemu-stable? > I added your address because it was automatically included by get_maintainer.pl. This pull request is intended for the master branch only. Thanks-Jamin > Thanks, > > /mjt
Hi Michael, Cédric Do I need to resend this PR (v3)? I am currently waiting for this patch to be merged so that I can proceed with submitting the corresponding update to the ASPEED SDK v11.00. Thanks, Jamin > -----Original Message----- > From: Jamin Lin > Sent: Monday, January 19, 2026 9:35 AM > To: Michael Tokarev <mjt@tls.msk.ru>; open list:All patches CC here > <qemu-devel@nongnu.org> > Cc: Cédric Le Goater <clg@kaod.org> > Subject: RE: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c > > + Cedric > > Hi Michael, > > > Subject: Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c > > > > On 1/16/26 10:30, Jamin Lin wrote: > > > ---------------------------------------------------------------- > > > vbootrom update pull request > > > > > > ---------------------------------------------------------------- > > > > Hi Jamin! > > > > I've become curious. > > > > You sent a pull request (and second one), listing multiple people in To: and > Cc: > > fields. Usually, this is done when you're sending a patch series for review. > > For a pull request, usually it's enough to list qemu-devel@nongnu.org in the > To: > > field, and maybe the current person who's managing the master branch, > > who's merging the pull requests. Listing multiple people for the pull > > request makes not much sense, since a pullreq is something which is > > (almost) cast in stone already, it is being merged as-is, there's no > > way to comment on it or to modify it - since the whole pull request is being > applied to the master branch as-is. > > > Got it, thanks for the clarification. > This is my first time sending a pull request, so I’m still learning the QEMU PR > workflow. > Thank you for pointing this out. > > I created this pull request because it updates the pre-built VBOOTROM image. > The patch size is quite large, and both my maintainer and reviewer (Cedric) > suggested that I submit it as a pull request instead of a regular patch series. > Since I understood that the pull request still needs to be reviewed, I used git > send-email together with get_maintainer.pl to include the relevant maintainers > and reviewers. > > git send-email -cc jamin_lin@aspeedtech.com -cc troy_lee@aspeedtech.com > -cc kane_chen@aspeedtech.com --to-cmd > "./scripts/get_maintainer.pl ../v3-patch/*.patch" > > > And another question is why did you add my address to the list of recipients? > > Is it for me to review the changes, or to pick them up through > > qemu-trivial tree (in which case it shouldn't be pull request), or to pick it up > for qemu-stable? > > > > > I added your address because it was automatically included by > get_maintainer.pl. > This pull request is intended for the master branch only. > > Thanks-Jamin > > > Thanks, > > > > /mjt
Hi, On 1/23/26 05:58, Jamin Lin wrote: > Hi Michael, Cédric > > Do I need to resend this PR (v3)? I don't think so. > I am currently waiting for this patch to be merged so that I can proceed > with submitting the corresponding update to the ASPEED SDK v11.00. I plan to send the vbootrom update in the next aspeed PR but I can't tell you when. Thanks, C.
Hi Cédric > -----Original Message----- > From: Cédric Le Goater <clg@kaod.org> > Sent: Friday, January 23, 2026 2:06 PM > To: Jamin Lin <jamin_lin@aspeedtech.com>; Michael Tokarev > <mjt@tls.msk.ru>; open list:All patches CC here <qemu-devel@nongnu.org> > Subject: Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c > > Hi, > > On 1/23/26 05:58, Jamin Lin wrote: > > Hi Michael, Cédric > > > > Do I need to resend this PR (v3)? > > I don't think so. > > > I am currently waiting for this patch to be merged so that I can > > proceed with submitting the corresponding update to the ASPEED SDK > v11.00. > > I plan to send the vbootrom update in the next aspeed PR but I can't tell you > when. > No problem. I really appreciate your help and kind support. Thanks-Jamin > Thanks, > > C.
On 1/16/26 08:30, Jamin Lin wrote:
> The following changes since commit c1c58cee16380f81f88fbde6b12f247b376839e2:
>
> Merge tag 'pull-target-arm-20260115' of https://gitlab.com/pm215/qemu into staging (2026-01-16 09:33:20 +1100)
>
> are available in the Git repository at:
>
> https://github.com/jamin-aspeed/qemu.git tags/pull-vbootrom-20260116
>
> for you to fetch changes up to 107253db5886ec9c0173ffdcb1671a51695a20d5:
>
> pc-bios: Update vbootrom image to commit 1c8e9510b22c (2026-01-16 15:09:53 +0800)
>
> ----------------------------------------------------------------
> vbootrom update pull request
>
> ----------------------------------------------------------------
>
> Jamin Lin (3):
> MAINTAINERS: Update ASPEED entry
> roms/vbootrom: Update to commit 1c8e9510b22c
> pc-bios: Update vbootrom image to commit 1c8e9510b22c
>
> MAINTAINERS | 2 ++
> pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes
> pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes
> pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes
> roms/vbootrom | 2 +-
> 5 files changed, 3 insertions(+), 1 deletion(-)
>
For next time, the subject should be:
[PULL SUBSYSTEM vbootrom 0/x] ...
Thanks,
C.
Hi Cédric > Subject: Re: [PULL 0/3] Update vbootrom image to commit 1c8e9510b22c > > On 1/16/26 08:30, Jamin Lin wrote: > > The following changes since commit > c1c58cee16380f81f88fbde6b12f247b376839e2: > > > > Merge tag 'pull-target-arm-20260115' of > https://gitlab.com/pm215/qemu into staging (2026-01-16 09:33:20 +1100) > > > > are available in the Git repository at: > > > > https://github.com/jamin-aspeed/qemu.git > tags/pull-vbootrom-20260116 > > > > for you to fetch changes up to > 107253db5886ec9c0173ffdcb1671a51695a20d5: > > > > pc-bios: Update vbootrom image to commit 1c8e9510b22c (2026-01-16 > 15:09:53 +0800) > > > > ---------------------------------------------------------------- > > vbootrom update pull request > > > > ---------------------------------------------------------------- > > > > Jamin Lin (3): > > MAINTAINERS: Update ASPEED entry > > roms/vbootrom: Update to commit 1c8e9510b22c > > pc-bios: Update vbootrom image to commit 1c8e9510b22c > > > > MAINTAINERS | 2 ++ > > pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes > > pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes > > pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes > > roms/vbootrom | 2 +- > > 5 files changed, 3 insertions(+), 1 deletion(-) > > > > For next time, the subject should be: > > [PULL SUBSYSTEM vbootrom 0/x] ... > Thanks for review. Resend v2 here, https://patchwork.kernel.org/project/qemu-devel/patch/20260116082431.3689035-1-jamin_lin@aspeedtech.com/ Thanks-Jamin > Thanks, > > C.
© 2016 - 2026 Red Hat, Inc.