[v2] Remove 32-bit host support

[PATCH v2 11/58] bsd-user: Fix i386 test for TARGET_HAS_STAT_TIME_T_EXT

Richard Henderson posted 58 patches 3 weeks, 1 day ago

Diff against v1 v1
Download mbox

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony PERARD <anthony@xenproject.org>, Paul Durrant <paul@xen.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, David Hildenbrand <david@kernel.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Peter Xu <peterx@redhat.com>, Li Zhijian <lizhijian@fujitsu.com>, Hyman Huang <yong.huang@smartx.com>, Peter Maydell <peter.maydell@linaro.org>, Helge Deller <deller@gmx.de>, Zhao Liu <zhao1.liu@intel.com>, Eduardo Habkost <eduardo@habkost.net>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Ilya Leoshkevich <iii@linux.ibm.com>, WANG Xuerui <git@xen0n.name>, Stefan Weil <sw@weilnetz.de>, Kohei Tokunaga <ktokunaga.mail@gmail.com>

Expand all Fold all

[PATCH v2 11/58] bsd-user: Fix __i386__ test for TARGET_HAS_STAT_TIME_T_EXT

Posted by Richard Henderson 3 weeks, 1 day ago

The target test is TARGET_I386, not __i386__.

Cc: Warner Losh <imp@bsdimp.com>
Cc: Kyle Evans <kevans@freebsd.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 bsd-user/syscall_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h
index 52f84d5dd1..c49be32bdc 100644
--- a/bsd-user/syscall_defs.h
+++ b/bsd-user/syscall_defs.h
@@ -247,7 +247,7 @@ struct target_freebsd11_stat {
     unsigned int:(8 / 2) * (16 - (int)sizeof(struct target_freebsd_timespec));
 } __packed;
 
-#if defined(__i386__)
+#if defined(TARGET_I386)
 #define TARGET_HAS_STAT_TIME_T_EXT       1
 #endif
 
-- 
2.43.0

Re: [PATCH v2 11/58] bsd-user: Fix __i386__ test for TARGET_HAS_STAT_TIME_T_EXT

Posted by Michael Tokarev 2 weeks, 4 days ago

On 1/16/26 06:32, Richard Henderson wrote:
> The target test is TARGET_I386, not __i386__.
> 
> Cc: Warner Losh <imp@bsdimp.com>
> Cc: Kyle Evans <kevans@freebsd.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

This looks like a qemu-stable material (but probably of very
low priority).  Please let me know if it is not.

Thanks,

/mjt

> ---
>   bsd-user/syscall_defs.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h
> index 52f84d5dd1..c49be32bdc 100644
> --- a/bsd-user/syscall_defs.h
> +++ b/bsd-user/syscall_defs.h
> @@ -247,7 +247,7 @@ struct target_freebsd11_stat {
>       unsigned int:(8 / 2) * (16 - (int)sizeof(struct target_freebsd_timespec));
>   } __packed;
>   
> -#if defined(__i386__)
> +#if defined(TARGET_I386)
>   #define TARGET_HAS_STAT_TIME_T_EXT       1
>   #endif
>

Re: [PATCH v2 11/58] bsd-user: Fix __i386__ test for TARGET_HAS_STAT_TIME_T_EXT

Posted by Pierrick Bouvier 2 weeks, 4 days ago

On 1/18/26 11:44 PM, Michael Tokarev wrote:
> On 1/16/26 06:32, Richard Henderson wrote:
>> The target test is TARGET_I386, not __i386__.
>>
>> Cc: Warner Losh <imp@bsdimp.com>
>> Cc: Kyle Evans <kevans@freebsd.org>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> 
> This looks like a qemu-stable material (but probably of very
> low priority).  Please let me know if it is not.
> 
> Thanks,
> 
> /mjt

It needs to come with this fix, or it will introduce a regression on 
x86_64 hosts:
https://lore.kernel.org/qemu-devel/20260119075738.712207-1-pierrick.bouvier@linaro.org/T/#u

Regards,
Pierrick

Re: [PATCH v2 11/58] bsd-user: Fix __i386__ test for TARGET_HAS_STAT_TIME_T_EXT

Posted by Warner Losh 3 weeks, 1 day ago

On Thu, Jan 15, 2026, 8:34 PM Richard Henderson <
richard.henderson@linaro.org> wrote:

> The target test is TARGET_I386, not __i386__.
>
> Cc: Warner Losh <imp@bsdimp.com>
> Cc: Kyle Evans <kevans@freebsd.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  bsd-user/syscall_defs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Warner Losh <imp@bsdimp.com>


diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h
> index 52f84d5dd1..c49be32bdc 100644
> --- a/bsd-user/syscall_defs.h
> +++ b/bsd-user/syscall_defs.h
> @@ -247,7 +247,7 @@ struct target_freebsd11_stat {
>      unsigned int:(8 / 2) * (16 - (int)sizeof(struct
> target_freebsd_timespec));
>  } __packed;
>
> -#if defined(__i386__)
> +#if defined(TARGET_I386)
>  #define TARGET_HAS_STAT_TIME_T_EXT       1
>  #endif
>
> --
> 2.43.0
>
>