tests/functional: Require TCG to run reverse debugging tests

[PATCH] tests/functional: Require TCG to run reverse debugging tests

Posted by Philippe Mathieu-Daudé 3 weeks, 1 day ago

Record/replay is specific to TCG. Require it to avoid failure
when using a HVF-only build on Darwin:

  qemu-system-aarch64: -icount shift=7,rr=record,rrfile=/scratch/replay.bin,rrsnapshot=init: cannot configure icount, TCG support not available

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/functional/reverse_debugging.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py
index 8b9507674a0..8e6f0b0e923 100644
--- a/tests/functional/reverse_debugging.py
+++ b/tests/functional/reverse_debugging.py
@@ -67,6 +67,8 @@ def vm_get_icount(vm):
     def reverse_debugging(self, gdb_arch, shift=7, args=None, big_endian=False):
         from qemu_test import GDB
 
+        self.require_accelerator("tcg")
+
         # create qcow2 for snapshots
         self.log.info('creating qcow2 image for VM snapshots')
         image_path = os.path.join(self.workdir, 'disk.qcow2')
-- 
2.52.0

Re: [PATCH] tests/functional: Require TCG to run reverse debugging tests

Posted by Philippe Mathieu-Daudé 3 weeks, 1 day ago

On 15/1/26 17:10, Philippe Mathieu-Daudé wrote:
> Record/replay is specific to TCG. Require it to avoid failure
> when using a HVF-only build on Darwin:
> 
>    qemu-system-aarch64: -icount shift=7,rr=record,rrfile=/scratch/replay.bin,rrsnapshot=init: cannot configure icount, TCG support not available
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tests/functional/reverse_debugging.py | 2 ++
>   1 file changed, 2 insertions(+)

Queued via accel-next tree, thanks.

Re: [PATCH] tests/functional: Require TCG to run reverse debugging tests

Posted by Alex Bennée 3 weeks, 1 day ago

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Record/replay is specific to TCG. Require it to avoid failure
> when using a HVF-only build on Darwin:
>
>   qemu-system-aarch64: -icount shift=7,rr=record,rrfile=/scratch/replay.bin,rrsnapshot=init: cannot configure icount, TCG support not available
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] tests/functional: Require TCG to run reverse debugging tests

Posted by Daniel P. Berrangé 3 weeks, 1 day ago

On Thu, Jan 15, 2026 at 05:10:29PM +0100, Philippe Mathieu-Daudé wrote:
> Record/replay is specific to TCG. Require it to avoid failure
> when using a HVF-only build on Darwin:
> 
>   qemu-system-aarch64: -icount shift=7,rr=record,rrfile=/scratch/replay.bin,rrsnapshot=init: cannot configure icount, TCG support not available
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  tests/functional/reverse_debugging.py | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|