[v3] chardev: cleanup

[PATCH v3 00/10] chardev: cleanup

Vladimir Sementsov-Ogievskiy posted 10 patches 3 weeks, 1 day ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260115144606.233252-1-vsementsov@yandex-team.ru

Maintainers: Samuel Thibault <samuel.thibault@ens-lyon.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Stefano Stabellini <sstabellini@kernel.org>, Anthony PERARD <anthony@xenproject.org>, Paul Durrant <paul@xen.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>

chardev/baum.c                                | 12 +--
chardev/char-console.c                        | 10 +--
chardev/char-fe.c                             |  8 +-
chardev/char-file.c                           | 26 +++----
chardev/char-hub.c                            | 27 ++++---
chardev/char-mux.c                            | 30 ++++----
chardev/char-null.c                           |  9 +--
chardev/char-parallel.c                       | 41 +++++------
chardev/char-pipe.c                           | 30 ++++----
chardev/char-pty.c                            | 56 ++++++++------
chardev/char-ringbuf.c                        | 20 ++---
chardev/char-serial.c                         | 39 +++++-----
chardev/char-socket.c                         | 73 ++++++++-----------
chardev/char-stdio.c                          | 30 ++++----
chardev/char-udp.c                            | 16 ++--
chardev/char-win-stdio.c                      | 25 ++++---
chardev/char.c                                | 65 ++++++++++-------
chardev/msmouse.c                             | 13 ++--
chardev/spice.c                               | 52 ++++++-------
chardev/wctablet.c                            | 10 +--
gdbstub/system.c                              | 12 +--
hw/char/xen_console.c                         |  7 +-
hw/display/qxl.c                              | 23 +-----
hw/misc/ivshmem-pci.c                         |  4 +-
include/chardev/char.h                        | 21 ++++--
include/ui/qemu-spice.h                       |  6 --
meson.build                                   |  2 +-
.../codeconverter/test_regexps.py             |  2 +-
ui/console-vc.c                               | 12 ++-
ui/dbus-chardev.c                             | 16 ++--
ui/dbus.c                                     |  4 +-
ui/gtk.c                                      | 14 ++--
ui/spice-app.c                                | 18 ++---
ui/spice-display.c                            | 19 +----
ui/vdagent.c                                  | 17 ++---
35 files changed, 362 insertions(+), 407 deletions(-)

Expand all Fold all

[PATCH v3 00/10] chardev: cleanup

Posted by Vladimir Sementsov-Ogievskiy 3 weeks, 1 day ago

Here is a cleanup for chardev code:

 - preparation patches to drop spice version checks
 - improve naming
 - add boolean return for some errp-functions
 - simplify open() API

v3:
01-08,10: add r-b by Marc-André
06: fix gd_vc_chr_open return type, and wrong rename,
09: rework

Vladimir Sementsov-Ogievskiy (10):
  ui/spice: Require spice-server >= 0.15.0
  ui/spice: drop SPICE_HAS_ATTACHED_WORKER macro
  chardev: ChardevClass: consistent naming for handlers
  chardev: consistent naming for ChardevClass handlers implementations
  chardev: .chr_open(): drop be_opened parameter
  chardev: .chr_open(): add boolean return value
  chardev/char-pty: store pty_name into PtyChardev state
  chardev: introduce .chr_get_pty_name() handler
  chardev: rework filename handling
  chardev/char: qemu_char_open(): add return value

 chardev/baum.c                                | 12 +--
 chardev/char-console.c                        | 10 +--
 chardev/char-fe.c                             |  8 +-
 chardev/char-file.c                           | 26 +++----
 chardev/char-hub.c                            | 27 ++++---
 chardev/char-mux.c                            | 30 ++++----
 chardev/char-null.c                           |  9 +--
 chardev/char-parallel.c                       | 41 +++++------
 chardev/char-pipe.c                           | 30 ++++----
 chardev/char-pty.c                            | 56 ++++++++------
 chardev/char-ringbuf.c                        | 20 ++---
 chardev/char-serial.c                         | 39 +++++-----
 chardev/char-socket.c                         | 73 ++++++++-----------
 chardev/char-stdio.c                          | 30 ++++----
 chardev/char-udp.c                            | 16 ++--
 chardev/char-win-stdio.c                      | 25 ++++---
 chardev/char.c                                | 65 ++++++++++-------
 chardev/msmouse.c                             | 13 ++--
 chardev/spice.c                               | 52 ++++++-------
 chardev/wctablet.c                            | 10 +--
 gdbstub/system.c                              | 12 +--
 hw/char/xen_console.c                         |  7 +-
 hw/display/qxl.c                              | 23 +-----
 hw/misc/ivshmem-pci.c                         |  4 +-
 include/chardev/char.h                        | 21 ++++--
 include/ui/qemu-spice.h                       |  6 --
 meson.build                                   |  2 +-
 .../codeconverter/test_regexps.py             |  2 +-
 ui/console-vc.c                               | 12 ++-
 ui/dbus-chardev.c                             | 16 ++--
 ui/dbus.c                                     |  4 +-
 ui/gtk.c                                      | 14 ++--
 ui/spice-app.c                                | 18 ++---
 ui/spice-display.c                            | 19 +----
 ui/vdagent.c                                  | 17 ++---
 35 files changed, 362 insertions(+), 407 deletions(-)

-- 
2.52.0