configure: Remove duplicated entry of --gdb in the help text

[PATCH] configure: Remove duplicated entry of --gdb in the help text

Posted by Thomas Huth 3 weeks, 2 days ago

From: Thomas Huth <thuth@redhat.com>

Since --gdb has recently been added to meson_options.txt, the help
text shows up twice in the output of "./configure --help":

 $ ./configure --help | grep gdb
   --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
   --gdb=VALUE              Path to GDB

Remove the entry from "configure" to fix this duplication.

Fixes: b46b3818cf8 ("tests/functional: Provide GDB to the functional tests")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index ef5157cf903..093dd7b01eb 100755
--- a/configure
+++ b/configure
@@ -899,7 +899,6 @@ Advanced options (experts only):
   --cpu=CPU                Build for host CPU [$cpu]
   --disable-containers     don't use containers for cross-building
   --container-engine=TYPE  which container engine to use [$container_engine]
-  --gdb=GDB-path           gdb to use for gdbstub tests [$gdb_bin]
 EOF
   meson_options_help
 cat << EOF
-- 
2.52.0

Re: [PATCH] configure: Remove duplicated entry of --gdb in the help text

Posted by Alex Bennée 3 weeks, 2 days ago

Thomas Huth <thuth@redhat.com> writes:

> From: Thomas Huth <thuth@redhat.com>
>
> Since --gdb has recently been added to meson_options.txt, the help
> text shows up twice in the output of "./configure --help":
>
>  $ ./configure --help | grep gdb
>    --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
>    --gdb=VALUE              Path to GDB

It's a shame to loose the default value - is there anyway for the meson
version to show the auto-detected value?

>
> Remove the entry from "configure" to fix this duplication.
>
> Fixes: b46b3818cf8 ("tests/functional: Provide GDB to the functional tests")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index ef5157cf903..093dd7b01eb 100755
> --- a/configure
> +++ b/configure
> @@ -899,7 +899,6 @@ Advanced options (experts only):
>    --cpu=CPU                Build for host CPU [$cpu]
>    --disable-containers     don't use containers for cross-building
>    --container-engine=TYPE  which container engine to use [$container_engine]
> -  --gdb=GDB-path           gdb to use for gdbstub tests [$gdb_bin]
>  EOF
>    meson_options_help
>  cat << EOF

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] configure: Remove duplicated entry of --gdb in the help text

Posted by Michael Tokarev 2 weeks, 3 days ago

On 1/14/26 20:01, Alex Bennée wrote:
> Thomas Huth <thuth@redhat.com> writes:
> 
>> From: Thomas Huth <thuth@redhat.com>
>>
>> Since --gdb has recently been added to meson_options.txt, the help
>> text shows up twice in the output of "./configure --help":
>>
>>   $ ./configure --help | grep gdb
>>     --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
>>     --gdb=VALUE              Path to GDB
> 
> It's a shame to loose the default value - is there anyway for the meson
> version to show the auto-detected value?

Maybe we can drop this line from meson but keep it in ./configure?

/mjt

Re: [PATCH] configure: Remove duplicated entry of --gdb in the help text

Posted by Thomas Huth 2 weeks, 3 days ago

On 20/01/2026 12.31, Michael Tokarev wrote:
> On 1/14/26 20:01, Alex Bennée wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>>
>>> From: Thomas Huth <thuth@redhat.com>
>>>
>>> Since --gdb has recently been added to meson_options.txt, the help
>>> text shows up twice in the output of "./configure --help":
>>>
>>>   $ ./configure --help | grep gdb
>>>     --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
>>>     --gdb=VALUE              Path to GDB
>>
>> It's a shame to loose the default value - is there anyway for the meson
>> version to show the auto-detected value?
> 
> Maybe we can drop this line from meson but keep it in ./configure?

The meson stuff is generated automatically, so no clue how that could be 
done in a nice way?

  Thomas

Re: [PATCH] configure: Remove duplicated entry of --gdb in the help text

Posted by Alex Bennée 4 days, 13 hours ago

Thomas Huth <thuth@redhat.com> writes:

> On 20/01/2026 12.31, Michael Tokarev wrote:
>> On 1/14/26 20:01, Alex Bennée wrote:
>>> Thomas Huth <thuth@redhat.com> writes:
>>>
>>>> From: Thomas Huth <thuth@redhat.com>
>>>>
>>>> Since --gdb has recently been added to meson_options.txt, the help
>>>> text shows up twice in the output of "./configure --help":
>>>>
>>>>   $ ./configure --help | grep gdb
>>>>     --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
>>>>     --gdb=VALUE              Path to GDB
>>>
>>> It's a shame to loose the default value - is there anyway for the meson
>>> version to show the auto-detected value?
>> Maybe we can drop this line from meson but keep it in ./configure?
>
> The meson stuff is generated automatically, so no clue how that could
> be done in a nice way?

I tried the other way around and squashed the meson_options_help text
with:

  20260202174123.1943748-1-alex.bennee@linaro.org

>
>  Thomas

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] configure: Remove duplicated entry of --gdb in the help text

Posted by Daniel P. Berrangé 3 weeks, 2 days ago

On Wed, Jan 14, 2026 at 04:53:55PM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Since --gdb has recently been added to meson_options.txt, the help
> text shows up twice in the output of "./configure --help":
> 
>  $ ./configure --help | grep gdb
>    --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
>    --gdb=VALUE              Path to GDB
> 
> Remove the entry from "configure" to fix this duplication.
> 
> Fixes: b46b3818cf8 ("tests/functional: Provide GDB to the functional tests")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|