[v1] qapi: Use visitors for migration parameters handling

[PATCH 0/5] qapi: Use visitors for migration parameters handling

Fabiano Rosas posted 5 patches 3 weeks, 2 days ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260114132309.5832-1-farosas@suse.de

Maintainers: Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>

There is a newer version of this series

include/qapi/dealloc-visitor.h |   6 +
include/qapi/type-helpers.h    |  40 +++++
migration/options.c            | 282 ++++-----------------------------
qapi/qapi-dealloc-visitor.c    | 173 +++++++++++++++++++-
4 files changed, 246 insertions(+), 255 deletions(-)

Expand all Fold all

[PATCH 0/5] qapi: Use visitors for migration parameters handling

Posted by Fabiano Rosas 3 weeks, 2 days ago

I split this series from the original[0] because these changes are
more QAPI-related and self-contained.

The idea is to use QAPI_CLONE_MEMBERS and (the new) QAPI_MERGE to
reduce the amount of open-coded parameters handling in options.c, such
as checks to QAPI's has_* fields and manual inclusion of future
parameters.

- Patches 1 & 2 are unchanged

- Patch 3 adds a new variant of the dealloc visitor to free the to-be
  unreferenced memory when the input visitor eventually allocates new
  memory and overwrites the pointers.

- Patches 4 & 5 are mostly unchanged, but now use the new visitor.

0 - migration: Unify capabilities and parameters
https://lore.kernel.org/r/20251215220041.12657-1-farosas@suse.de

CI run: https://gitlab.com/farosas/qemu/-/pipelines/2262453042

Fabiano Rosas (5):
  migration: Use QAPI_CLONE_MEMBERS in migrate_params_test_apply
  migration: Use QAPI_CLONE_MEMBERS in migrate_params_apply
  qapi: Implement qapi_dealloc_present_visitor
  qapi: Add QAPI_MERGE
  migration/options: Use QAPI_MERGE in migrate_params_test_apply

 include/qapi/dealloc-visitor.h |   6 +
 include/qapi/type-helpers.h    |  40 +++++
 migration/options.c            | 282 ++++-----------------------------
 qapi/qapi-dealloc-visitor.c    | 173 +++++++++++++++++++-
 4 files changed, 246 insertions(+), 255 deletions(-)

-- 
2.51.0