rust: hwcore: add chardev symbols to integration tests

[PATCH] rust: hwcore: add chardev symbols to integration tests

Posted by Paolo Bonzini 2 weeks, 3 days ago

Even though they are not used, rustc does not elide its symbols on msys2.
This causes a linker error.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
	Yet another tiny bit.  For the remaining issue, which is another
	linker error in the same test due to missing system/memory.c, I'm
	posting (after retesting) a patch series from Marc-André that is a
	bit bigger but was going to be submitted anyway.

 rust/hw/core/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/hw/core/meson.build b/rust/hw/core/meson.build
index fa1765a2302..942ee9cdacf 100644
--- a/rust/hw/core/meson.build
+++ b/rust/hw/core/meson.build
@@ -73,7 +73,7 @@ test('rust-hwcore-rs-integration',
         override_options: ['rust_std=2021', 'build.rust_std=2021'],
         rust_args: ['--test'],
         install: false,
-        dependencies: [common_rs, hwcore_rs, bql_rs, migration_rs, util_rs]),
+        dependencies: [chardev_rs, common_rs, hwcore_rs, bql_rs, migration_rs, util_rs]),
     args: [
         '--test', '--test-threads', '1',
         '--format', 'pretty',
-- 
2.52.0

Re: [PATCH] rust: hwcore: add chardev symbols to integration tests

Posted by Marc-André Lureau 2 weeks, 3 days ago

On Wed, Jan 14, 2026 at 1:06 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Even though they are not used, rustc does not elide its symbols on msys2.
> This causes a linker error.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>         Yet another tiny bit.  For the remaining issue, which is another
>         linker error in the same test due to missing system/memory.c, I'm
>         posting (after retesting) a patch series from Marc-André that is a
>         bit bigger but was going to be submitted anyway.
>
>  rust/hw/core/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/hw/core/meson.build b/rust/hw/core/meson.build
> index fa1765a2302..942ee9cdacf 100644
> --- a/rust/hw/core/meson.build
> +++ b/rust/hw/core/meson.build
> @@ -73,7 +73,7 @@ test('rust-hwcore-rs-integration',
>          override_options: ['rust_std=2021', 'build.rust_std=2021'],
>          rust_args: ['--test'],
>          install: false,
> -        dependencies: [common_rs, hwcore_rs, bql_rs, migration_rs, util_rs]),
> +        dependencies: [chardev_rs, common_rs, hwcore_rs, bql_rs, migration_rs, util_rs]),
>      args: [
>          '--test', '--test-threads', '1',
>          '--format', 'pretty',
> --
> 2.52.0
>
>


-- 
Marc-André Lureau