rust: trace: libc does not have syslog on windows

[PATCH] rust: trace: libc does not have syslog on windows

Posted by Paolo Bonzini 2 weeks, 3 days ago

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
	This is not enough for the msys2-64bit job to pass, but it
	reaches linking.

 rust/trace/src/lib.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/rust/trace/src/lib.rs b/rust/trace/src/lib.rs
index c2abe430a52..143513891ac 100644
--- a/rust/trace/src/lib.rs
+++ b/rust/trace/src/lib.rs
@@ -3,9 +3,11 @@
 //! This crate provides macros that aid in using QEMU's tracepoint
 //! functionality.
 
+#[cfg(not(windows))]
 #[doc(hidden)]
 /// Re-exported item to avoid adding libc as a dependency everywhere.
 pub use libc::{syslog, LOG_INFO};
+
 #[doc(hidden)]
 /// Re-exported item to avoid adding probe as a dependency everywhere.
 pub use probe::probe;
-- 
2.52.0

Re: [PATCH] rust: trace: libc does not have syslog on windows

Posted by Marc-André Lureau 2 weeks, 3 days ago

Hi

On Wed, Jan 14, 2026 at 12:51 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>         This is not enough for the msys2-64bit job to pass, but it
>         reaches linking.

same here :)

>
>  rust/trace/src/lib.rs | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/rust/trace/src/lib.rs b/rust/trace/src/lib.rs
> index c2abe430a52..143513891ac 100644
> --- a/rust/trace/src/lib.rs
> +++ b/rust/trace/src/lib.rs
> @@ -3,9 +3,11 @@
>  //! This crate provides macros that aid in using QEMU's tracepoint
>  //! functionality.
>
> +#[cfg(not(windows))]
>  #[doc(hidden)]
>  /// Re-exported item to avoid adding libc as a dependency everywhere.
>  pub use libc::{syslog, LOG_INFO};
> +
>  #[doc(hidden)]
>  /// Re-exported item to avoid adding probe as a dependency everywhere.
>  pub use probe::probe;
> --
> 2.52.0
>
>


-- 
Marc-André Lureau