configure: Set $PYTHON in the configuration of the optionroms

[PATCH] configure: Set $PYTHON in the configuration of the optionroms

Thomas Huth posted 1 patch 3 weeks, 2 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260114083306.18172-1-thuth@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>

configure | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] configure: Set $PYTHON in the configuration of the optionroms

Posted by Thomas Huth 3 weeks, 2 days ago

From: Thomas Huth <thuth@redhat.com>

pc-bios/optionrom/Makefile uses $(PYTHON) for running a Python script,
but this variable is never initialized here. So the script gets run
via its shebang line - which fails if the "python3" binary is not
available on the system. To fix this, write the PYTHON configuration
to the config.mak file of the optionroms.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 55e0bd34256..f7e8d7ad4c8 100755
--- a/configure
+++ b/configure
@@ -1643,6 +1643,7 @@ probe_target_compiler() {
 }
 
 write_target_makefile() {
+  echo "PYTHON=$python"
   echo "EXTRA_CFLAGS=$target_cflags"
   if test -z "$target_cc" && test -z "$target_as"; then
     test -z "$container_image" && error_exit "Internal error: could not find cross compiler for $1?"
-- 
2.52.0

Re: [PATCH] configure: Set $PYTHON in the configuration of the optionroms

Posted by Daniel P. Berrangé 3 weeks, 2 days ago

On Wed, Jan 14, 2026 at 09:33:06AM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> pc-bios/optionrom/Makefile uses $(PYTHON) for running a Python script,
> but this variable is never initialized here. So the script gets run
> via its shebang line - which fails if the "python3" binary is not
> available on the system. To fix this, write the PYTHON configuration
> to the config.mak file of the optionroms.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|