tests/qemu-iotests: Mark 182 as Linux-only

[PATCH] tests/qemu-iotests: Mark 182 as Linux-only

Posted by Thomas Huth 3 weeks, 3 days ago

From: Thomas Huth <thuth@redhat.com>

Running test 182 on FreeBSD fails with this error message in the output:

 +warning: File lock requested but OFD locking syscall is unavailable, falling back to POSIX file locks
 +Due to the implementation, locks can be lost unexpectedly.

OFD locks seem to be only available on Linux, so let's mark this
test as Linux-only to silence the failure.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/182 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/182 b/tests/qemu-iotests/182
index bbd1132b052..af5eeb599c1 100755
--- a/tests/qemu-iotests/182
+++ b/tests/qemu-iotests/182
@@ -43,6 +43,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _supported_fmt qcow2
 _supported_proto file
+_supported_os Linux
 
 size=32M
 
-- 
2.52.0

Re: [PATCH] tests/qemu-iotests: Mark 182 as Linux-only

Posted by Eric Blake 3 weeks, 2 days ago

On Tue, Jan 13, 2026 at 03:17:44PM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Running test 182 on FreeBSD fails with this error message in the output:
> 
>  +warning: File lock requested but OFD locking syscall is unavailable, falling back to POSIX file locks
>  +Due to the implementation, locks can be lost unexpectedly.
> 
> OFD locks seem to be only available on Linux, so let's mark this
> test as Linux-only to silence the failure.

OFD locks are part of POSIX now, so eventually new-enough BSD will
have them.  Is it worth trying to be more specific and testing for the
actual feature that we are depending on, rather than just limiting the
test to an early-adopter OS?  That said, I don't have any quick ideas
on how to do a more-specific feature test, so I don't mind this going
in as-is; we already know BSD gets less coverage for other reasons.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org

Re: [PATCH] tests/qemu-iotests: Mark 182 as Linux-only

Posted by Daniel P. Berrangé 3 weeks, 3 days ago

On Tue, Jan 13, 2026 at 03:17:44PM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Running test 182 on FreeBSD fails with this error message in the output:
> 
>  +warning: File lock requested but OFD locking syscall is unavailable, falling back to POSIX file locks
>  +Due to the implementation, locks can be lost unexpectedly.
> 
> OFD locks seem to be only available on Linux, so let's mark this
> test as Linux-only to silence the failure.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qemu-iotests/182 | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|