[v2] tests: do more testing of block drivers

[PATCH v2 03/13] tests: remove redundant meson suite for iotests

Posted by Daniel P. Berrangé 3 weeks, 6 days ago

If a test is in the 'block-slow' or 'block-thorough' suite, there is no
need to also add it to the 'slow' or 'thorough' suites.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/qemu-iotests/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index d7bae71ced..bf588cc2c9 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -33,7 +33,7 @@ foreach format, speed: qemu_iotests_formats
   if speed == 'quick'
     suites = 'block'
   else
-    suites = ['block-' + speed, speed]
+    suites = ['block-' + speed]
   endif
 
   args = ['-tap', '-' + format]
-- 
2.52.0

Re: [PATCH v2 03/13] tests: remove redundant meson suite for iotests

Posted by Thomas Huth 3 weeks, 5 days ago

On 12/01/2026 21.40, Daniel P. Berrangé wrote:
> If a test is in the 'block-slow' or 'block-thorough' suite, there is no
> need to also add it to the 'slow' or 'thorough' suites.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/qemu-iotests/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index d7bae71ced..bf588cc2c9 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -33,7 +33,7 @@ foreach format, speed: qemu_iotests_formats
>     if speed == 'quick'
>       suites = 'block'
>     else
> -    suites = ['block-' + speed, speed]
> +    suites = ['block-' + speed]
>     endif

Oh, weird, I was pretty sure that this was necessary at one point in time in 
the past ... but I just checked, and it now seems to work without this, 
indeed, so:

Tested-by: Thomas Huth <thuth@redhat.com>

By the way, we've got the same thing in tests/functional/meson.build, too...

  Thomas