[PATCH v2 09/13] tests: add nbd and luks to the I/O test suites

Daniel P. Berrangé posted 13 patches 3 weeks, 6 days ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
There is a newer version of this series
[PATCH v2 09/13] tests: add nbd and luks to the I/O test suites
Posted by Daniel P. Berrangé 3 weeks, 6 days ago
This introduces new suites for running I/O tests on NBD and LUKS
drivers, giving new make targets

 * make check-block-luks
 * make check-block-nbd

as well as adding their tests to 'make check-block SPEED=thorough'

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/devel/testing/main.rst    | 4 ++--
 tests/qemu-iotests/meson.build | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs/devel/testing/main.rst b/docs/devel/testing/main.rst
index ec29cf7708..910ec11ab4 100644
--- a/docs/devel/testing/main.rst
+++ b/docs/devel/testing/main.rst
@@ -235,8 +235,8 @@ formats. The most comprehensive test plan can be run by defining
 ``SPEED=thorough``, which enables all available tests for every format.
 
 This set of formats currently enabled for make integration are
-``parallels``, ``qcow2``, ``qed``, ``raw``, ``vdi``, ``vhdx``,
-``vmdk``, and ``vpc``.
+``luks``, ``nbd``, ``parallels``, ``qcow2``, ``qed``, ``raw``, ``vdi``,
+``vhdx``, ``vmdk``, and ``vpc``.
 
 Each of formats also has its own dedicated make target, named
 ``make check-block-$FORMAT`` which will run all available tests for
diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index 66b09d6b97..744d0b6e88 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -15,12 +15,14 @@ qemu_iotests_env = {'PYTHON': python.full_path()}
 qemu_iotests_formats = {
   'qcow2': 'quick',
   'raw': 'slow',
+  'luks': 'thorough',
+  'nbd': 'thorough',
   'parallels': 'thorough',
   'qed': 'thorough',
   'vdi': 'thorough',
   'vhdx': 'thorough',
   'vmdk': 'thorough',
-  'vpc': 'thorough'
+  'vpc': 'thorough',
 }
 
 foreach k, v : emulators
-- 
2.52.0


Re: [PATCH v2 09/13] tests: add nbd and luks to the I/O test suites
Posted by Thomas Huth 3 weeks, 5 days ago
On 12/01/2026 21.40, Daniel P. Berrangé wrote:
> This introduces new suites for running I/O tests on NBD and LUKS
> drivers, giving new make targets
> 
>   * make check-block-luks
>   * make check-block-nbd
> 
> as well as adding their tests to 'make check-block SPEED=thorough'
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   docs/devel/testing/main.rst    | 4 ++--
>   tests/qemu-iotests/meson.build | 4 +++-
>   2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/devel/testing/main.rst b/docs/devel/testing/main.rst
> index ec29cf7708..910ec11ab4 100644
> --- a/docs/devel/testing/main.rst
> +++ b/docs/devel/testing/main.rst
> @@ -235,8 +235,8 @@ formats. The most comprehensive test plan can be run by defining
>   ``SPEED=thorough``, which enables all available tests for every format.
>   
>   This set of formats currently enabled for make integration are

Should we change the wording now to "formats/protocols" since "luks" is 
rather a protocol than a format?

> -``parallels``, ``qcow2``, ``qed``, ``raw``, ``vdi``, ``vhdx``,
> -``vmdk``, and ``vpc``.
> +``luks``, ``nbd``, ``parallels``, ``qcow2``, ``qed``, ``raw``, ``vdi``,
> +``vhdx``, ``vmdk``, and ``vpc``.
>   
>   Each of formats also has its own dedicated make target, named
>   ``make check-block-$FORMAT`` which will run all available tests for
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index 66b09d6b97..744d0b6e88 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -15,12 +15,14 @@ qemu_iotests_env = {'PYTHON': python.full_path()}
>   qemu_iotests_formats = {

And change it to "qemu_iotests_blockdrivers" (or just "blockdrivers") now?

>     'qcow2': 'quick',
>     'raw': 'slow',
> +  'luks': 'thorough',
> +  'nbd': 'thorough',
>     'parallels': 'thorough',
>     'qed': 'thorough',
>     'vdi': 'thorough',
>     'vhdx': 'thorough',
>     'vmdk': 'thorough',
> -  'vpc': 'thorough'
> +  'vpc': 'thorough',
>   }
>   
>   foreach k, v : emulators

  Thomas


Re: [PATCH v2 09/13] tests: add nbd and luks to the I/O test suites
Posted by Daniel P. Berrangé 3 weeks, 4 days ago
On Tue, Jan 13, 2026 at 01:52:45PM +0100, Thomas Huth wrote:
> On 12/01/2026 21.40, Daniel P. Berrangé wrote:
> > This introduces new suites for running I/O tests on NBD and LUKS
> > drivers, giving new make targets
> > 
> >   * make check-block-luks
> >   * make check-block-nbd
> > 
> > as well as adding their tests to 'make check-block SPEED=thorough'
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   docs/devel/testing/main.rst    | 4 ++--
> >   tests/qemu-iotests/meson.build | 4 +++-
> >   2 files changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/docs/devel/testing/main.rst b/docs/devel/testing/main.rst
> > index ec29cf7708..910ec11ab4 100644
> > --- a/docs/devel/testing/main.rst
> > +++ b/docs/devel/testing/main.rst
> > @@ -235,8 +235,8 @@ formats. The most comprehensive test plan can be run by defining
> >   ``SPEED=thorough``, which enables all available tests for every format.
> >   This set of formats currently enabled for make integration are
> 
> Should we change the wording now to "formats/protocols" since "luks" is
> rather a protocol than a format?

Actually 'luks' is a format, but 'nbd' is a protocol.

> 
> > -``parallels``, ``qcow2``, ``qed``, ``raw``, ``vdi``, ``vhdx``,
> > -``vmdk``, and ``vpc``.
> > +``luks``, ``nbd``, ``parallels``, ``qcow2``, ``qed``, ``raw``, ``vdi``,
> > +``vhdx``, ``vmdk``, and ``vpc``.
> >   Each of formats also has its own dedicated make target, named
> >   ``make check-block-$FORMAT`` which will run all available tests for
> > diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> > index 66b09d6b97..744d0b6e88 100644
> > --- a/tests/qemu-iotests/meson.build
> > +++ b/tests/qemu-iotests/meson.build
> > @@ -15,12 +15,14 @@ qemu_iotests_env = {'PYTHON': python.full_path()}
> >   qemu_iotests_formats = {
> 
> And change it to "qemu_iotests_blockdrivers" (or just "blockdrivers") now?

Yes, I'll do this renaming in docs/makefiles/meson in a separate commit,
using 'driver' as a generic term to cover either protocols or formats.

> 
> >     'qcow2': 'quick',
> >     'raw': 'slow',
> > +  'luks': 'thorough',
> > +  'nbd': 'thorough',
> >     'parallels': 'thorough',
> >     'qed': 'thorough',
> >     'vdi': 'thorough',
> >     'vhdx': 'thorough',
> >     'vmdk': 'thorough',
> > -  'vpc': 'thorough'
> > +  'vpc': 'thorough',
> >   }
> >   foreach k, v : emulators
> 
>  Thomas
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|