[PATCH v6 00/19] target/arm/hvf: Consolidate

Philippe Mathieu-Daudé posted 19 patches 3 weeks, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260112103034.65310-1-philmd@linaro.org
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Cameron Esfahani <dirty@apple.com>, Roman Bolshakov <rbolshakov@ddn.com>, Phil Dennis-Jordan <phil@philjordan.eu>, Mads Ynddal <mads@ynddal.dk>, Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@csgraf.de>
include/accel/accel-cpu-ops.h |   1 +
include/system/hvf_int.h      |  22 +---
accel/accel-common.c          |   5 +
accel/hvf/hvf-accel-ops.c     |  18 +---
accel/hvf/hvf-all.c           | 186 ++++++++++------------------------
target/arm/cpu.c              |  67 ++++++------
target/arm/hvf/hvf.c          | 167 +++++++++++++++---------------
target/i386/hvf/hvf.c         |  44 ++++----
accel/hvf/trace-events        |   1 +
9 files changed, 208 insertions(+), 303 deletions(-)
[PATCH v6 00/19] target/arm/hvf: Consolidate
Posted by Philippe Mathieu-Daudé 3 weeks, 6 days ago
Series fully reviewed.

- Patches 1-11 fix migration on HVF
- Patches 12-14 remove a signal race with WFI
- Patches 15-18 correct guest timer frequency

Since v5:
- Rebased on top of 3bee93b9abf ("Fix i386 HVF compilation failures")

Since v4:
- Rename gva -> gpa in hvf_set_phys_mem (Akihiko)
- Dropped missing VTimer synchronization patches for 10.2

Since v3:
- Call qemu_real_host_page_mask/size once (rth)

Since v2:
- Improve host page size/mask uses (rth)
- Remove cpu_test_interrupt in hvf_wfi (rth)

Since v1:
- Addressed Mads & Richard comments
- Fixed migration by reworking memory listeners
  (unfortunately the current broken code has been
   used as base for WHPX)
- Sync CNTV_CTL/CVAL_EL0
- Remove WFI racy signal implementation
- Simplify PSCI Suspend (I expect the same can be
  done for the other hvf_psci_cpu_off() calls).
- Emulate more missing registers (PMU & Monitor Dbg)

From v1:
- Fix a pair of memory leak
- Check a pair of return values
- Mention calls which must be run on vCPU thread
- Force MIDR
- Use hv_vcpu_config_create/hv_vcpu_config_get_feature_reg
  when not running on vCPU thread
- Factor hvf_handle_vmexit() / hvf_handle_exception(() out
- Call hv_vcpu_run() in loop
- Guard hv_vcpu_run() between cpu_exec_start/end()
- Restrict ARM specific in AccelCPUState

Philippe Mathieu-Daudé (10):
  target/i386/hvf: Use host page alignment in ept_emulation_fault()
  accel/hvf: Enforce host alignment in hv_vm_protect()
  accel/hvf: Skip WFI if CPU has work to do
  accel/hvf: Implement WFI without using pselect()
  accel/hvf: Have PSCI CPU_SUSPEND halt the vCPU
  accel: Introduce AccelOpsClass::cpu_target_realize() hook
  accel/hvf: Add hvf_arch_cpu_realize() stubs
  target/arm: Create GTimers *after* features finalized / accel realized
  target/arm/hvf: Really set Generic Timer counter frequency
  target/arm: Only allow disabling NEON when using TCG

Richard Henderson (9):
  accel/hvf: Create hvf_protect_clean_range, hvf_unprotect_dirty_range
  target/i386/hvf: Use hvf_unprotect_dirty_range
  target/i386/hvf: Use address_space_translate in ept_emulation_fault
  accel/hvf: Simplify hvf_log_*
  accel/hvf: Move hvf_log_sync to hvf_log_clear
  accel/hvf: Simplify hvf_set_phys_mem
  accel/hvf: Drop hvf_slot and hvf_find_overlap_slot
  accel/hvf: Remove mac_slots
  target/arm/hvf: Implement dirty page tracking

 include/accel/accel-cpu-ops.h |   1 +
 include/system/hvf_int.h      |  22 +---
 accel/accel-common.c          |   5 +
 accel/hvf/hvf-accel-ops.c     |  18 +---
 accel/hvf/hvf-all.c           | 186 ++++++++++------------------------
 target/arm/cpu.c              |  67 ++++++------
 target/arm/hvf/hvf.c          | 167 +++++++++++++++---------------
 target/i386/hvf/hvf.c         |  44 ++++----
 accel/hvf/trace-events        |   1 +
 9 files changed, 208 insertions(+), 303 deletions(-)

-- 
2.52.0


Re: [PATCH v6 00/19] target/arm/hvf: Consolidate
Posted by Peter Maydell 3 weeks, 6 days ago
On Mon, 12 Jan 2026 at 10:30, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Series fully reviewed.
>
> - Patches 1-11 fix migration on HVF
> - Patches 12-14 remove a signal race with WFI
> - Patches 15-18 correct guest timer frequency
>
> Since v5:
> - Rebased on top of 3bee93b9abf ("Fix i386 HVF compilation failures")

Would you like me to take this via target-arm.next or are
you planning to send a pullreq for it? I don't mind either
way; I don't have any convenient machine for testing hvf
with, so via my tree it's mostly just avoiding possible
conflicts with other arm patches.

thanks
-- PMM
Re: [PATCH v6 00/19] target/arm/hvf: Consolidate
Posted by Philippe Mathieu-Daudé 3 weeks, 2 days ago
Hi Peter,

On 12/1/26 18:24, Peter Maydell wrote:
> On Mon, 12 Jan 2026 at 10:30, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> Series fully reviewed.
>>
>> - Patches 1-11 fix migration on HVF
>> - Patches 12-14 remove a signal race with WFI
>> - Patches 15-18 correct guest timer frequency
>>
>> Since v5:
>> - Rebased on top of 3bee93b9abf ("Fix i386 HVF compilation failures")
> 
> Would you like me to take this via target-arm.next or are
> you planning to send a pullreq for it? I don't mind either
> way; I don't have any convenient machine for testing hvf
> with, so via my tree it's mostly just avoiding possible
> conflicts with other arm patches.

I took me some time to go back to you because I ran exhaustive testing
to feel confident enough. No I am, but I only tested UNIX guests so far.

I updated patches to strengthen our HVF testing on CI, but this doesn't
have to block this patchset (which other depends on). Since you already
posted your target-arm PR I'll take on your kind offer and send another
one myself.

Regards,

Phil.