[PATCH v2 3/4] dump: Abort in create_win_dump() on non-x86 guests

Philippe Mathieu-Daudé posted 4 patches 1 month ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Ani Sinha <anisinha@redhat.com>
There is a newer version of this series
[PATCH v2 3/4] dump: Abort in create_win_dump() on non-x86 guests
Posted by Philippe Mathieu-Daudé 1 month ago
qmp_dump_guest_memory() checks win_dump_available()
before calling create_win_dump(). On non-x86 targets
calling it would be a programming error, so abort.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 dump/win_dump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dump/win_dump.c b/dump/win_dump.c
index d42427feb22..e5fdc12ad34 100644
--- a/dump/win_dump.c
+++ b/dump/win_dump.c
@@ -506,7 +506,7 @@ bool win_dump_available(DumpState *s, Error **errp)
 
 void create_win_dump(DumpState *s, Error **errp)
 {
-    win_dump_available(s, errp);
+    g_assert_not_reached();
 }
 
 #endif
-- 
2.52.0