cpu_reset clean-ups for arm, sh4, mips, m68k and tricore

[RFC PATCH 07/12] target/m68k: drop cpu_reset on realizefn

Posted by Alex Bennée 1 month ago

Now all the m68k machines have cpu reset handlers we can drop this
extra case here.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 target/m68k/cpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
index f1b673119d6..a540a754969 100644
--- a/target/m68k/cpu.c
+++ b/target/m68k/cpu.c
@@ -392,7 +392,6 @@ static void m68k_cpu_realizefn(DeviceState *dev, Error **errp)
 
     m68k_cpu_init_gdb(cpu);
 
-    cpu_reset(cs);
     qemu_init_vcpu(cs);
 
     mcc->parent_realize(dev, errp);
-- 
2.47.3

Re: [RFC PATCH 07/12] target/m68k: drop cpu_reset on realizefn

Posted by Richard Henderson 4 weeks, 1 day ago

On 1/9/26 01:34, Alex Bennée wrote:
> Now all the m68k machines have cpu reset handlers we can drop this
> extra case here.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   target/m68k/cpu.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
> index f1b673119d6..a540a754969 100644
> --- a/target/m68k/cpu.c
> +++ b/target/m68k/cpu.c
> @@ -392,7 +392,6 @@ static void m68k_cpu_realizefn(DeviceState *dev, Error **errp)
>   
>       m68k_cpu_init_gdb(cpu);
>   
> -    cpu_reset(cs);
>       qemu_init_vcpu(cs);
>   
>       mcc->parent_realize(dev, errp);

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [RFC PATCH 07/12] target/m68k: drop cpu_reset on realizefn

Posted by Thomas Huth 1 month ago

Am Thu,  8 Jan 2026 14:34:18 +0000
schrieb Alex Bennée <alex.bennee@linaro.org>:

> Now all the m68k machines have cpu reset handlers we can drop this
> extra case here.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  target/m68k/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
> index f1b673119d6..a540a754969 100644
> --- a/target/m68k/cpu.c
> +++ b/target/m68k/cpu.c
> @@ -392,7 +392,6 @@ static void m68k_cpu_realizefn(DeviceState *dev, Error **errp)
>  
>      m68k_cpu_init_gdb(cpu);
>  
> -    cpu_reset(cs);
>      qemu_init_vcpu(cs);
>  
>      mcc->parent_realize(dev, errp);

Reviewed-by: Thomas Huth <huth@tuxfamily.org>