[PATCH 4/7] target/xtensa: Build system units in common source set

Philippe Mathieu-Daudé posted 7 patches 1 month ago
Maintainers: Max Filippov <jcmvbkbc@gmail.com>, Laurent Vivier <laurent@vivier.eu>
[PATCH 4/7] target/xtensa: Build system units in common source set
Posted by Philippe Mathieu-Daudé 1 month ago
These files are now free of target-specific symbols,
build them as common files (thus forbidding further
uses of such target-specific symbols).

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/xtensa/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/xtensa/meson.build b/target/xtensa/meson.build
index f8d60101e3d..69c6946420a 100644
--- a/target/xtensa/meson.build
+++ b/target/xtensa/meson.build
@@ -24,4 +24,4 @@ xtensa_system_ss.add(files(
 ))
 
 target_arch += {'xtensa': xtensa_ss}
-target_system_arch += {'xtensa': xtensa_system_ss}
+target_common_system_arch += {'xtensa': xtensa_system_ss}
-- 
2.52.0


Re: [PATCH 4/7] target/xtensa: Build system units in common source set
Posted by Anton Johansson via qemu development 3 weeks, 6 days ago
On 07/01/26, Philippe Mathieu-Daudé wrote:
> These files are now free of target-specific symbols,
> build them as common files (thus forbidding further
> uses of such target-specific symbols).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/xtensa/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/xtensa/meson.build b/target/xtensa/meson.build
> index f8d60101e3d..69c6946420a 100644
> --- a/target/xtensa/meson.build
> +++ b/target/xtensa/meson.build
> @@ -24,4 +24,4 @@ xtensa_system_ss.add(files(
>  ))
>  
>  target_arch += {'xtensa': xtensa_ss}
> -target_system_arch += {'xtensa': xtensa_system_ss}
> +target_common_system_arch += {'xtensa': xtensa_system_ss}
> -- 
> 2.52.0
> 
> 

all of dbg_helper.c, mmu_helper.c, monitor.c, and xtensa-semi.c include
cpu.h, change to target/xtensa/cpu.h.

Otherwise,

Reviewed-by: Anton Johansson <anjo@rev.ng>