target/misc: Protect few system binaries for target_ulong use

[PATCH 8/9] target/hppa: Remove target_ulong use in disas_log() handler

Posted by Philippe Mathieu-Daudé 1 month ago

Since commit 85c19af63e7 ("include/exec: Use vaddr in DisasContextBase
virtual addresses") the DisasContextBase::pc_first field is a vaddr
type.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hppa/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 0b7074649b7..0f8a66f7732 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -4864,7 +4864,7 @@ static void hppa_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
 static bool hppa_tr_disas_log(const DisasContextBase *dcbase,
                               CPUState *cs, FILE *logfile)
 {
-    target_ulong pc = dcbase->pc_first;
+    vaddr pc = dcbase->pc_first;
 
     switch (pc) {
     case 0x00:
-- 
2.52.0

Re: [PATCH 8/9] target/hppa: Remove target_ulong use in disas_log() handler

Posted by Richard Henderson 4 weeks, 1 day ago

On 1/8/26 07:07, Philippe Mathieu-Daudé wrote:
> Since commit 85c19af63e7 ("include/exec: Use vaddr in DisasContextBase
> virtual addresses") the DisasContextBase::pc_first field is a vaddr
> type.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/hppa/translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 0b7074649b7..0f8a66f7732 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -4864,7 +4864,7 @@ static void hppa_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
>   static bool hppa_tr_disas_log(const DisasContextBase *dcbase,
>                                 CPUState *cs, FILE *logfile)
>   {
> -    target_ulong pc = dcbase->pc_first;
> +    vaddr pc = dcbase->pc_first;
>   
>       switch (pc) {
>       case 0x00:

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~