io: fix mem leak when using QIOTask in TLS and websock channels

[PATCH 0/3] io: fix mem leak when using QIOTask in TLS and websock channels

Daniel P. Berrangé posted 3 patches 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260107153442.1832957-1-berrange@redhat.com

Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>

include/io/task.h         | 29 +++++++++++++------
io/channel-tls.c          | 60 ++++++++++++++++++++++++++-------------
io/channel-websock.c      |  2 +-
io/task.c                 |  8 ++++--
tests/unit/test-io-task.c | 26 +++++++++++++++++
5 files changed, 94 insertions(+), 31 deletions(-)

Expand all Fold all

[PATCH 0/3] io: fix mem leak when using QIOTask in TLS and websock channels

Posted by Daniel P. Berrangé 1 month ago

The handshake functions in the TLS and websock channels could leak
a QIOTask and some related data if the underlying channel was torn
down before the handshake completed. This also applies to the async
TLS "bye" tasks.

Fixing this required refactoring the QIOTask cleanup paradigm
slightly.

This is a followup to a proposed fix at

  https://lists.nongnu.org/archive/html/qemu-devel/2025-09/msg02984.html

and also reported at

  https://gitlab.com/qemu-project/qemu/-/issues/3114

Daniel P. Berrangé (3):
  io: separate freeing of tasks from marking them as complete
  io: fix cleanup for TLS I/O source data on cancellation
  io: fix cleanup for websock I/O source data on cancellation

 include/io/task.h         | 29 +++++++++++++------
 io/channel-tls.c          | 60 ++++++++++++++++++++++++++-------------
 io/channel-websock.c      |  2 +-
 io/task.c                 |  8 ++++--
 tests/unit/test-io-task.c | 26 +++++++++++++++++
 5 files changed, 94 insertions(+), 31 deletions(-)

-- 
2.52.0