1. Patchew
  2. QEMU
  3. [PATCH 00/18] target/s390x: Prohibit target_ulong and TARGET_PAGE_SIZE uses
  4. View patch

[PATCH 05/18] target/s390x: Remove unused 'gdbstub/helpers.h' header in helper.c

Philippe Mathieu-Daudé posted 18 patches 1 month ago
Maintainers: Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>
There is a newer version of this series
[PATCH 05/18] target/s390x: Remove unused 'gdbstub/helpers.h' header in helper.c
Posted by Philippe Mathieu-Daudé 1 month ago 
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/s390x/helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/s390x/helper.c b/target/s390x/helper.c
index 8d1e03f6768..a6c89ed0af3 100644
--- a/target/s390x/helper.c
+++ b/target/s390x/helper.c
@@ -21,7 +21,6 @@
 #include "qemu/osdep.h"
 #include "cpu.h"
 #include "s390x-internal.h"
-#include "gdbstub/helpers.h"
 #include "qemu/timer.h"
 #include "hw/s390x/ioinst.h"
 #include "system/hw_accel.h"
-- 
2.52.0
Re: [PATCH 05/18] target/s390x: Remove unused 'gdbstub/helpers.h' header in helper.c
Posted by Thomas Huth 1 month ago 
On 07/01/2026 14.07, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/s390x/helper.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 8d1e03f6768..a6c89ed0af3 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -21,7 +21,6 @@
>   #include "qemu/osdep.h"
>   #include "cpu.h"
>   #include "s390x-internal.h"
> -#include "gdbstub/helpers.h"
>   #include "qemu/timer.h"
>   #include "hw/s390x/ioinst.h"
>   #include "system/hw_accel.h"

Tested-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH 05/18] target/s390x: Remove unused 'gdbstub/helpers.h' header in helper.c
Posted by Philippe Mathieu-Daudé 1 month ago 
On 7/1/26 14:07, Philippe Mathieu-Daudé wrote:

Updated description:

     "gdbstub/helpers.h" uses target-specific symbols, but we don't
     need it, so remove it.

> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/s390x/helper.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 8d1e03f6768..a6c89ed0af3 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -21,7 +21,6 @@
>   #include "qemu/osdep.h"
>   #include "cpu.h"
>   #include "s390x-internal.h"
> -#include "gdbstub/helpers.h"
>   #include "qemu/timer.h"
>   #include "hw/s390x/ioinst.h"
>   #include "system/hw_accel.h"
Re: [PATCH 05/18] target/s390x: Remove unused 'gdbstub/helpers.h' header in helper.c
Posted by Richard Henderson 1 month ago 
On 1/8/26 07:09, Philippe Mathieu-Daudé wrote:
> On 7/1/26 14:07, Philippe Mathieu-Daudé wrote:
> 
> Updated description:
> 
>      "gdbstub/helpers.h" uses target-specific symbols, but we don't
>      need it, so remove it.
> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   target/s390x/helper.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
>> index 8d1e03f6768..a6c89ed0af3 100644
>> --- a/target/s390x/helper.c
>> +++ b/target/s390x/helper.c
>> @@ -21,7 +21,6 @@
>>   #include "qemu/osdep.h"
>>   #include "cpu.h"
>>   #include "s390x-internal.h"
>> -#include "gdbstub/helpers.h"
>>   #include "qemu/timer.h"
>>   #include "hw/s390x/ioinst.h"
>>   #include "system/hw_accel.h"
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.