[PATCH 0/4] tests/docker: improve detection of docker/podman

Daniel P. Berrangé posted 4 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260107130145.1495219-1-berrange@redhat.com
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
.gitlab-ci.d/base.yml         |  3 +++
configure                     | 19 +++++++------------
tests/docker/Makefile.include | 23 ++++++++++++++---------
tests/docker/docker.py        | 17 +++++++----------
4 files changed, 31 insertions(+), 31 deletions(-)
[PATCH 0/4] tests/docker: improve detection of docker/podman
Posted by Daniel P. Berrangé 1 month ago
This improves integration such that tests/docker/Makefile.include will
correctly honour the exact command detected by docker.py's probing
logic. Currently the probe command gets stripped down to just a bare
'podman' or 'docker' command name. This means while commands run via
'docker.py' would use 'sudo -n docker', commands run directly from
Makefile.include would only use 'docker'.

This series fixes that so that 'docker.py probe' correctly reports the
full argv, and configure honours that argv untouched.

With that fixed, we can then also add support for 'podman --remote'
and 'podman-remote', which allow use of podman when already inside
podman which is the scenario for my development environment that is
using 'toolbox'.

Finally this also improves CI by ensuring that stdout from docker is
not thrown away, so we can have a chance of diagnosing build failures
from CI.

Daniel P. Berrangé (4):
  tests/docker: improve handling of docker probes
  tests/docker: allow display of docker output
  gitlab: ensure docker output is always displayed in CI
  tests/docker: add support for podman remote access

 .gitlab-ci.d/base.yml         |  3 +++
 configure                     | 19 +++++++------------
 tests/docker/Makefile.include | 23 ++++++++++++++---------
 tests/docker/docker.py        | 17 +++++++----------
 4 files changed, 31 insertions(+), 31 deletions(-)

-- 
2.52.0


Re: [PATCH 0/4] tests/docker: improve detection of docker/podman
Posted by Daniel P. Berrangé 1 day, 13 hours ago
Ping: any thoughts on this series of CI improvements ?

On Wed, Jan 07, 2026 at 01:01:41PM +0000, Daniel P. Berrangé wrote:
> This improves integration such that tests/docker/Makefile.include will
> correctly honour the exact command detected by docker.py's probing
> logic. Currently the probe command gets stripped down to just a bare
> 'podman' or 'docker' command name. This means while commands run via
> 'docker.py' would use 'sudo -n docker', commands run directly from
> Makefile.include would only use 'docker'.
> 
> This series fixes that so that 'docker.py probe' correctly reports the
> full argv, and configure honours that argv untouched.
> 
> With that fixed, we can then also add support for 'podman --remote'
> and 'podman-remote', which allow use of podman when already inside
> podman which is the scenario for my development environment that is
> using 'toolbox'.
> 
> Finally this also improves CI by ensuring that stdout from docker is
> not thrown away, so we can have a chance of diagnosing build failures
> from CI.
> 
> Daniel P. Berrangé (4):
>   tests/docker: improve handling of docker probes
>   tests/docker: allow display of docker output
>   gitlab: ensure docker output is always displayed in CI
>   tests/docker: add support for podman remote access
> 
>  .gitlab-ci.d/base.yml         |  3 +++
>  configure                     | 19 +++++++------------
>  tests/docker/Makefile.include | 23 ++++++++++++++---------
>  tests/docker/docker.py        | 17 +++++++----------
>  4 files changed, 31 insertions(+), 31 deletions(-)
> 
> -- 
> 2.52.0
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|