[v2] target/alpha: Use explicit little-endian LD/ST API

[PATCH v2 6/8] target/alpha: Replace MO_TE -> MO_LE

Posted by Philippe Mathieu-Daudé 1 month ago

We only build the Alpha targets using little endianness order:

  $ git grep -L TARGET_BIG_ENDIAN configs/targets/alpha-*
  configs/targets/alpha-linux-user.mak
  configs/targets/alpha-softmmu.mak

Therefore the MO_TE definition always expands to MO_LE. Use the
latter to simplify.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/alpha/translate.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index 4f918cbfe63..d9248e54eb6 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -98,7 +98,11 @@ static TCGv cpu_pal_ir[31];
 
 static inline MemOp mo_endian(DisasContext *dc)
 {
-    return MO_TE;
+    /*
+     * Technically, Alpha can be run in big-endian mode, but we don't bother.
+     * This was only ever used for the Cray T3[DE] machines.  :-)
+     */
+    return MO_LE;
 }
 
 void alpha_translate_init(void)
-- 
2.52.0

Re: [PATCH v2 6/8] target/alpha: Replace MO_TE -> MO_LE

Posted by Pierrick Bouvier 1 month ago

On 1/6/26 7:57 AM, Philippe Mathieu-Daudé wrote:
> We only build the Alpha targets using little endianness order:
> 
>    $ git grep -L TARGET_BIG_ENDIAN configs/targets/alpha-*
>    configs/targets/alpha-linux-user.mak
>    configs/targets/alpha-softmmu.mak
> 
> Therefore the MO_TE definition always expands to MO_LE. Use the
> latter to simplify.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/alpha/translate.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>