hw/ipmi/ipmi_bmc_sim.c | 412 +++++++++++++++++++++++++++++++++++- include/hw/ipmi/ipmi.h | 1 + qemu-options.hx | 26 +++ tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++ 4 files changed, 572 insertions(+), 10 deletions(-)
Hi Philippe, Thank you for your comments. I've modified my patches according to your advice. Kind regards, Yunpeng v1...v2: --- 1. `is_valid_netmask` is renamed to `is_ipv4_netmask_valid`, and is now implemented using `ldl_be_p`, `clo32`, and `ctz32`. It still ensures the netmask is not `0.0.0.0`. I didn't find any related helper functions in `include/`. 2. Now the `IPMILan` structure has its own `VMStateDescription`. It's linked to the parent `VMStateDescription` using `VMSTATE_STRUCT`. --- Links: * version 1 patches: https://lists.gnu.org/archive/html/qemu-devel/2025-10/msg07505.html * comments from Philippe Mathieu-Daudé <philmd@linaro.org>: https://lists.gnu.org/archive/html/qemu-devel/2025-12/msg00117.html Yunpeng Yang (2): hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config hw/ipmi/ipmi_bmc_sim.c | 412 +++++++++++++++++++++++++++++++++++- include/hw/ipmi/ipmi.h | 1 + qemu-options.hx | 26 +++ tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++ 4 files changed, 572 insertions(+), 10 deletions(-) -- 2.43.7
On Mon, Jan 05, 2026 at 03:56:49PM +0000, Yunpeng Yang wrote: > Hi Philippe, > > Thank you for your comments. > I've modified my patches according to your advice. > > Kind regards, > Yunpeng > > > v1...v2: > --- > 1. `is_valid_netmask` is renamed to `is_ipv4_netmask_valid`, and is now > implemented using `ldl_be_p`, `clo32`, and `ctz32`. It still ensures > the netmask is not `0.0.0.0`. > I didn't find any related helper functions in `include/`. I couldn't find anything, either. > 2. Now the `IPMILan` structure has its own `VMStateDescription`. It's > linked to the parent `VMStateDescription` using `VMSTATE_STRUCT`. > --- > This looks good to me, I'll pull this in to my tree and pass it on. -corey > > Links: > * version 1 patches: > https://lists.gnu.org/archive/html/qemu-devel/2025-10/msg07505.html > * comments from Philippe Mathieu-Daudé <philmd@linaro.org>: > https://lists.gnu.org/archive/html/qemu-devel/2025-12/msg00117.html > > > Yunpeng Yang (2): > hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config > hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config > > hw/ipmi/ipmi_bmc_sim.c | 412 +++++++++++++++++++++++++++++++++++- > include/hw/ipmi/ipmi.h | 1 + > qemu-options.hx | 26 +++ > tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++ > 4 files changed, 572 insertions(+), 10 deletions(-) > > -- > 2.43.7 >
Hi Corey, Thank you for reviewing! Kind regards, Yunpeng >> Hi Philippe, >> >> Thank you for your comments. >> I've modified my patches according to your advice. >> >> Kind regards, >> Yunpeng >> >> >> v1...v2: >> --- >> 1. `is_valid_netmask` is renamed to `is_ipv4_netmask_valid`, and is now >> implemented using `ldl_be_p`, `clo32`, and `ctz32`. It still ensures >> the netmask is not `0.0.0.0`. >> I didn't find any related helper functions in `include/`. > >I couldn't find anything, either. > >> 2. Now the `IPMILan` structure has its own `VMStateDescription`. It's >> linked to the parent `VMStateDescription` using `VMSTATE_STRUCT`. >> --- >> > >This looks good to me, I'll pull this in to my tree and pass it on. > >-corey > >> >> Links: >> * version 1 patches: >> https://lists.gnu.org/archive/html/qemu-devel/2025-10/msg07505.html >> * comments from Philippe Mathieu-Daudé <philmd@linaro.org>: >> https://lists.gnu.org/archive/html/qemu-devel/2025-12/msg00117.html >> >> >> Yunpeng Yang (2): >> hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config >> hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config >> >> hw/ipmi/ipmi_bmc_sim.c | 412 +++++++++++++++++++++++++++++++++++- >> include/hw/ipmi/ipmi.h | 1 + >> qemu-options.hx | 26 +++ >> tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++ >> 4 files changed, 572 insertions(+), 10 deletions(-) >> >> -- >> 2.43.7 >>
Hello Corey, I hope you are doing well! Could I know when you expect these two patches to be merged? Kind regards, Yunpeng ________________________________ From: Yunpeng Yang <yunpeng.yang@nutanix.com> Sent: Wednesday, January 7, 2026 17:58 To: Corey Minyard <corey@minyard.net> Cc: philmd@linaro.org <philmd@linaro.org>; minyard@acm.org <minyard@acm.org>; farosas@suse.de <farosas@suse.de>; lvivier@redhat.com <lvivier@redhat.com>; pbonzini@redhat.com <pbonzini@redhat.com>; qemu-devel@nongnu.org <qemu-devel@nongnu.org>; Mark Cave-Ayland <mark.caveayland@nutanix.com>; Jonathan Davies <jond@nutanix.com> Subject: Re: Re: [PATCH v2 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config Hi Corey, Thank you for reviewing! Kind regards, Yunpeng >> Hi Philippe, >> >> Thank you for your comments. >> I've modified my patches according to your advice. >> >> Kind regards, >> Yunpeng >> >> >> v1...v2: >> --- >> 1. `is_valid_netmask` is renamed to `is_ipv4_netmask_valid`, and is now >> implemented using `ldl_be_p`, `clo32`, and `ctz32`. It still ensures >> the netmask is not `0.0.0.0`. >> I didn't find any related helper functions in `include/`. > >I couldn't find anything, either. > >> 2. Now the `IPMILan` structure has its own `VMStateDescription`. It's >> linked to the parent `VMStateDescription` using `VMSTATE_STRUCT`. >> --- >> > >This looks good to me, I'll pull this in to my tree and pass it on. > >-corey > >> >> Links: >> * version 1 patches: >> https://lists.gnu.org/archive/html/qemu-devel/2025-10/msg07505.html >> * comments from Philippe Mathieu-Daudé <philmd@linaro.org>: >> https://lists.gnu.org/archive/html/qemu-devel/2025-12/msg00117.html >> >> >> Yunpeng Yang (2): >> hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config >> hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config >> >> hw/ipmi/ipmi_bmc_sim.c | 412 +++++++++++++++++++++++++++++++++++- >> include/hw/ipmi/ipmi.h | 1 + >> qemu-options.hx | 26 +++ >> tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++ >> 4 files changed, 572 insertions(+), 10 deletions(-) >> >> -- >> 2.43.7 >>
© 2016 - 2026 Red Hat, Inc.