[PATCH] docs/system/igvm.rst: Update external link

Jim MacArthur posted 1 patch 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251230-igvm-documentation-fix-v1-1-865750a66cc8@linaro.org
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Ani Sinha <anisinha@redhat.com>
docs/system/igvm.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] docs/system/igvm.rst: Update external link
Posted by Jim MacArthur 1 month, 1 week ago
Also updated revision to 3.43.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3247
Signed-off-by: Jim MacArthur <jim.macarthur@linaro.org>
---
Just fixes a broken link for the AMD64 Architecture Programmer's
Manual.
---
 docs/system/igvm.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/system/igvm.rst b/docs/system/igvm.rst
index 79508d9588..f45eb1707e 100644
--- a/docs/system/igvm.rst
+++ b/docs/system/igvm.rst
@@ -166,8 +166,8 @@ References
 ----------
 
 [1] AMD64 Architecture Programmer's Manual, Volume 2: System Programming
-  Rev 3.41
-  https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24593.pdf
+  Rev 3.43
+  https://docs.amd.com/v/u/en-US/24593_3.43
 
 [2] ``buildigvm`` - A tool to build example IGVM files containing OVMF firmware
   https://github.com/roy-hopkins/buildigvm
\ No newline at end of file

---
base-commit: 942b0d378a1de9649085ad6db5306d5b8cef3591
change-id: 20251230-igvm-documentation-fix-6a937c2cb9fc

Best regards,
-- 
Jim MacArthur <jim.macarthur@linaro.org>
Re: [PATCH] docs/system/igvm.rst: Update external link
Posted by Stefano Garzarella 3 weeks, 4 days ago
On Tue, Dec 30, 2025 at 07:23:33PM +0000, Jim MacArthur wrote:
>Also updated revision to 3.43.
>
>Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3247
>Signed-off-by: Jim MacArthur <jim.macarthur@linaro.org>
>---
>Just fixes a broken link for the AMD64 Architecture Programmer's
>Manual.
>---
> docs/system/igvm.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

I'm not sure the new link will be stable, maybe in the future we can 
just mention the manual name and version without any link.

>
>diff --git a/docs/system/igvm.rst b/docs/system/igvm.rst
>index 79508d9588..f45eb1707e 100644
>--- a/docs/system/igvm.rst
>+++ b/docs/system/igvm.rst
>@@ -166,8 +166,8 @@ References
> ----------
>
> [1] AMD64 Architecture Programmer's Manual, Volume 2: System Programming
>-  Rev 3.41
>-  https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24593.pdf
>+  Rev 3.43
>+  https://docs.amd.com/v/u/en-US/24593_3.43
>
> [2] ``buildigvm`` - A tool to build example IGVM files containing OVMF firmware
>   https://github.com/roy-hopkins/buildigvm

Oh, I just noticed this. We recently moved this in 
https://gitlab.com/qemu-project/buildigvm

Do you want to fix also that one?


In any case, this change LGTM:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Re: [PATCH] docs/system/igvm.rst: Update external link
Posted by Alex Bennée 1 month ago
Jim MacArthur <jim.macarthur@linaro.org> writes:

> Also updated revision to 3.43.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3247
> Signed-off-by: Jim MacArthur <jim.macarthur@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>

> ---
> Just fixes a broken link for the AMD64 Architecture Programmer's
> Manual.
> ---
>  docs/system/igvm.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/system/igvm.rst b/docs/system/igvm.rst
> index 79508d9588..f45eb1707e 100644
> --- a/docs/system/igvm.rst
> +++ b/docs/system/igvm.rst
> @@ -166,8 +166,8 @@ References
>  ----------
>  
>  [1] AMD64 Architecture Programmer's Manual, Volume 2: System Programming
> -  Rev 3.41
> -  https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24593.pdf
> +  Rev 3.43
> +  https://docs.amd.com/v/u/en-US/24593_3.43
>  
>  [2] ``buildigvm`` - A tool to build example IGVM files containing OVMF firmware
>    https://github.com/roy-hopkins/buildigvm
> \ No newline at end of file
>
> ---
> base-commit: 942b0d378a1de9649085ad6db5306d5b8cef3591
> change-id: 20251230-igvm-documentation-fix-6a937c2cb9fc
>
> Best regards,

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro