1. Patchew
  2. QEMU
  3. [PATCH v2 0/7] monitor: Merge hmp-cmds-target.c within hmp-cmds.c
  4. View patch

[PATCH v2 2/7] monitor/hmp: Make memory_dump() @is_physical argument a boolean

Philippe Mathieu-Daudé posted 7 patches 1 week, 1 day ago
Maintainers: "Dr. David Alan Gilbert" <dave@treblig.org>
[PATCH v2 2/7] monitor/hmp: Make memory_dump() @is_physical argument a boolean
Posted by Philippe Mathieu-Daudé 1 week, 1 day ago 
Suggested-by: Dr. David Alan Gilbert <dave@treblig.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 monitor/hmp-cmds-target.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
index 2976f986d35..51dcb9e314c 100644
--- a/monitor/hmp-cmds-target.c
+++ b/monitor/hmp-cmds-target.c
@@ -122,7 +122,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdict)
 }
 
 static void memory_dump(Monitor *mon, int count, int format, int wsize,
-                        hwaddr addr, int is_physical)
+                        hwaddr addr, bool is_physical)
 {
     int l, line_size, i, max_digits, len;
     uint8_t buf[16];
@@ -237,7 +237,7 @@ void hmp_memory_dump(Monitor *mon, const QDict *qdict)
     int size = qdict_get_int(qdict, "size");
     target_long addr = qdict_get_int(qdict, "addr");
 
-    memory_dump(mon, count, format, size, addr, 0);
+    memory_dump(mon, count, format, size, addr, false);
 }
 
 void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict)
@@ -247,7 +247,7 @@ void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict)
     int size = qdict_get_int(qdict, "size");
     hwaddr addr = qdict_get_int(qdict, "addr");
 
-    memory_dump(mon, count, format, size, addr, 1);
+    memory_dump(mon, count, format, size, addr, true);
 }
 
 void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
-- 
2.52.0
Re: [PATCH v2 2/7] monitor/hmp: Make memory_dump() @is_physical argument a boolean
Posted by Manos Pitsidianakis 1 week, 1 day ago 
On Tue, Dec 30, 2025 at 1:16 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> Suggested-by: Dr. David Alan Gilbert <dave@treblig.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

>  monitor/hmp-cmds-target.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
> index 2976f986d35..51dcb9e314c 100644
> --- a/monitor/hmp-cmds-target.c
> +++ b/monitor/hmp-cmds-target.c
> @@ -122,7 +122,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdict)
>  }
>
>  static void memory_dump(Monitor *mon, int count, int format, int wsize,
> -                        hwaddr addr, int is_physical)
> +                        hwaddr addr, bool is_physical)
>  {
>      int l, line_size, i, max_digits, len;
>      uint8_t buf[16];
> @@ -237,7 +237,7 @@ void hmp_memory_dump(Monitor *mon, const QDict *qdict)
>      int size = qdict_get_int(qdict, "size");
>      target_long addr = qdict_get_int(qdict, "addr");
>
> -    memory_dump(mon, count, format, size, addr, 0);
> +    memory_dump(mon, count, format, size, addr, false);
>  }
>
>  void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict)
> @@ -247,7 +247,7 @@ void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict)
>      int size = qdict_get_int(qdict, "size");
>      hwaddr addr = qdict_get_int(qdict, "addr");
>
> -    memory_dump(mon, count, format, size, addr, 1);
> +    memory_dump(mon, count, format, size, addr, true);
>  }
>
>  void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
> --
> 2.52.0
>
Re: [PATCH v2 2/7] monitor/hmp: Make memory_dump() @is_physical argument a boolean
Posted by Dr. David Alan Gilbert 1 week, 1 day ago 
* Philippe Mathieu-Daudé (philmd@linaro.org) wrote:
> Suggested-by: Dr. David Alan Gilbert <dave@treblig.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>

> ---
>  monitor/hmp-cmds-target.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
> index 2976f986d35..51dcb9e314c 100644
> --- a/monitor/hmp-cmds-target.c
> +++ b/monitor/hmp-cmds-target.c
> @@ -122,7 +122,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdict)
>  }
>  
>  static void memory_dump(Monitor *mon, int count, int format, int wsize,
> -                        hwaddr addr, int is_physical)
> +                        hwaddr addr, bool is_physical)
>  {
>      int l, line_size, i, max_digits, len;
>      uint8_t buf[16];
> @@ -237,7 +237,7 @@ void hmp_memory_dump(Monitor *mon, const QDict *qdict)
>      int size = qdict_get_int(qdict, "size");
>      target_long addr = qdict_get_int(qdict, "addr");
>  
> -    memory_dump(mon, count, format, size, addr, 0);
> +    memory_dump(mon, count, format, size, addr, false);
>  }
>  
>  void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict)
> @@ -247,7 +247,7 @@ void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict)
>      int size = qdict_get_int(qdict, "size");
>      hwaddr addr = qdict_get_int(qdict, "addr");
>  
> -    memory_dump(mon, count, format, size, addr, 1);
> +    memory_dump(mon, count, format, size, addr, true);
>  }
>  
>  void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
> -- 
> 2.52.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.