[PATCH 1/2] docs/interop/firmware: Rename FirmwareFormat to FirmwareFlashFormat

Andrea Bolognani posted 2 patches 1 week, 2 days ago
Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Kashyap Chamarthy <kchamart@redhat.com>
[PATCH 1/2] docs/interop/firmware: Rename FirmwareFormat to FirmwareFlashFormat
Posted by Andrea Bolognani 1 week, 2 days ago
We are about to introduce a new set of enums that will be used
by FirmwareMappingMemory and that don't overlap with the formats
that are supported for FirmwareMappingFlash, so we need to
disambiguate things.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 docs/interop/firmware.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
index da0362a2c0..ef9b976a34 100644
--- a/docs/interop/firmware.json
+++ b/docs/interop/firmware.json
@@ -233,7 +233,7 @@
              'verbose-dynamic', 'verbose-static' ] }
 
 ##
-# @FirmwareFormat:
+# @FirmwareFlashFormat:
 #
 # Formats that are supported for firmware images.
 #
@@ -243,7 +243,7 @@
 #
 # Since: 3.0
 ##
-{ 'enum': 'FirmwareFormat',
+{ 'enum': 'FirmwareFlashFormat',
   'data': [ 'raw', 'qcow2' ] }
 
 ##
@@ -265,7 +265,7 @@
 ##
 { 'struct' : 'FirmwareFlashFile',
   'data'   : { 'filename' : 'str',
-               'format'   : 'FirmwareFormat' } }
+               'format'   : 'FirmwareFlashFormat' } }
 
 
 ##
-- 
2.52.0
Re: [PATCH 1/2] docs/interop/firmware: Rename FirmwareFormat to FirmwareFlashFormat
Posted by Michal Prívozník 2 days ago
On 12/29/25 00:26, Andrea Bolognani wrote:
> We are about to introduce a new set of enums that will be used
> by FirmwareMappingMemory and that don't overlap with the formats
> that are supported for FirmwareMappingFlash, so we need to
> disambiguate things.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  docs/interop/firmware.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> index da0362a2c0..ef9b976a34 100644
> --- a/docs/interop/firmware.json
> +++ b/docs/interop/firmware.json
> @@ -233,7 +233,7 @@
>               'verbose-dynamic', 'verbose-static' ] }
>  
>  ##
> -# @FirmwareFormat:
> +# @FirmwareFlashFormat:
>  #
>  # Formats that are supported for firmware images.

Nitpick, ... "supported for flash firmware images" perhaps? Because
after this, the enum is specific to FirmwareFlashFile.

>  #
> @@ -243,7 +243,7 @@
>  #
>  # Since: 3.0
>  ##
> -{ 'enum': 'FirmwareFormat',
> +{ 'enum': 'FirmwareFlashFormat',
>    'data': [ 'raw', 'qcow2' ] }
>  
>  ##
> @@ -265,7 +265,7 @@
>  ##
>  { 'struct' : 'FirmwareFlashFile',
>    'data'   : { 'filename' : 'str',
> -               'format'   : 'FirmwareFormat' } }
> +               'format'   : 'FirmwareFlashFormat' } }
>  
>  
>  ##

Michal