tests: fix comment declaring runtime in rv64 interruptedmemory test

[PATCH] tests: fix comment declaring runtime in rv64 interruptedmemory test

Julian Ganz posted 1 patch 1 month, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251227085349.23808-1-neither@nut.email

Maintainers: Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>

tests/tcg/riscv64/interruptedmemory.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests: fix comment declaring runtime in rv64 interruptedmemory test

Posted by Julian Ganz 1 month, 1 week ago

The test attempts to trigger a regression for arount 30s. However, a
comment just before the computation of the target wall clock time falsly
declares the run time to be around 60s.

This was the case already when we introduced the test in

    5241645c47a9987f4fcc65bab303a444966b7942
    (tests: add test with interrupted memory accesses on rv64)

Signed-off-by: Julian Ganz <neither@nut.email>
---
 tests/tcg/riscv64/interruptedmemory.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/tcg/riscv64/interruptedmemory.S b/tests/tcg/riscv64/interruptedmemory.S
index cd9073ee31..c154f93839 100644
--- a/tests/tcg/riscv64/interruptedmemory.S
+++ b/tests/tcg/riscv64/interruptedmemory.S
@@ -25,7 +25,7 @@ _start:
 	li	a0, 0x03	# 8N1, DLAB=0
 	sb	a0, 3(t1)
 
-	# Run test for around 60s
+	# Run test for around 30s
 	call	rtc_get
 	li	t0, 30
 	slli	t0, t0, 30 # Approx. 10e9 ns
-- 
2.51.2

Re: [PATCH] tests: fix comment declaring runtime in rv64 interruptedmemory test

Posted by Daniel Henrique Barboza 1 month, 1 week ago


On 12/27/25 5:53 AM, Julian Ganz wrote:
> The test attempts to trigger a regression for arount 30s. However, a
> comment just before the computation of the target wall clock time falsly
> declares the run time to be around 60s.
> 
> This was the case already when we introduced the test in
> 
>      5241645c47a9987f4fcc65bab303a444966b7942
>      (tests: add test with interrupted memory accesses on rv64)
> 
> Signed-off-by: Julian Ganz <neither@nut.email>
> ---

Reviewed-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>

>   tests/tcg/riscv64/interruptedmemory.S | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/tcg/riscv64/interruptedmemory.S b/tests/tcg/riscv64/interruptedmemory.S
> index cd9073ee31..c154f93839 100644
> --- a/tests/tcg/riscv64/interruptedmemory.S
> +++ b/tests/tcg/riscv64/interruptedmemory.S
> @@ -25,7 +25,7 @@ _start:
>   	li	a0, 0x03	# 8N1, DLAB=0
>   	sb	a0, 3(t1)
>   
> -	# Run test for around 60s
> +	# Run test for around 30s
>   	call	rtc_get
>   	li	t0, 30
>   	slli	t0, t0, 30 # Approx. 10e9 ns