translator_ldl() is defined in "exec/translator.h" as:

  198 static inline uint32_t
  199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc)
  200 {
  201     return translator_ldl_end(env, db, pc, MO_TE);
  202 }

Directly use the inlined form, expanding MO_TE -> MO_BE
since PA-RISC use big-endian order.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hppa/translate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 853cba2ba4f..73c2cbdf5fc 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -4737,7 +4737,8 @@ static void hppa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
     {
         /* Always fetch the insn, even if nullified, so that we check
            the page permissions for execute.  */
-        uint32_t insn = translator_ldl(env, &ctx->base, ctx->base.pc_next);
+        uint32_t insn = translator_ldl_end(env, &ctx->base, ctx->base.pc_next,
+                                           MO_BE);
 
         /*
          * Set up the IA queue for the next insn.
-- 
2.52.0

On 12/25/25 03:09, Philippe Mathieu-Daudé wrote:
> translator_ldl() is defined in "exec/translator.h" as:
> 
>    198 static inline uint32_t
>    199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc)
>    200 {
>    201     return translator_ldl_end(env, db, pc, MO_TE);
>    202 }
> 
> Directly use the inlined form, expanding MO_TE -> MO_BE
> since PA-RISC use big-endian order.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/hppa/translate.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 853cba2ba4f..73c2cbdf5fc 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -4737,7 +4737,8 @@ static void hppa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
>       {
>           /* Always fetch the insn, even if nullified, so that we check
>              the page permissions for execute.  */
> -        uint32_t insn = translator_ldl(env, &ctx->base, ctx->base.pc_next);
> +        uint32_t insn = translator_ldl_end(env, &ctx->base, ctx->base.pc_next,
> +                                           MO_BE);
>   
>           /*
>            * Set up the IA queue for the next insn.

Use mo_endian(ctx), since you have it.

With that,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

On Wed, Dec 24, 2025 at 6:10 PM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> translator_ldl() is defined in "exec/translator.h" as:
>
>   198 static inline uint32_t
>   199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc)
>   200 {
>   201     return translator_ldl_end(env, db, pc, MO_TE);
>   202 }
>
> Directly use the inlined form, expanding MO_TE -> MO_BE
> since PA-RISC use big-endian order.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

>  target/hppa/translate.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 853cba2ba4f..73c2cbdf5fc 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -4737,7 +4737,8 @@ static void hppa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
>      {
>          /* Always fetch the insn, even if nullified, so that we check
>             the page permissions for execute.  */
> -        uint32_t insn = translator_ldl(env, &ctx->base, ctx->base.pc_next);
> +        uint32_t insn = translator_ldl_end(env, &ctx->base, ctx->base.pc_next,
> +                                           MO_BE);
>
>          /*
>           * Set up the IA queue for the next insn.
> --
> 2.52.0
>