[v1] target/alpha: Use explicit little-endian LD/ST API

[PATCH 4/6] target/alpha: Inline translator_ldl()

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

translator_ldl() is defined in "exec/translator.h" as:

  198 static inline uint32_t
  199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc)
  200 {
  201     return translator_ldl_end(env, db, pc, MO_TE);
  202 }

Directly use the inlined form, expanding MO_TE -> MO_LE
since Alpha use little-endian order.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/alpha/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index b1d8a4eb80a..48ac50a7cdf 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -2904,8 +2904,8 @@ static void alpha_tr_insn_start(DisasContextBase *dcbase, CPUState *cpu)
 static void alpha_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
 {
     DisasContext *ctx = container_of(dcbase, DisasContext, base);
-    uint32_t insn = translator_ldl(cpu_env(cpu), &ctx->base,
-                                   ctx->base.pc_next);
+    uint32_t insn = translator_ldl_end(cpu_env(cpu), &ctx->base,
+                                       ctx->base.pc_next, MO_LE);
 
     ctx->base.pc_next += 4;
     ctx->base.is_jmp = translate_one(ctx, insn);
-- 
2.52.0

Re: [PATCH 4/6] target/alpha: Inline translator_ldl()

Posted by Richard Henderson 1 month, 1 week ago

On 12/25/25 03:00, Philippe Mathieu-Daudé wrote:
> translator_ldl() is defined in "exec/translator.h" as:
> 
>    198 static inline uint32_t
>    199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc)
>    200 {
>    201     return translator_ldl_end(env, db, pc, MO_TE);
>    202 }
> 
> Directly use the inlined form, expanding MO_TE -> MO_LE
> since Alpha use little-endian order.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/alpha/translate.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/alpha/translate.c b/target/alpha/translate.c
> index b1d8a4eb80a..48ac50a7cdf 100644
> --- a/target/alpha/translate.c
> +++ b/target/alpha/translate.c
> @@ -2904,8 +2904,8 @@ static void alpha_tr_insn_start(DisasContextBase *dcbase, CPUState *cpu)
>   static void alpha_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
>   {
>       DisasContext *ctx = container_of(dcbase, DisasContext, base);
> -    uint32_t insn = translator_ldl(cpu_env(cpu), &ctx->base,
> -                                   ctx->base.pc_next);
> +    uint32_t insn = translator_ldl_end(cpu_env(cpu), &ctx->base,
> +                                       ctx->base.pc_next, MO_LE);
>   
>       ctx->base.pc_next += 4;
>       ctx->base.is_jmp = translate_one(ctx, insn);

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~