On Wed, Dec 24, 2025 at 5:25 PM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> None of these files use API declared in "qemu/bswap.h",
> remove the unnecessary inclusion.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> tests/qtest/pnv-xive2-common.h | 1 -
> tests/qtest/aspeed_smc-test.c | 1 -
> tests/qtest/ast2700-smc-test.c | 1 -
> tests/qtest/libqos/fw_cfg.c | 1 -
> tests/qtest/libqos/i2c-omap.c | 1 -
> tests/qtest/pnv-spi-seeprom-test.c | 1 -
> tests/qtest/vmcoreinfo-test.c | 1 -
> 7 files changed, 7 deletions(-)
>
> diff --git a/tests/qtest/pnv-xive2-common.h b/tests/qtest/pnv-xive2-common.h
> index 2077c05ebc7..3b842274243 100644
> --- a/tests/qtest/pnv-xive2-common.h
> +++ b/tests/qtest/pnv-xive2-common.h
> @@ -15,7 +15,6 @@
> #define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs))
> #define PPC_BITMASK32(bs, be) ((PPC_BIT32(bs) - PPC_BIT32(be)) | \
> PPC_BIT32(bs))
> -#include "qemu/bswap.h"
> #include "hw/intc/pnv_xive2_regs.h"
> #include "hw/ppc/xive_regs.h"
> #include "hw/ppc/xive2_regs.h"
> diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
> index 50a87e62500..39af1df0ed7 100644
> --- a/tests/qtest/aspeed_smc-test.c
> +++ b/tests/qtest/aspeed_smc-test.c
> @@ -24,7 +24,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/bswap.h"
> #include "libqtest-single.h"
> #include "qemu/bitops.h"
> #include "aspeed-smc-utils.h"
> diff --git a/tests/qtest/ast2700-smc-test.c b/tests/qtest/ast2700-smc-test.c
> index 62d538d8a3a..33fc47230ee 100644
> --- a/tests/qtest/ast2700-smc-test.c
> +++ b/tests/qtest/ast2700-smc-test.c
> @@ -7,7 +7,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/bswap.h"
> #include "libqtest-single.h"
> #include "qemu/bitops.h"
> #include "aspeed-smc-utils.h"
> diff --git a/tests/qtest/libqos/fw_cfg.c b/tests/qtest/libqos/fw_cfg.c
> index 0ab3959171b..8611f648c14 100644
> --- a/tests/qtest/libqos/fw_cfg.c
> +++ b/tests/qtest/libqos/fw_cfg.c
> @@ -17,7 +17,6 @@
> #include "malloc-pc.h"
> #include "libqos-malloc.h"
> #include "../libqtest.h"
> -#include "qemu/bswap.h"
> #include "hw/nvram/fw_cfg.h"
>
> void qfw_cfg_select(QFWCFG *fw_cfg, uint16_t key)
> diff --git a/tests/qtest/libqos/i2c-omap.c b/tests/qtest/libqos/i2c-omap.c
> index 6f98f54820b..71f70c64f85 100644
> --- a/tests/qtest/libqos/i2c-omap.c
> +++ b/tests/qtest/libqos/i2c-omap.c
> @@ -10,7 +10,6 @@
> #include "i2c.h"
>
>
> -#include "qemu/bswap.h"
> #include "../libqtest.h"
>
> enum OMAPI2CRegisters {
> diff --git a/tests/qtest/pnv-spi-seeprom-test.c b/tests/qtest/pnv-spi-seeprom-test.c
> index 8033261758b..44e0b92730b 100644
> --- a/tests/qtest/pnv-spi-seeprom-test.c
> +++ b/tests/qtest/pnv-spi-seeprom-test.c
> @@ -7,7 +7,6 @@
> */
> #include "qemu/osdep.h"
> #include "libqtest.h"
> -#include "qemu/bswap.h"
> #include "hw/ssi/pnv_spi_regs.h"
> #include "pnv-xscom.h"
>
> diff --git a/tests/qtest/vmcoreinfo-test.c b/tests/qtest/vmcoreinfo-test.c
> index dcf3b5ae058..0110dcceffa 100644
> --- a/tests/qtest/vmcoreinfo-test.c
> +++ b/tests/qtest/vmcoreinfo-test.c
> @@ -16,7 +16,6 @@
> #include "libqtest.h"
> #include "standard-headers/linux/qemu_fw_cfg.h"
> #include "libqos/fw_cfg.h"
> -#include "qemu/bswap.h"
> #include "hw/misc/vmcoreinfo.h"
>
> static void test_vmcoreinfo_write_basic(void)
> --
> 2.52.0
>