1. Patchew
  2. QEMU
  3. View series

[PATCH] tests/functional: Fix URL of gb200nvl-bmc image

Cédric Le Goater posted 1 patch 1 month, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251222073351.166720-1-clg@redhat.com
Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>
tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Cédric Le Goater 1 month, 2 weeks ago 
Commit [1] moved the FW image of the gb200nvl-bmc machine and broke
the associated functional test. Fix that.

[1] https://github.com/legoater/qemu-aspeed-boot/commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a

Cc: Ed Tanous <etanous@nvidia.com>
Cc: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
index 8e8e3f05c1b2..e5f2dce0f569 100755
--- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
+++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
@@ -11,7 +11,7 @@
 class GB200Machine(AspeedTest):
 
     ASSET_GB200_FLASH = Asset(
-        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
+        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
         'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')
 
     def test_arm_aspeed_gb200_openbmc(self):
-- 
2.52.0
Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago 
On 22/12/25 08:33, Cédric Le Goater wrote:
> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke
> the associated functional test. Fix that.
> 
> [1] https://github.com/legoater/qemu-aspeed-boot/commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a
> 
> Cc: Ed Tanous <etanous@nvidia.com>
> Cc: Patrick Williams <patrick@stwcx.xyz>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Cédric Le Goater 1 month, 2 weeks ago 
On 12/22/25 08:33, Cédric Le Goater wrote:
> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke
> the associated functional test. Fix that.
> 
> [1] https://github.com/legoater/qemu-aspeed-boot/commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a
> 
> Cc: Ed Tanous <etanous@nvidia.com>
> Cc: Patrick Williams <patrick@stwcx.xyz>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
> index 8e8e3f05c1b2..e5f2dce0f569 100755
> --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
> +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
> @@ -11,7 +11,7 @@
>   class GB200Machine(AspeedTest):
>   
>       ASSET_GB200_FLASH = Asset(
> -        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
> +        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
>           'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')
>   
>       def test_arm_aspeed_gb200_openbmc(self):

Applied to aspeed-next.

Thanks,

C.
Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago 
On 22/12/25 13:52, Cédric Le Goater wrote:
> On 12/22/25 08:33, Cédric Le Goater wrote:
>> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke
>> the associated functional test. Fix that.
>>
>> [1] https://github.com/legoater/qemu-aspeed-boot/ 
>> commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a
>>
>> Cc: Ed Tanous <etanous@nvidia.com>
>> Cc: Patrick Williams <patrick@stwcx.xyz>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>>   tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/ 
>> functional/arm/test_aspeed_gb200nvl_bmc.py
>> index 8e8e3f05c1b2..e5f2dce0f569 100755
>> --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
>> +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
>> @@ -11,7 +11,7 @@
>>   class GB200Machine(AspeedTest):
>>       ASSET_GB200_FLASH = Asset(
>> -        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ 
>> master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl- 
>> obmc-20250702182348.static.mtd.xz',
>> +        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ 
>> master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image- 
>> gb200nvl-obmc-20250702182348.static.mtd.xz',
>>           
>> 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')
>>       def test_arm_aspeed_gb200_openbmc(self):
> 
> Applied to aspeed-next.

Thanks, this is part of the 2 build failures blocking current pull
requests (other one being
https://lore.kernel.org/qemu-devel/20251224085714.83169-1-philmd@linaro.org/).

If we really want to consider our CI as source of truth (and blocking
when not green), then please consider applying it directly on master
as a build fix (maintainers Cc'ed).

Regards,

Phil.
Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Cédric Le Goater 1 month, 2 weeks ago 
On 12/24/25 11:51, Philippe Mathieu-Daudé wrote:
> On 22/12/25 13:52, Cédric Le Goater wrote:
>> On 12/22/25 08:33, Cédric Le Goater wrote:
>>> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke
>>> the associated functional test. Fix that.
>>>
>>> [1] https://github.com/legoater/qemu-aspeed-boot/ commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a
>>>
>>> Cc: Ed Tanous <etanous@nvidia.com>
>>> Cc: Patrick Williams <patrick@stwcx.xyz>
>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>> ---
>>>   tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/tests/ functional/arm/test_aspeed_gb200nvl_bmc.py
>>> index 8e8e3f05c1b2..e5f2dce0f569 100755
>>> --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
>>> +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
>>> @@ -11,7 +11,7 @@
>>>   class GB200Machine(AspeedTest):
>>>       ASSET_GB200_FLASH = Asset(
>>> -        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl- obmc-20250702182348.static.mtd.xz',
>>> +        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/ master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image- gb200nvl-obmc-20250702182348.static.mtd.xz',
>>> 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')
>>>       def test_arm_aspeed_gb200_openbmc(self):
>>
>> Applied to aspeed-next.
> 
> Thanks, this is part of the 2 build failures blocking current pull
> requests (other one being
> https://lore.kernel.org/qemu-devel/20251224085714.83169-1-philmd@linaro.org/).

Thanks, I was going to send an aspeed PR yesterday and then, I saw
the tests failing because of the missing v5.0.0 machines.

C.

> If we really want to consider our CI as source of truth (and blocking
> when not green), then please consider applying it directly on master
> as a build fix (maintainers Cc'ed).
Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Philippe Mathieu-Daudé 1 month, 1 week ago 
Hi,

On 24/12/25 12:27, Cédric Le Goater wrote:
> On 12/24/25 11:51, Philippe Mathieu-Daudé wrote:
>> On 22/12/25 13:52, Cédric Le Goater wrote:
>>> On 12/22/25 08:33, Cédric Le Goater wrote:
>>>> Commit [1] moved the FW image of the gb200nvl-bmc machine and broke
>>>> the associated functional test. Fix that.
>>>>
>>>> [1] https://github.com/legoater/qemu-aspeed-boot/ 
>>>> commit/52451b2472eeb40aa97e131aeea327e9d4a8a78a
>>>>
>>>> Cc: Ed Tanous <etanous@nvidia.com>
>>>> Cc: Patrick Williams <patrick@stwcx.xyz>
>>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>>> ---
>>>>   tests/functional/arm/test_aspeed_gb200nvl_bmc.py | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py b/ 
>>>> tests/ functional/arm/test_aspeed_gb200nvl_bmc.py
>>>> index 8e8e3f05c1b2..e5f2dce0f569 100755
>>>> --- a/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
>>>> +++ b/tests/functional/arm/test_aspeed_gb200nvl_bmc.py
>>>> @@ -11,7 +11,7 @@
>>>>   class GB200Machine(AspeedTest):
>>>>       ASSET_GB200_FLASH = Asset(
>>>> -        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/ 
>>>> heads/ master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl- 
>>>> obmc-20250702182348.static.mtd.xz',
>>>> +        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/ 
>>>> heads/ master/images/gb200nvl-bmc/openbmc-20250702182348/obmc- 
>>>> phosphor-image- gb200nvl-obmc-20250702182348.static.mtd.xz',
>>>> 'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')
>>>>       def test_arm_aspeed_gb200_openbmc(self):
>>>
>>> Applied to aspeed-next.
>>
>> Thanks, this is part of the 2 build failures blocking current pull
>> requests (other one being
>> https://lore.kernel.org/qemu-devel/20251224085714.83169-1- 
>> philmd@linaro.org/).
> 
> Thanks, I was going to send an aspeed PR yesterday and then, I saw
> the tests failing because of the missing v5.0.0 machines.
> 
> C.
> 
>> If we really want to consider our CI as source of truth (and blocking
>> when not green), then please consider applying it directly on master
>> as a build fix (maintainers Cc'ed).

One week passed, some PR got merged, I'm surprised the mainstream CI
isn't blocked by this issue... Ah, the cache is being hit:
https://gitlab.com/qemu-project/qemu/-/jobs/12556022118

2025-12-29 01:26:43,960 - qemu-test - DEBUG - Using cached asset 
/builds/qemu-project/qemu/functional-cache/download/b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc 
for 
https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz

=> Non reproducible builds. Acceptable?

OK I'm not going to hold my pull request any further and just post
it ignoring the build issue.

Regards,

Phil.
Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Patrick Williams 1 month, 2 weeks ago 
On Mon, Dec 22, 2025 at 01:52:19PM +0100, Cédric Le Goater wrote:
> On 12/22/25 08:33, Cédric Le Goater wrote:
> >       ASSET_GB200_FLASH = Asset(
> > -        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
> > +        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
> >           'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')

Should we make these commits or tags rather than `master`?  Right now it
seems only Catalina uses a permalink where as all the others appear to
use `master` references.

functional/arm/test_aspeed_catalina.py
14:        'https://github.com/legoater/qemu-aspeed-boot/raw/a866feb5ef81245b4827a214584bf6bcc72939f6/images/catalina-bmc/obmc-phosphor-image-catalina-20250619123021.static.mtd.xz',


-- 
Patrick Williams
Re: [PATCH] tests/functional: Fix URL of gb200nvl-bmc image
Posted by Cédric Le Goater 1 month, 2 weeks ago 
On 12/23/25 23:11, Patrick Williams wrote:
> On Mon, Dec 22, 2025 at 01:52:19PM +0100, Cédric Le Goater wrote:
>> On 12/22/25 08:33, Cédric Le Goater wrote:
>>>        ASSET_GB200_FLASH = Asset(
>>> -        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-obmc/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
>>> +        'https://github.com/legoater/qemu-aspeed-boot/raw/refs/heads/master/images/gb200nvl-bmc/openbmc-20250702182348/obmc-phosphor-image-gb200nvl-obmc-20250702182348.static.mtd.xz',
>>>            'b84819317cb3dc762895ad507705978ef000bfc77c50c33a63bdd37921db0dbc')
> 
> Should we make these commits or tags rather than `master`?  Right now it
> seems only Catalina uses a permalink where as all the others appear to
> use `master` references.


The main objective is to be able to add new images without breaking existing
tests. As long as there is some version number in the fw image file, I don't
think it matters much. I would opt for master.

Thanks,

C.


> 
> functional/arm/test_aspeed_catalina.py
> 14:        'https://github.com/legoater/qemu-aspeed-boot/raw/a866feb5ef81245b4827a214584bf6bcc72939f6/images/catalina-bmc/obmc-phosphor-image-catalina-20250619123021.static.mtd.xz',
> 
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.