meson: Optimize summary_info about directories

[PATCH] meson: Optimize summary_info about directories

Bin Guo posted 1 patch 1 month, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251219230456.37178-1-guobin@linux.alibaba.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

meson.build | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] meson: Optimize summary_info about directories

Posted by Bin Guo 1 month, 2 weeks ago

Clear summary_info first, otherwise there will be redundant output
about build environment.

Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index d9293294d8..73aa535d10 100644
--- a/meson.build
+++ b/meson.build
@@ -4634,6 +4634,7 @@ summary_info += {'Download dependencies': get_option('wrap_mode') != 'nodownload
 summary(summary_info, bool_yn: true, section: 'Build environment')
 
 # Directories
+summary_info = {}
 summary_info += {'Install prefix':    get_option('prefix')}
 summary_info += {'BIOS directory':    qemu_datadir}
 pathsep = host_os == 'windows' ? ';' : ':'
-- 
2.50.1 (Apple Git-155)

Re: [PATCH] meson: Optimize summary_info about directories

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

On 20/12/25 00:04, Bin Guo wrote:
> Clear summary_info first, otherwise there will be redundant output
> about build environment.
> 
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
> ---
>   meson.build | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] meson: Optimize summary_info about directories

Posted by Alex Bennée 1 month, 2 weeks ago

Bin Guo <guobin@linux.alibaba.com> writes:

> Clear summary_info first, otherwise there will be redundant output
> about build environment.
>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>

Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meson.build b/meson.build
> index d9293294d8..73aa535d10 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4634,6 +4634,7 @@ summary_info += {'Download dependencies': get_option('wrap_mode') != 'nodownload
>  summary(summary_info, bool_yn: true, section: 'Build environment')
>  
>  # Directories
> +summary_info = {}
>  summary_info += {'Install prefix':    get_option('prefix')}
>  summary_info += {'BIOS directory':    qemu_datadir}
>  pathsep = host_os == 'windows' ? ';' : ':'

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro