[PATCH] docs/devel: Remove stale comments related to iommufd dirty tracking

Zhenzhong Duan posted 1 patch 1 month, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251218065042.639777-1-zhenzhong.duan@intel.com
Maintainers: Yi Liu <yi.l.liu@intel.com>, Eric Auger <eric.auger@redhat.com>, Zhenzhong Duan <zhenzhong.duan@intel.com>
There is a newer version of this series
docs/devel/vfio-iommufd.rst | 12 ------------
1 file changed, 12 deletions(-)
[PATCH] docs/devel: Remove stale comments related to iommufd dirty tracking
Posted by Zhenzhong Duan 1 month, 3 weeks ago
IOMMUFD dirty tracking support had be merged, the stale comments could
be dropped.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
 docs/devel/vfio-iommufd.rst | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/docs/devel/vfio-iommufd.rst b/docs/devel/vfio-iommufd.rst
index 3d1c11f175..b37098e1b6 100644
--- a/docs/devel/vfio-iommufd.rst
+++ b/docs/devel/vfio-iommufd.rst
@@ -127,18 +127,6 @@ Supports x86, ARM and s390x currently.
 Caveats
 =======
 
-Dirty page sync
----------------
-
-Dirty page sync with iommufd backend is unsupported yet, live migration is
-disabled by default. But it can be force enabled like below, low efficient
-though.
-
-.. code-block:: bash
-
-    -object iommufd,id=iommufd0
-    -device vfio-pci,host=0000:02:00.0,iommufd=iommufd0,enable-migration=on
-
 P2P DMA
 -------
 
-- 
2.47.1
Re: [PATCH] docs/devel: Remove stale comments related to iommufd dirty tracking
Posted by Philippe Mathieu-Daudé 1 month, 3 weeks ago
On 18/12/25 07:50, Zhenzhong Duan wrote:
> IOMMUFD dirty tracking support had be merged

[in merge commit dd4bc5f1cfe?]

, the stale comments could
> be dropped.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
>   docs/devel/vfio-iommufd.rst | 12 ------------
>   1 file changed, 12 deletions(-)
> 
> diff --git a/docs/devel/vfio-iommufd.rst b/docs/devel/vfio-iommufd.rst
> index 3d1c11f175..b37098e1b6 100644
> --- a/docs/devel/vfio-iommufd.rst
> +++ b/docs/devel/vfio-iommufd.rst
> @@ -127,18 +127,6 @@ Supports x86, ARM and s390x currently.
>   Caveats
>   =======
>   
> -Dirty page sync
> ----------------
> -
> -Dirty page sync with iommufd backend is unsupported yet, live migration is
> -disabled by default. But it can be force enabled like below, low efficient
> -though.
> -
> -.. code-block:: bash
> -
> -    -object iommufd,id=iommufd0
> -    -device vfio-pci,host=0000:02:00.0,iommufd=iommufd0,enable-migration=on
> -
>   P2P DMA
>   -------
>
RE: [PATCH] docs/devel: Remove stale comments related to iommufd dirty tracking
Posted by Duan, Zhenzhong 1 month, 3 weeks ago

>-----Original Message-----
>From: Philippe Mathieu-Daudé <philmd@linaro.org>
>Subject: Re: [PATCH] docs/devel: Remove stale comments related to
>iommufd dirty tracking
>
>On 18/12/25 07:50, Zhenzhong Duan wrote:
>> IOMMUFD dirty tracking support had be merged
>
>[in merge commit dd4bc5f1cfe?]

Yes, or you want me to add [in merge commit dd4bc5f1cfe] to commit log?

Thanks
Zhenzhong

>
>, the stale comments could
>> be dropped.
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>> ---
>>   docs/devel/vfio-iommufd.rst | 12 ------------
>>   1 file changed, 12 deletions(-)
>>
>> diff --git a/docs/devel/vfio-iommufd.rst b/docs/devel/vfio-iommufd.rst
>> index 3d1c11f175..b37098e1b6 100644
>> --- a/docs/devel/vfio-iommufd.rst
>> +++ b/docs/devel/vfio-iommufd.rst
>> @@ -127,18 +127,6 @@ Supports x86, ARM and s390x currently.
>>   Caveats
>>   =======
>>
>> -Dirty page sync
>> ----------------
>> -
>> -Dirty page sync with iommufd backend is unsupported yet, live migration is
>> -disabled by default. But it can be force enabled like below, low efficient
>> -though.
>> -
>> -.. code-block:: bash
>> -
>> -    -object iommufd,id=iommufd0
>> -    -device
>vfio-pci,host=0000:02:00.0,iommufd=iommufd0,enable-migration=on
>> -
>>   P2P DMA
>>   -------
>>

Re: [PATCH] docs/devel: Remove stale comments related to iommufd dirty tracking
Posted by Philippe Mathieu-Daudé 1 month, 3 weeks ago
On 18/12/25 12:07, Duan, Zhenzhong wrote:
> 
> 
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Subject: Re: [PATCH] docs/devel: Remove stale comments related to
>> iommufd dirty tracking
>>
>> On 18/12/25 07:50, Zhenzhong Duan wrote:
>>> IOMMUFD dirty tracking support had be merged
>>
>> [in merge commit dd4bc5f1cfe?]
> 
> Yes, or you want me to add [in merge commit dd4bc5f1cfe] to commit log?

Maybe Cédric can directly add that when taking the patch ;)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks,

Phil.

Re: [PATCH] docs/devel: Remove stale comments related to iommufd dirty tracking
Posted by Cédric Le Goater 1 month, 3 weeks ago
On 12/18/25 12:23, Philippe Mathieu-Daudé wrote:
> On 18/12/25 12:07, Duan, Zhenzhong wrote:
>>
>>
>>> -----Original Message-----
>>> From: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Subject: Re: [PATCH] docs/devel: Remove stale comments related to
>>> iommufd dirty tracking
>>>
>>> On 18/12/25 07:50, Zhenzhong Duan wrote:
>>>> IOMMUFD dirty tracking support had be merged
>>>
>>> [in merge commit dd4bc5f1cfe?]
>>
>> Yes, or you want me to add [in merge commit dd4bc5f1cfe] to commit log?
> 
> Maybe Cédric can directly add that when taking the patch ;)

I'd prefer a v2 please.

Thanks,

C.