[PATCH v3 0/7] hw/ppc: Snapshot support for several ppc devices

Caleb Schlossin posted 7 patches 1 month, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251216151359.418708-1-calebs@linux.ibm.com
Maintainers: Nicholas Piggin <npiggin@gmail.com>, Aditya Gupta <adityag@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Alistair Francis <alistair@alistair23.me>
There is a newer version of this series
hw/ppc/pnv_adu.c             | 12 +++++++++++
hw/ppc/pnv_chiptod.c         | 38 +++++++++++++++++++++++++++++++++
hw/ppc/pnv_core.c            | 22 +++++++++++++++++++
hw/ppc/pnv_i2c.c             | 11 ++++++++++
hw/ppc/pnv_lpc.c             | 41 ++++++++++++++++++++++++++++++++++++
hw/ppc/pnv_psi.c             | 36 +++++++++++++++++++++++++++++--
hw/ssi/pnv_spi.c             | 27 ++++++++++++++++++++++++
include/hw/ppc/pnv_chiptod.h |  2 ++
8 files changed, 187 insertions(+), 2 deletions(-)
[PATCH v3 0/7] hw/ppc: Snapshot support for several ppc devices
Posted by Caleb Schlossin 1 month, 3 weeks ago
Addressing comments from V2 review:

Updates in V3:
- pnv_psi: Remove PSI_DEBUG section as it was not used
- pnv_psi: Add missing post_load and vmstate info

Updates in V2:
- Added new patch set for PnvPsi support as it fits with the rest
- Added vmstate support for Power8 and Power9 for LPC
- Fixed pnv_core.c commit message

Tested:
passed make check

Thanks,
Caleb

Michael Kowal (2):
  hw/ppc: Add VMSTATE information for LPC model
  hw/ppc: Add VMSTATE information to PnvPsi

Caleb Schlossin (2):
  hw/ppc: Add pnv_spi vmstate support
  hw/ppc: Add pnv_i2c vmstate support

Angelo Jaramillo (3):
  hw/ppc: pnv_adu.c added vmstate support
  hw/ppc: pnv_core.c add vmstate support
  hw/ppc: pnv_chiptod.c add vmstate support

 hw/ppc/pnv_adu.c             | 12 +++++++++++
 hw/ppc/pnv_chiptod.c         | 38 +++++++++++++++++++++++++++++++++
 hw/ppc/pnv_core.c            | 22 +++++++++++++++++++
 hw/ppc/pnv_i2c.c             | 11 ++++++++++
 hw/ppc/pnv_lpc.c             | 41 ++++++++++++++++++++++++++++++++++++
 hw/ppc/pnv_psi.c             | 36 +++++++++++++++++++++++++++++--
 hw/ssi/pnv_spi.c             | 27 ++++++++++++++++++++++++
 include/hw/ppc/pnv_chiptod.h |  2 ++
 8 files changed, 187 insertions(+), 2 deletions(-)

-- 
2.47.3
Re: [PATCH v3 0/7] hw/ppc: Snapshot support for several ppc devices
Posted by Chalapathi V 1 month, 2 weeks ago
For the series:
Reviewed-by: Chalapathi V <chalapathi.v@linux.ibm.com>

<mailto:milesg@linux.ibm.com>Thank You,

Chalapathi


On 16/12/25 8:43 pm, Caleb Schlossin wrote:
> Addressing comments from V2 review:
>
> Updates in V3:
> - pnv_psi: Remove PSI_DEBUG section as it was not used
> - pnv_psi: Add missing post_load and vmstate info
>
> Updates in V2:
> - Added new patch set for PnvPsi support as it fits with the rest
> - Added vmstate support for Power8 and Power9 for LPC
> - Fixed pnv_core.c commit message
>
> Tested:
> passed make check
>
> Thanks,
> Caleb
>
> Michael Kowal (2):
>    hw/ppc: Add VMSTATE information for LPC model
>    hw/ppc: Add VMSTATE information to PnvPsi
>
> Caleb Schlossin (2):
>    hw/ppc: Add pnv_spi vmstate support
>    hw/ppc: Add pnv_i2c vmstate support
>
> Angelo Jaramillo (3):
>    hw/ppc: pnv_adu.c added vmstate support
>    hw/ppc: pnv_core.c add vmstate support
>    hw/ppc: pnv_chiptod.c add vmstate support
>
>   hw/ppc/pnv_adu.c             | 12 +++++++++++
>   hw/ppc/pnv_chiptod.c         | 38 +++++++++++++++++++++++++++++++++
>   hw/ppc/pnv_core.c            | 22 +++++++++++++++++++
>   hw/ppc/pnv_i2c.c             | 11 ++++++++++
>   hw/ppc/pnv_lpc.c             | 41 ++++++++++++++++++++++++++++++++++++
>   hw/ppc/pnv_psi.c             | 36 +++++++++++++++++++++++++++++--
>   hw/ssi/pnv_spi.c             | 27 ++++++++++++++++++++++++
>   include/hw/ppc/pnv_chiptod.h |  2 ++
>   8 files changed, 187 insertions(+), 2 deletions(-)
>
Re: [PATCH v3 0/7] hw/ppc: Snapshot support for several ppc devices
Posted by Harsh Prateek Bora 1 month ago
Hi Caleb,

Thanks for addressing the review comments.
I am seeing a git am failure on top of upstream commit 159107e390609f.
Could you please take a look, rebase and resend?

% git am 
patches/v3_20251216_calebs_hw_ppc_snapshot_support_for_several_ppc_devices.mbx
Applying: hw/ppc: Add VMSTATE information for LPC model
Applying: hw/ppc: Add pnv_spi vmstate support
error: patch failed: hw/ssi/pnv_spi.c:13
error: hw/ssi/pnv_spi.c: patch does not apply
Patch failed at 0002 hw/ppc: Add pnv_spi vmstate support
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am 
--abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Thanks
Harsh

On 22/12/25 4:31 pm, Chalapathi V wrote:
> For the series: Reviewed-by: Chalapathi V <chalapathi. v@ linux. ibm.  
> com> Thank You, Chalapathi On 16/12/25 8: 43 pm, Caleb Schlossin wrote: 
> Addressing comments from V2 review: Updates in V3: - pnv_psi: Remove 
> PSI_DEBUG section as it was not
> 
> 
> For the series:
> Reviewed-by: Chalapathi V <chalapathi.v@linux.ibm.com>
> 
> <mailto:milesg@linux.ibm.com>Thank You,
> 
> Chalapathi
> 
> 
> On 16/12/25 8:43 pm, Caleb Schlossin wrote:
>> Addressing comments from V2 review:
>>
>> Updates in V3:
>> - pnv_psi: Remove PSI_DEBUG section as it was not used
>> - pnv_psi: Add missing post_load and vmstate info
>>
>> Updates in V2:
>> - Added new patch set for PnvPsi support as it fits with the rest
>> - Added vmstate support for Power8 and Power9 for LPC
>> - Fixed pnv_core.c commit message
>>
>> Tested:
>> passed make check
>>
>> Thanks,
>> Caleb
>>
>> Michael Kowal (2):
>>    hw/ppc: Add VMSTATE information for LPC model
>>    hw/ppc: Add VMSTATE information to PnvPsi
>>
>> Caleb Schlossin (2):
>>    hw/ppc: Add pnv_spi vmstate support
>>    hw/ppc: Add pnv_i2c vmstate support
>>
>> Angelo Jaramillo (3):
>>    hw/ppc: pnv_adu.c added vmstate support
>>    hw/ppc: pnv_core.c add vmstate support
>>    hw/ppc: pnv_chiptod.c add vmstate support
>>
>>   hw/ppc/pnv_adu.c             | 12 +++++++++++
>>   hw/ppc/pnv_chiptod.c         | 38 +++++++++++++++++++++++++++++++++
>>   hw/ppc/pnv_core.c            | 22 +++++++++++++++++++
>>   hw/ppc/pnv_i2c.c             | 11 ++++++++++
>>   hw/ppc/pnv_lpc.c             | 41 ++++++++++++++++++++++++++++++++++++
>>   hw/ppc/pnv_psi.c             | 36 +++++++++++++++++++++++++++++--
>>   hw/ssi/pnv_spi.c             | 27 ++++++++++++++++++++++++
>>   include/hw/ppc/pnv_chiptod.h |  2 ++
>>   8 files changed, 187 insertions(+), 2 deletions(-)
>>
Re: [PATCH v3 0/7] hw/ppc: Snapshot support for several ppc devices
Posted by Caleb Schlossin 1 month ago

On 1/5/26 3:21 AM, Harsh Prateek Bora wrote:
> Hi Caleb,
> 
> Thanks for addressing the review comments.
> I am seeing a git am failure on top of upstream commit 159107e390609f.
> Could you please take a look, rebase and resend?
> 
> % git am patches/v3_20251216_calebs_hw_ppc_snapshot_support_for_several_ppc_devices.mbx
> Applying: hw/ppc: Add VMSTATE information for LPC model
> Applying: hw/ppc: Add pnv_spi vmstate support
> error: patch failed: hw/ssi/pnv_spi.c:13
> error: hw/ssi/pnv_spi.c: patch does not apply
> Patch failed at 0002 hw/ppc: Add pnv_spi vmstate support
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config set advice.mergeConflict false"
> 
> Thanks
> Harsh

Thanks for letting me know. Will rebase and fix as part of v4 patch set.

Thanks,
Caleb

> 
> On 22/12/25 4:31 pm, Chalapathi V wrote:
>> For the series: Reviewed-by: Chalapathi V <chalapathi. v@ linux. ibm.  com> Thank You, Chalapathi On 16/12/25 8: 43 pm, Caleb Schlossin wrote: Addressing comments from V2 review: Updates in V3: - pnv_psi: Remove PSI_DEBUG section as it was not
>> 
>>
>> For the series:
>> Reviewed-by: Chalapathi V <chalapathi.v@linux.ibm.com>
>>
>> <mailto:milesg@linux.ibm.com>Thank You,
>>
>> Chalapathi
>>
>>
>> On 16/12/25 8:43 pm, Caleb Schlossin wrote:
>>> Addressing comments from V2 review:
>>>
>>> Updates in V3:
>>> - pnv_psi: Remove PSI_DEBUG section as it was not used
>>> - pnv_psi: Add missing post_load and vmstate info
>>>
>>> Updates in V2:
>>> - Added new patch set for PnvPsi support as it fits with the rest
>>> - Added vmstate support for Power8 and Power9 for LPC
>>> - Fixed pnv_core.c commit message
>>>
>>> Tested:
>>> passed make check
>>>
>>> Thanks,
>>> Caleb
>>>
>>> Michael Kowal (2):
>>>    hw/ppc: Add VMSTATE information for LPC model
>>>    hw/ppc: Add VMSTATE information to PnvPsi
>>>
>>> Caleb Schlossin (2):
>>>    hw/ppc: Add pnv_spi vmstate support
>>>    hw/ppc: Add pnv_i2c vmstate support
>>>
>>> Angelo Jaramillo (3):
>>>    hw/ppc: pnv_adu.c added vmstate support
>>>    hw/ppc: pnv_core.c add vmstate support
>>>    hw/ppc: pnv_chiptod.c add vmstate support
>>>
>>>   hw/ppc/pnv_adu.c             | 12 +++++++++++
>>>   hw/ppc/pnv_chiptod.c         | 38 +++++++++++++++++++++++++++++++++
>>>   hw/ppc/pnv_core.c            | 22 +++++++++++++++++++
>>>   hw/ppc/pnv_i2c.c             | 11 ++++++++++
>>>   hw/ppc/pnv_lpc.c             | 41 ++++++++++++++++++++++++++++++++++++
>>>   hw/ppc/pnv_psi.c             | 36 +++++++++++++++++++++++++++++--
>>>   hw/ssi/pnv_spi.c             | 27 ++++++++++++++++++++++++
>>>   include/hw/ppc/pnv_chiptod.h |  2 ++
>>>   8 files changed, 187 insertions(+), 2 deletions(-)
>>>
> 
Re: [PATCH v3 0/7] hw/ppc: Snapshot support for several ppc devices
Posted by Aditya Gupta 1 month, 3 weeks ago
On 25/12/16 09:13AM, Caleb Schlossin wrote:
> Addressing comments from V2 review:
> 
> Updates in V3:
> - pnv_psi: Remove PSI_DEBUG section as it was not used
> - pnv_psi: Add missing post_load and vmstate info

Looks good to me now. Thanks for introducing this functionality in pnv
devices.

For the series:
Reviewed-by: Aditya Gupta <adityag@linux.ibm.com>

Thanks,
- Aditya G

> 
> Updates in V2:
> - Added new patch set for PnvPsi support as it fits with the rest
> - Added vmstate support for Power8 and Power9 for LPC
> - Fixed pnv_core.c commit message
> 
> Tested:
> passed make check
> 
> Thanks,
> Caleb
> 
> Michael Kowal (2):
>   hw/ppc: Add VMSTATE information for LPC model
>   hw/ppc: Add VMSTATE information to PnvPsi
> 
> Caleb Schlossin (2):
>   hw/ppc: Add pnv_spi vmstate support
>   hw/ppc: Add pnv_i2c vmstate support
> 
> Angelo Jaramillo (3):
>   hw/ppc: pnv_adu.c added vmstate support
>   hw/ppc: pnv_core.c add vmstate support
>   hw/ppc: pnv_chiptod.c add vmstate support
> 
>  hw/ppc/pnv_adu.c             | 12 +++++++++++
>  hw/ppc/pnv_chiptod.c         | 38 +++++++++++++++++++++++++++++++++
>  hw/ppc/pnv_core.c            | 22 +++++++++++++++++++
>  hw/ppc/pnv_i2c.c             | 11 ++++++++++
>  hw/ppc/pnv_lpc.c             | 41 ++++++++++++++++++++++++++++++++++++
>  hw/ppc/pnv_psi.c             | 36 +++++++++++++++++++++++++++++--
>  hw/ssi/pnv_spi.c             | 27 ++++++++++++++++++++++++
>  include/hw/ppc/pnv_chiptod.h |  2 ++
>  8 files changed, 187 insertions(+), 2 deletions(-)
> 
> -- 
> 2.47.3
>