scripts/nsis.py: Tell makensis that WoA is 64 bit

[PATCH-for-10.2] scripts/nsis.py: Tell makensis that WoA is 64 bit

Stefan Weil via posted 1 patch 4 days, 2 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251209130212.764443-1-sw@weilnetz.de

Maintainers: John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Stefan Weil <sw@weilnetz.de>

scripts/nsis.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH-for-10.2] scripts/nsis.py: Tell makensis that WoA is 64 bit

Posted by Stefan Weil via 4 days, 2 hours ago

This fixes some settings like the default installation path
for the QEMU installation on Windows on ARM (WoA).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 scripts/nsis.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/nsis.py b/scripts/nsis.py
index 8f469634eb..33069f4a86 100644
--- a/scripts/nsis.py
+++ b/scripts/nsis.py
@@ -114,7 +114,7 @@ def main():
             "-DSRCDIR=" + args.srcdir,
             "-DBINDIR=" + destdir + prefix,
         ]
-        if args.cpu == "x86_64":
+        if args.cpu == "aarch64" or args.cpu == "x86_64":
             makensis += ["-DW64"]
         makensis += ["-DDLLDIR=" + dlldir]
 
-- 
2.47.3

Re: [PATCH-for-10.2] scripts/nsis.py: Tell makensis that WoA is 64 bit

Posted by Michael Tokarev 3 days, 5 hours ago

On 12/9/25 16:02, Stefan Weil via wrote:
> This fixes some settings like the default installation path
> for the QEMU installation on Windows on ARM (WoA).

I'm picking this up for qemu-stable.  Please let me know
if I shouldn't.

Thanks,

/mjt

> --- a/scripts/nsis.py
> +++ b/scripts/nsis.py
> @@ -114,7 +114,7 @@ def main():
>               "-DSRCDIR=" + args.srcdir,
>               "-DBINDIR=" + destdir + prefix,
>           ]
> -        if args.cpu == "x86_64":
> +        if args.cpu == "aarch64" or args.cpu == "x86_64":
>               makensis += ["-DW64"]
>           makensis += ["-DDLLDIR=" + dlldir]
>

Re: [PATCH-for-10.2] scripts/nsis.py: Tell makensis that WoA is 64 bit

Posted by Philippe Mathieu-Daudé 4 days, 1 hour ago

On 9/12/25 14:02, Stefan Weil via wrote:
> This fixes some settings like the default installation path
> for the QEMU installation on Windows on ARM (WoA).
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>   scripts/nsis.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/nsis.py b/scripts/nsis.py
> index 8f469634eb..33069f4a86 100644
> --- a/scripts/nsis.py
> +++ b/scripts/nsis.py
> @@ -114,7 +114,7 @@ def main():
>               "-DSRCDIR=" + args.srcdir,
>               "-DBINDIR=" + destdir + prefix,
>           ]
> -        if args.cpu == "x86_64":
> +        if args.cpu == "aarch64" or args.cpu == "x86_64":
>               makensis += ["-DW64"]
>           makensis += ["-DDLLDIR=" + dlldir]
>   

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>