migration/options: Add x-ignore-shared

[PATCH] migration/options: Add x-ignore-shared

Posted by Peter Xu 1 week, 1 day ago

This aids scriptings only.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/options.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/options.c b/migration/options.c
index e78324b80c..30bf9afaf0 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -203,6 +203,7 @@ const Property migration_properties[] = {
                         MIGRATION_CAPABILITY_SWITCHOVER_ACK),
     DEFINE_PROP_MIG_CAP("x-dirty-limit", MIGRATION_CAPABILITY_DIRTY_LIMIT),
     DEFINE_PROP_MIG_CAP("mapped-ram", MIGRATION_CAPABILITY_MAPPED_RAM),
+    DEFINE_PROP_MIG_CAP("x-ignore-share", MIGRATION_CAPABILITY_X_IGNORE_SHARED),
 };
 const size_t migration_properties_count = ARRAY_SIZE(migration_properties);
 
-- 
2.50.1

Re: [PATCH] migration/options: Add x-ignore-shared

Posted by Fabiano Rosas 5 days, 10 hours ago

Peter Xu <peterx@redhat.com> writes:

> This aids scriptings only.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  migration/options.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/migration/options.c b/migration/options.c
> index e78324b80c..30bf9afaf0 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -203,6 +203,7 @@ const Property migration_properties[] = {
>                          MIGRATION_CAPABILITY_SWITCHOVER_ACK),
>      DEFINE_PROP_MIG_CAP("x-dirty-limit", MIGRATION_CAPABILITY_DIRTY_LIMIT),
>      DEFINE_PROP_MIG_CAP("mapped-ram", MIGRATION_CAPABILITY_MAPPED_RAM),
> +    DEFINE_PROP_MIG_CAP("x-ignore-share", MIGRATION_CAPABILITY_X_IGNORE_SHARED),
>  };
>  const size_t migration_properties_count = ARRAY_SIZE(migration_properties);

Reviewed-by: Fabiano Rosas <farosas@suse.de>

Re: [PATCH] migration/options: Add x-ignore-shared

Posted by Claudio Fontana 5 days, 10 hours ago

On 12/8/25 16:41, Fabiano Rosas wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
>> This aids scriptings only.
>>
>> Signed-off-by: Peter Xu <peterx@redhat.com>
>> ---
>>  migration/options.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/migration/options.c b/migration/options.c
>> index e78324b80c..30bf9afaf0 100644
>> --- a/migration/options.c
>> +++ b/migration/options.c
>> @@ -203,6 +203,7 @@ const Property migration_properties[] = {
>>                          MIGRATION_CAPABILITY_SWITCHOVER_ACK),
>>      DEFINE_PROP_MIG_CAP("x-dirty-limit", MIGRATION_CAPABILITY_DIRTY_LIMIT),
>>      DEFINE_PROP_MIG_CAP("mapped-ram", MIGRATION_CAPABILITY_MAPPED_RAM),
>> +    DEFINE_PROP_MIG_CAP("x-ignore-share", MIGRATION_CAPABILITY_X_IGNORE_SHARED),
>>  };
>>  const size_t migration_properties_count = ARRAY_SIZE(migration_properties);
> 
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> 

Nit: x-ignore-shared or x-ignore-share ? Commit msg and code seem to disagree.

Ciao,

C

Re: [PATCH] migration/options: Add x-ignore-shared

Posted by Peter Xu 5 days, 9 hours ago

On Mon, Dec 08, 2025 at 04:44:25PM +0100, Claudio Fontana wrote:
> On 12/8/25 16:41, Fabiano Rosas wrote:
> > Peter Xu <peterx@redhat.com> writes:
> > 
> >> This aids scriptings only.
> >>
> >> Signed-off-by: Peter Xu <peterx@redhat.com>
> >> ---
> >>  migration/options.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/migration/options.c b/migration/options.c
> >> index e78324b80c..30bf9afaf0 100644
> >> --- a/migration/options.c
> >> +++ b/migration/options.c
> >> @@ -203,6 +203,7 @@ const Property migration_properties[] = {
> >>                          MIGRATION_CAPABILITY_SWITCHOVER_ACK),
> >>      DEFINE_PROP_MIG_CAP("x-dirty-limit", MIGRATION_CAPABILITY_DIRTY_LIMIT),
> >>      DEFINE_PROP_MIG_CAP("mapped-ram", MIGRATION_CAPABILITY_MAPPED_RAM),
> >> +    DEFINE_PROP_MIG_CAP("x-ignore-share", MIGRATION_CAPABILITY_X_IGNORE_SHARED),
> >>  };
> >>  const size_t migration_properties_count = ARRAY_SIZE(migration_properties);
> > 
> > Reviewed-by: Fabiano Rosas <farosas@suse.de>
> > 
> 
> Nit: x-ignore-shared or x-ignore-share ? Commit msg and code seem to disagree.

Ah true.. I'll fix it while queuing it, thanks.

-- 
Peter Xu