[PATCH 1/5] hw: add missing includes hidden by block/aio.h

Paolo Bonzini posted 5 patches 1 week, 3 days ago
Maintainers: John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, Aarushi Mehta <mehta.aaru20@gmail.com>, Julia Suvorova <jusual@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Stefan Weil <sw@weilnetz.de>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Greg Kurz <groug@kaod.org>, Phil Dennis-Jordan <phil@philjordan.eu>, "Michael S. Tsirkin" <mst@redhat.com>, Eric Blake <eblake@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Alberto Garcia <berto@igalia.com>, "Alex Bennée" <alex.bennee@linaro.org>, Zhang Chen <zhangckid@gmail.com>, Li Zhijian <lizhijian@fujitsu.com>, Jason Wang <jasowang@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Coiby Xu <Coiby.Xu@gmail.com>
[PATCH 1/5] hw: add missing includes hidden by block/aio.h
Posted by Paolo Bonzini 1 week, 3 days ago
hw/qdev/core.h being included by core headers means that it was quite
easy to forget including it, or anything that hw/qdev/core.h included.
Add the missing inclusions.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 include/hw/char/serial.h        | 1 +
 hw/virtio/iothread-vq-mapping.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h
index b804e225886..ea82ffac476 100644
--- a/include/hw/char/serial.h
+++ b/include/hw/char/serial.h
@@ -26,6 +26,7 @@
 #ifndef HW_SERIAL_H
 #define HW_SERIAL_H
 
+#include "hw/core/qdev.h"
 #include "chardev/char-fe.h"
 #include "system/memory.h"
 #include "qemu/fifo8.h"
diff --git a/hw/virtio/iothread-vq-mapping.c b/hw/virtio/iothread-vq-mapping.c
index 15909eb9332..55ce62986c7 100644
--- a/hw/virtio/iothread-vq-mapping.c
+++ b/hw/virtio/iothread-vq-mapping.c
@@ -8,6 +8,7 @@
 
 #include "qemu/osdep.h"
 #include "system/iothread.h"
+#include "qemu/bitmap.h"
 #include "hw/virtio/iothread-vq-mapping.h"
 
 static bool
-- 
2.52.0
Re: [PATCH 1/5] hw: add missing includes hidden by block/aio.h
Posted by Philippe Mathieu-Daudé 1 week, 2 days ago
On 3/12/25 19:51, Paolo Bonzini wrote:
> hw/qdev/core.h being included by core headers means that it was quite
> easy to forget including it, or anything that hw/qdev/core.h included.
> Add the missing inclusions.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   include/hw/char/serial.h        | 1 +
>   hw/virtio/iothread-vq-mapping.c | 1 +
>   2 files changed, 2 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>