On Thu, Nov 27, 2025 at 08:33:47PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all. The main thing I wanted to do is to enable timestamps
> for errer_report() and friends when QMP monitor is active.
> Analyzing logs without timestamps is painful.
>
> And some enhancements here and there around.
This is significantly overlapping with what I've been working on here:
https://lists.nongnu.org/archive/html/qemu-devel/2025-09/msg05222.html
I had to pause that temporarily but intend to post a v5 for 11.0 dev
cycle
>
> Vladimir Sementsov-Ogievskiy (5):
> ui/vnc: don't use of error_printf_unless_qmp()
> monitor: remove unused error_printf_unless_qmp() function
> monitor: rework monitor_cur_is_qmp() into monitor_cur_is_hmp()
> error: print error_report timestamp when QMP monitor is active
> error-report: fix doc for vreport()
>
> include/monitor/monitor.h | 5 +----
> monitor/monitor.c | 30 +++---------------------------
> stubs/error-printf.c | 5 -----
> stubs/monitor-core.c | 5 +++++
> tests/unit/test-util-sockets.c | 1 +
> ui/vnc.c | 9 ++++-----
> util/error-report.c | 25 +++++++++++++++----------
> 7 files changed, 29 insertions(+), 51 deletions(-)
>
> --
> 2.48.1
>
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|