Device 'nand' was dropped in commit commit e86c1f967a3.

Device 'vfio-amd-xgbe' was dropped in commit aeb1a50d4a7.

Device 'vfio-calxeda-xgmac' was dropped in commit 8ebc416ac17.

The last error messages matching r"images* must be given with the
'pflash' parameter" was dropped in commit a2ccff4d2bc.

The error message matching r"Option '-device [\w.,-]+' cannot be
handled by this machine" was dropped in commit commit db78a605599.

As far as I can tell, we never had message matching r"Ignoring
smp_cpus value" or r"MSI-X support is mandatory in the S390
architecture".

The error message matching r"rom check and register reset failed" was
lost in merge commit af3f37319cb.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/device-crash-test | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index c1576e8b96..4b5bae701b 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -93,7 +93,6 @@ ERROR_RULE_LIST = [
     {'device':'ivshmem-doorbell', 'expected':True},        # You must specify a 'chardev'
     {'device':'ivshmem-plain', 'expected':True},           # You must specify a 'memdev'
     {'device':'loader', 'expected':True},                  # please include valid arguments
-    {'device':'nand', 'expected':True},                    # Unsupported NAND block size 0x1
     {'device':'nvdimm', 'expected':True},                  # 'memdev' property is not set
     {'device':'nvme', 'expected':True},                    # Device initialization failed
     {'device':'pc-dimm', 'expected':True},                 # 'memdev' property is not set
@@ -114,8 +113,6 @@ ERROR_RULE_LIST = [
     {'device':'usb-redir', 'expected':True},               # Parameter 'chardev' is missing
     {'device':'usb-serial', 'expected':True},              # Property chardev is required
     {'device':'usb-storage', 'expected':True},             # drive property not set
-    {'device':'vfio-amd-xgbe', 'expected':True},           # -device vfio-amd-xgbe: vfio error: wrong host device name
-    {'device':'vfio-calxeda-xgmac', 'expected':True},      # -device vfio-calxeda-xgmac: vfio error: wrong host device name
     {'device':'vfio-pci', 'expected':True},                # No provided host device
     {'device':'vfio-pci-igd-lpc-bridge', 'expected':True}, # VFIO dummy ISA/LPC bridge must have address 1f.0
     {'device':'vhost-scsi.*', 'expected':True},            # vhost-scsi: missing wwpn
@@ -159,7 +156,6 @@ ERROR_RULE_LIST = [
     # Silence INFO messages for errors that are common on multiple
     # devices/machines:
     {'log':r"No '[\w-]+' bus found for device '[\w-]+'"},
-    {'log':r"images* must be given with the 'pflash' parameter"},
     {'log':r"(Guest|ROM|Flash|Kernel) image must be specified"},
     {'log':r"[cC]ould not load [\w ]+ (BIOS|bios) '[\w-]+\.bin'"},
     {'log':r"Couldn't find rom image '[\w-]+\.bin'"},
@@ -167,7 +163,6 @@ ERROR_RULE_LIST = [
     {'log':r"Can't create a second ISA bus"},
     {'log':r"duplicate fw_cfg file name"},
     # sysbus-related error messages: most machines reject most dynamic sysbus devices:
-    {'log':r"Option '-device [\w.,-]+' cannot be handled by this machine"},
     {'log':r"Device [\w.,-]+ is not supported by this machine yet"},
     {'log':r"Device [\w.,-]+ can not be dynamically instantiated"},
     {'log':r"Platform Bus: Can not fit MMIO region of size "},
@@ -175,11 +170,8 @@ ERROR_RULE_LIST = [
     {'device':'.*-spapr-cpu-core', 'log':r"CPU core type should be"},
     {'log':r"MSI(-X)? is not supported by interrupt controller"},
     {'log':r"pxb-pcie? devices cannot reside on a PCIe? bus"},
-    {'log':r"Ignoring smp_cpus value"},
     {'log':r"sd_init failed: Drive 'sd0' is already in use because it has been automatically connected to another device"},
     {'log':r"This CPU requires a smaller page size than the system is using"},
-    {'log':r"MSI-X support is mandatory in the S390 architecture"},
-    {'log':r"rom check and register reset failed"},
     {'log':r"Unable to initialize GIC, CPUState for CPU#0 not valid"},
     {'log':r"Multiple VT220 operator consoles are not supported"},
     {'log':r"core 0 already populated"},
-- 
2.49.0

On 27/11/2025 15.49, Markus Armbruster wrote:
> Device 'nand' was dropped in commit commit e86c1f967a3.
> 
> Device 'vfio-amd-xgbe' was dropped in commit aeb1a50d4a7.
> 
> Device 'vfio-calxeda-xgmac' was dropped in commit 8ebc416ac17.
> 
> The last error messages matching r"images* must be given with the
> 'pflash' parameter" was dropped in commit a2ccff4d2bc.
> 
> The error message matching r"Option '-device [\w.,-]+' cannot be
> handled by this machine" was dropped in commit commit db78a605599.
> 
> As far as I can tell, we never had message matching r"Ignoring
> smp_cpus value"

This was a wrapped string, it has been changed in comnit 
f2ad5140fa521bda30b9c3c3db5b6913f6dda1ae ("hw/arm/exynos: Convert fprintf to 
qemu_log_mask/error_report") and finally been removed in commit
7264961934130df50d151def5eb415efa2e28ec5.

> or r"MSI-X support is mandatory in the S390
> architecture".

This (split) string still exists in hw/s390x/s390-pci-bus.c:

$ grep -r -A1 MSI-X.support.is.mandatory hw/
hw/s390x/s390-pci-bus.c:            error_setg(errp, "MSI-X support is 
mandatory "
hw/s390x/s390-pci-bus.c-                       "in the S390 architecture");

So I think we should keep it.

  Thomas

Thomas Huth <thuth@redhat.com> writes:

> On 27/11/2025 15.49, Markus Armbruster wrote:
>> Device 'nand' was dropped in commit commit e86c1f967a3.
>> Device 'vfio-amd-xgbe' was dropped in commit aeb1a50d4a7.
>> Device 'vfio-calxeda-xgmac' was dropped in commit 8ebc416ac17.
>> The last error messages matching r"images* must be given with the
>> 'pflash' parameter" was dropped in commit a2ccff4d2bc.
>> The error message matching r"Option '-device [\w.,-]+' cannot be
>> handled by this machine" was dropped in commit commit db78a605599.
>> As far as I can tell, we never had message matching r"Ignoring
>> smp_cpus value"
>
> This was a wrapped string, it has been changed in comnit f2ad5140fa521bda30b9c3c3db5b6913f6dda1ae ("hw/arm/exynos: Convert fprintf to qemu_log_mask/error_report") and finally been removed in commit
> 7264961934130df50d151def5eb415efa2e28ec5.
>
>> or r"MSI-X support is mandatory in the S390
>> architecture".
>
> This (split) string still exists in hw/s390x/s390-pci-bus.c:
>
> $ grep -r -A1 MSI-X.support.is.mandatory hw/
> hw/s390x/s390-pci-bus.c:            error_setg(errp, "MSI-X support is mandatory "
> hw/s390x/s390-pci-bus.c-                       "in the S390 architecture");

Watch me fail at grepping.

> So I think we should keep it.

Yes.

v2 coming.  Thanks!