hw/core: remove duplicate include

[PATCH] hw/core: remove duplicate include

Posted by Osama Abdelkader 2 months, 1 week ago

qemu/target-info.h is included twice.
---
 system/vl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/system/vl.c b/system/vl.c
index 5091fe52d9..d2b53ea772 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -41,7 +41,6 @@
 #include "qemu/help_option.h"
 #include "qemu/hw-version.h"
 #include "qemu/uuid.h"
-#include "qemu/target-info.h"
 #include "system/reset.h"
 #include "system/runstate.h"
 #include "system/runstate-action.h"
-- 
2.43.0

Re: [PATCH] hw/core: remove duplicate include

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

On 26/11/25 22:08, Osama Abdelkader wrote:
> qemu/target-info.h is included twice.
> ---
>   system/vl.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


And queued, thanks!

Re: [PATCH] hw/core: remove duplicate include

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

Hi Osama,

On 23/12/25 14:51, Philippe Mathieu-Daudé wrote:
> On 26/11/25 22:08, Osama Abdelkader wrote:
>> qemu/target-info.h is included twice.
>> ---
>>   system/vl.c | 1 -
>>   1 file changed, 1 deletion(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> 
> And queued, thanks!

Actually we can not take this because the patch is missing your
"signed-off" tag, see:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line

Replying with "Signed-off-by: Osama Abdelkader 
<osama.abdelkader@gmail.com>" would fix this :)

Regards,

Phil.

Re: [PATCH] hw/core: remove duplicate include

Posted by Osama Abdelkader 1 month, 2 weeks ago

On Tue, Dec 23, 2025 at 02:57:34PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Osama,
> 
> On 23/12/25 14:51, Philippe Mathieu-Daudé wrote:
> > On 26/11/25 22:08, Osama Abdelkader wrote:
> > > qemu/target-info.h is included twice.
> > > ---
> > >   system/vl.c | 1 -
> > >   1 file changed, 1 deletion(-)
> > 
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > 
> > 
> > And queued, thanks!
> 
> Actually we can not take this because the patch is missing your
> "signed-off" tag, see:
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line
> 
> Replying with "Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>"
> would fix this :)
> 
> Regards,
> 
> Phil.

Hi Philippe,

Thank you, and have a good day :)

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

Best regards,
Osama

Re: [PATCH] hw/core: remove duplicate include

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

On 23/12/25 15:31, Osama Abdelkader wrote:
> On Tue, Dec 23, 2025 at 02:57:34PM +0100, Philippe Mathieu-Daudé wrote:
>> Hi Osama,
>>
>> On 23/12/25 14:51, Philippe Mathieu-Daudé wrote:
>>> On 26/11/25 22:08, Osama Abdelkader wrote:
>>>> qemu/target-info.h is included twice.
>>>> ---
>>>>    system/vl.c | 1 -
>>>>    1 file changed, 1 deletion(-)
>>>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>>
>>>
>>> And queued, thanks!
>>
>> Actually we can not take this because the patch is missing your
>> "signed-off" tag, see:
>> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line
>>
>> Replying with "Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>"
>> would fix this :)
>>
>> Regards,
>>
>> Phil.
> 
> Hi Philippe,
> 
> Thank you, and have a good day :)
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

Great, patch queued again :)

Thanks,

Phil.