[v1] machine: Provide a description for aux-ram-share property

[PATCH] machine: Provide a description for aux-ram-share property

Peter Xu posted 1 patch 2 weeks, 5 days ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251124191408.783473-1-peterx@redhat.com

Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>

hw/core/machine.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] machine: Provide a description for aux-ram-share property

Posted by Peter Xu 2 weeks, 5 days ago

It was forgotten when being introduced in commit 91792807d1 ("machine:
aux-ram-share option").

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
v2:
- Fix spelling, s/auxilliary/auxiliary/ [Fabiano]
---
 hw/core/machine.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index 06e0c9a179..27372bb01e 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1204,6 +1204,8 @@ static void machine_class_init(ObjectClass *oc, const void *data)
     object_class_property_add_bool(oc, "aux-ram-share",
                                    machine_get_aux_ram_share,
                                    machine_set_aux_ram_share);
+    object_class_property_set_description(oc, "aux-ram-share",
+        "Use anonymous shared memory for auxiliary guest RAMs");
 #endif
 
     object_class_property_add_bool(oc, "usb",
-- 
2.50.1

Re: [PATCH] machine: Provide a description for aux-ram-share property

Posted by Philippe Mathieu-Daudé 2 weeks, 4 days ago

On 24/11/25 20:14, Peter Xu wrote:
> It was forgotten when being introduced in commit 91792807d1 ("machine:
> aux-ram-share option").
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> v2:
> - Fix spelling, s/auxilliary/auxiliary/ [Fabiano]
> ---
>   hw/core/machine.c | 2 ++
>   1 file changed, 2 insertions(+)

Queued, thanks.

Re: [PATCH] machine: Provide a description for aux-ram-share property

Posted by Fabiano Rosas 2 weeks, 5 days ago

Peter Xu <peterx@redhat.com> writes:

> It was forgotten when being introduced in commit 91792807d1 ("machine:
> aux-ram-share option").
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> v2:
> - Fix spelling, s/auxilliary/auxiliary/ [Fabiano]
> ---
>  hw/core/machine.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 06e0c9a179..27372bb01e 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -1204,6 +1204,8 @@ static void machine_class_init(ObjectClass *oc, const void *data)
>      object_class_property_add_bool(oc, "aux-ram-share",
>                                     machine_get_aux_ram_share,
>                                     machine_set_aux_ram_share);
> +    object_class_property_set_description(oc, "aux-ram-share",
> +        "Use anonymous shared memory for auxiliary guest RAMs");
>  #endif
>  
>      object_class_property_add_bool(oc, "usb",

Reviewed-by: Fabiano Rosas <farosas@suse.de>