[PATCH 05/22] python/mkvenv: bump 'qemu.qmp' dependency for testdeps

John Snow posted 22 patches 2 days, 17 hours ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
[PATCH 05/22] python/mkvenv: bump 'qemu.qmp' dependency for testdeps
Posted by John Snow 2 days, 17 hours ago
First up, use the newest v0.0.5 instead of the older v0.0.3.

Secondly, the use of a period in the key name does not behave as
expected when installing and checking for dependencies, so quote this
string instead.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 pythondeps.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pythondeps.toml b/pythondeps.toml
index 98e99e79005..1657953ff65 100644
--- a/pythondeps.toml
+++ b/pythondeps.toml
@@ -32,5 +32,5 @@ sphinx = { accepted = ">=3.4.3", installed = "6.2.1", canary = "sphinx-build" }
 sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }
 
 [testdeps]
-qemu.qmp = { accepted = ">=0.0.3", installed = "0.0.3" }
+"qemu.qmp" = { accepted = ">=0.0.5", installed = "0.0.5" }
 pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" }
-- 
2.51.1
Re: [PATCH 05/22] python/mkvenv: bump 'qemu.qmp' dependency for testdeps
Posted by Thomas Huth 1 day, 3 hours ago
On 17/11/2025 19.51, John Snow wrote:
> First up, use the newest v0.0.5 instead of the older v0.0.3.
> 
> Secondly, the use of a period in the key name does not behave as
> expected when installing and checking for dependencies, so quote this
> string instead.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   pythondeps.toml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pythondeps.toml b/pythondeps.toml
> index 98e99e79005..1657953ff65 100644
> --- a/pythondeps.toml
> +++ b/pythondeps.toml
> @@ -32,5 +32,5 @@ sphinx = { accepted = ">=3.4.3", installed = "6.2.1", canary = "sphinx-build" }
>   sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }
>   
>   [testdeps]
> -qemu.qmp = { accepted = ">=0.0.3", installed = "0.0.3" }
> +"qemu.qmp" = { accepted = ">=0.0.5", installed = "0.0.5" }

Question from a still-python-ignorant: Isn't a dot in a python module name a 
bad idea after all? I mean if at one point in time, the "qemu" module comes 
to live and also contains a "qmp" submodule, isn't this calling for trouble?

Maybe it would be a good point in time now to start populating 
https://pypi.org/project/qemu instead?

  Thomas
Re: [PATCH 05/22] python/mkvenv: bump 'qemu.qmp' dependency for testdeps
Posted by John Snow 15 hours ago
On Wed, Nov 19, 2025 at 4:19 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 17/11/2025 19.51, John Snow wrote:
> > First up, use the newest v0.0.5 instead of the older v0.0.3.
> >
> > Secondly, the use of a period in the key name does not behave as
> > expected when installing and checking for dependencies, so quote this
> > string instead.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   pythondeps.toml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/pythondeps.toml b/pythondeps.toml
> > index 98e99e79005..1657953ff65 100644
> > --- a/pythondeps.toml
> > +++ b/pythondeps.toml
> > @@ -32,5 +32,5 @@ sphinx = { accepted = ">=3.4.3", installed = "6.2.1", canary = "sphinx-build" }
> >   sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }
> >
> >   [testdeps]
> > -qemu.qmp = { accepted = ">=0.0.3", installed = "0.0.3" }
> > +"qemu.qmp" = { accepted = ">=0.0.5", installed = "0.0.5" }
>
> Question from a still-python-ignorant: Isn't a dot in a python module name a
> bad idea after all? I mean if at one point in time, the "qemu" module comes
> to live and also contains a "qmp" submodule, isn't this calling for trouble?

The "qemu" package that lives in our tree is actually a namespace that
contains several namespaced packages: qmp, machine, utils, etc. It
just so happens that the internal "qemu" package comes along with
"qemu.qmp".

I probably ought to update that placeholder qemu package and have it
at least pull in qemu.qmp as a dependency ...

>
> Maybe it would be a good point in time now to start populating
> https://pypi.org/project/qemu instead?
>
>   Thomas
>