[PATCH] tests/functional/m68k/test_nextcube: Fix issues reported by pylint

Thomas Huth posted 1 patch 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251110104837.52077-1-thuth@redhat.com
Maintainers: Thomas Huth <huth@tuxfamily.org>
tests/functional/m68k/test_nextcube.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] tests/functional/m68k/test_nextcube: Fix issues reported by pylint
Posted by Thomas Huth 1 month ago
From: Thomas Huth <thuth@redhat.com>

Fix the indentation in one line, and while we're at it, use an f-string
instead of old-school formatting in another spot.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/m68k/test_nextcube.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/functional/m68k/test_nextcube.py b/tests/functional/m68k/test_nextcube.py
index e5e1c69dcbd..71c160d0262 100755
--- a/tests/functional/m68k/test_nextcube.py
+++ b/tests/functional/m68k/test_nextcube.py
@@ -40,7 +40,7 @@ def check_bootrom_framebuffer(self, screenshot_path):
             time.sleep(0.1)
 
         res = self.vm.cmd('human-monitor-command',
-                          command_line='screendump %s' % screenshot_path)
+                          command_line=f"screendump {screenshot_path}")
         if 'unknown command' in res:
             self.skipTest('screendump not available')
 
@@ -52,7 +52,7 @@ def test_bootrom_framebuffer_size(self):
 
         from PIL import Image
         with Image.open(screenshot_path) as image:
-                width, height = image.size
+            width, height = image.size
         self.assertEqual(width, 1120)
         self.assertEqual(height, 832)
 
-- 
2.51.1
Re: [PATCH] tests/functional/m68k/test_nextcube: Fix issues reported by pylint
Posted by Philippe Mathieu-Daudé 1 month ago
On 10/11/25 11:48, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Fix the indentation in one line, and while we're at it, use an f-string
> instead of old-school formatting in another spot.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/m68k/test_nextcube.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>