On 11/5/25 04:58, Kane Chen wrote:
> From: Kane-Chen-AS <kane_chen@aspeedtech.com>
>
> Introduce a minimal QEMU device model for the ASPEED AST1700, an
> MCU-less I/O expander used in the LTPI topology defined by the
> DC-SCM 2.0 specification (see figure 2):
> https://www.opencompute.org/documents/ocp-dc-scm-2-0-ltpi-ver-1-0-pdf
>
> This initial implementation includes:
>
> * Definition of aspeed.ast1700 as a SysBusDevice
>
> * Setup of a basic memory region to reserve I/O space for future
> peripheral modeling
>
> This stub establishes the foundation for LTPI-related device emulation,
> without implementing any functional peripherals at this stage.
>
> Signed-off-by: Kane-Chen-AS <kane_chen@aspeedtech.com>
> ---
> include/hw/misc/aspeed_ast1700.h | 32 ++++++++++++++++++
> hw/misc/aspeed_ast1700.c | 57 ++++++++++++++++++++++++++++++++
> hw/misc/meson.build | 1 +
> 3 files changed, 90 insertions(+)
> create mode 100644 include/hw/misc/aspeed_ast1700.h
> create mode 100644 hw/misc/aspeed_ast1700.c
>
> diff --git a/include/hw/misc/aspeed_ast1700.h b/include/hw/misc/aspeed_ast1700.h
> new file mode 100644
> index 0000000000..b7c666eef2
> --- /dev/null
> +++ b/include/hw/misc/aspeed_ast1700.h
> @@ -0,0 +1,32 @@
> +/*
> + * ASPEED AST1700 IO Expander
> + *
> + * Copyright (C) 2025 ASPEED Technology Inc.
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +#ifndef ASPEED_AST1700_H
> +#define ASPEED_AST1700_H
> +
> +#include "hw/sysbus.h"
> +#include "hw/misc/aspeed_scu.h"
> +#include "hw/adc/aspeed_adc.h"
> +#include "hw/gpio/aspeed_gpio.h"
> +#include "hw/i2c/aspeed_i2c.h"
> +#include "hw/misc/aspeed_ltpi.h"
> +#include "hw/ssi/aspeed_smc.h"
> +#include "hw/watchdog/wdt_aspeed.h"
> +#include "hw/char/serial-mm.h"
> +#include "hw/misc/unimp.h"
There are too much includes. Please introduce the minimum each time.
> +
> +#define TYPE_ASPEED_AST1700 "aspeed.ast1700"
> +
> +OBJECT_DECLARE_SIMPLE_TYPE(AspeedAST1700SoCState, ASPEED_AST1700)
> +
> +struct AspeedAST1700SoCState {
> + SysBusDevice parent_obj;
> +
> + MemoryRegion iomem;
> +};
> +
> +#endif /* ASPEED_AST1700_H */
> diff --git a/hw/misc/aspeed_ast1700.c b/hw/misc/aspeed_ast1700.c
> new file mode 100644
> index 0000000000..bb05e392f4
> --- /dev/null
> +++ b/hw/misc/aspeed_ast1700.c
> @@ -0,0 +1,57 @@
> +/*
> + * ASPEED AST1700 IO Expander
> + *
> + * Copyright (C) 2025 ASPEED Technology Inc.
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#include "qemu/osdep.h"
> +#include "hw/boards.h"
> +#include "hw/qdev-core.h"
> +#include "qom/object.h"
> +#include "hw/qdev-properties.h"
> +#include "qemu/log.h"
> +#include "migration/vmstate.h"
No vmstate ?
> +#include "hw/misc/aspeed_ast1700.h"
> +> +#define AST2700_SOC_LTPI_SIZE 0x01000000
> +static void aspeed_ast1700_realize(DeviceState *dev, Error **errp)
> +{
> + AspeedAST1700SoCState *s = ASPEED_AST1700(dev);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> +
> + /* Occupy memory space for all controllers in AST1700 */
> + memory_region_init(&s->iomem, OBJECT(s), TYPE_ASPEED_AST1700,
> + AST2700_SOC_LTPI_SIZE);
> + sysbus_init_mmio(sbd, &s->iomem);
> +
> +}
> +
> +static void aspeed_ast1700_instance_init(Object *obj)
> +{
> + return;
> +}
It's better to introduce a routine when needed.
Thanks,
C.
> +static void aspeed_ast1700_class_init(ObjectClass *klass, const void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(klass);
> +
> + dc->realize = aspeed_ast1700_realize;
> +}
> +
> +static const TypeInfo aspeed_ast1700_info = {
> + .name = TYPE_ASPEED_AST1700,
> + .parent = TYPE_SYS_BUS_DEVICE,
> + .instance_size = sizeof(AspeedAST1700SoCState),
> + .class_init = aspeed_ast1700_class_init,
> + .instance_init = aspeed_ast1700_instance_init,
> +};
> +
> +
> +static void aspeed_ast1700_register_types(void)
> +{
> + type_register_static(&aspeed_ast1700_info);
> +}
> +
> +type_init(aspeed_ast1700_register_types);
> diff --git a/hw/misc/meson.build b/hw/misc/meson.build
> index 45b16e7797..9477e63cdf 100644
> --- a/hw/misc/meson.build
> +++ b/hw/misc/meson.build
> @@ -133,6 +133,7 @@ system_ss.add(when: 'CONFIG_PVPANIC_PCI', if_true: files('pvpanic-pci.c'))
> system_ss.add(when: 'CONFIG_PVPANIC_MMIO', if_true: files('pvpanic-mmio.c'))
> system_ss.add(when: 'CONFIG_AUX', if_true: files('auxbus.c'))
> system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files(
> + 'aspeed_ast1700.c',
> 'aspeed_hace.c',
> 'aspeed_i3c.c',
> 'aspeed_lpc.c',