[PATCH v2 3/7] ati-vga: Implement foreground and background color register writes

Chad Jablonski posted 7 patches 3 months, 1 week ago
There is a newer version of this series
[PATCH v2 3/7] ati-vga: Implement foreground and background color register writes
Posted by Chad Jablonski 3 months, 1 week ago
These are straightforward 32-bit register write handlers. They're
necessary for a future patch which will use them for color expansion
from monochrome host data transfers.

Signed-off-by: Chad Jablonski <chad@jablonski.xyz>
---
 hw/display/ati.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/display/ati.c b/hw/display/ati.c
index eb9b30672f..bf7a037e64 100644
--- a/hw/display/ati.c
+++ b/hw/display/ati.c
@@ -926,6 +926,12 @@ static void ati_mm_write(void *opaque, hwaddr addr,
     case DP_CNTL:
         s->regs.dp_cntl = data;
         break;
+    case DP_SRC_FRGD_CLR:
+        s->regs.dp_src_frgd_clr = data;
+        break;
+    case DP_SRC_BKGD_CLR:
+        s->regs.dp_src_bkgd_clr = data;
+        break;
     case DP_DATATYPE:
         s->regs.dp_datatype = data & 0xe0070f0f;
         break;
-- 
2.51.0
Re: [PATCH v2 3/7] ati-vga: Implement foreground and background color register writes
Posted by BALATON Zoltan 3 months, 1 week ago
On Sun, 2 Nov 2025, Chad Jablonski wrote:
> These are straightforward 32-bit register write handlers. They're
> necessary for a future patch which will use them for color expansion
> from monochrome host data transfers.
>
> Signed-off-by: Chad Jablonski <chad@jablonski.xyz>

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

> ---
> hw/display/ati.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/display/ati.c b/hw/display/ati.c
> index eb9b30672f..bf7a037e64 100644
> --- a/hw/display/ati.c
> +++ b/hw/display/ati.c
> @@ -926,6 +926,12 @@ static void ati_mm_write(void *opaque, hwaddr addr,
>     case DP_CNTL:
>         s->regs.dp_cntl = data;
>         break;
> +    case DP_SRC_FRGD_CLR:
> +        s->regs.dp_src_frgd_clr = data;
> +        break;
> +    case DP_SRC_BKGD_CLR:
> +        s->regs.dp_src_bkgd_clr = data;
> +        break;
>     case DP_DATATYPE:
>         s->regs.dp_datatype = data & 0xe0070f0f;
>         break;
>