[v2] util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic

[PATCH v2 0/2] util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic

Vladimir Sementsov-Ogievskiy posted 2 patches 1 week, 6 days ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251031190246.257153-1-vsementsov@yandex-team.ru

tests/unit/test-cutils.c | 43 ++++++++++++++++++++++++++++++++++++++++
util/hexdump.c           | 38 ++++++++++++++++++++++-------------
2 files changed, 67 insertions(+), 14 deletions(-)

Expand all Fold all

[PATCH v2 0/2] util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic

Posted by Vladimir Sementsov-Ogievskiy 1 week, 6 days ago

Hi all. qemu_hexdump() wrongly indents ASCII part of the output for
the list line, it it's not bound to 16-bytes boundary. Let's fix.

v2: add test

Vladimir Sementsov-Ogievskiy (2):
  util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
  tests/unit: add unit test for qemu_hexdump()

 tests/unit/test-cutils.c | 43 ++++++++++++++++++++++++++++++++++++++++
 util/hexdump.c           | 38 ++++++++++++++++++++++-------------
 2 files changed, 67 insertions(+), 14 deletions(-)

-- 
2.48.1

Re: [PATCH v2 0/2] util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic

Posted by Philippe Mathieu-Daudé 1 week, 6 days ago

On 31/10/25 20:02, Vladimir Sementsov-Ogievskiy wrote:
> Hi all. qemu_hexdump() wrongly indents ASCII part of the output for
> the list line, it it's not bound to 16-bytes boundary. Let's fix.
> 
> v2: add test
> 
> Vladimir Sementsov-Ogievskiy (2):
>    util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
>    tests/unit: add unit test for qemu_hexdump()

Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH v2 0/2] util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic

Posted by Philippe Mathieu-Daudé 1 week, 6 days ago

On 31/10/25 21:56, Philippe Mathieu-Daudé wrote:
> On 31/10/25 20:02, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all. qemu_hexdump() wrongly indents ASCII part of the output for
>> the list line, it it's not bound to 16-bytes boundary. Let's fix.
>>
>> v2: add test
>>
>> Vladimir Sementsov-Ogievskiy (2):
>>    util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
>>    tests/unit: add unit test for qemu_hexdump()
> 
> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

And queued.

Re: [PATCH v2 0/2] util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic

Posted by Vladimir Sementsov-Ogievskiy 1 week, 6 days ago

On 01.11.25 00:11, Philippe Mathieu-Daudé wrote:
> On 31/10/25 21:56, Philippe Mathieu-Daudé wrote:
>> On 31/10/25 20:02, Vladimir Sementsov-Ogievskiy wrote:
>>> Hi all. qemu_hexdump() wrongly indents ASCII part of the output for
>>> the list line, it it's not bound to 16-bytes boundary. Let's fix.
>>>
>>> v2: add test
>>>
>>> Vladimir Sementsov-Ogievskiy (2):
>>>    util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
>>>    tests/unit: add unit test for qemu_hexdump()
>>
>> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> And queued.

Thank you!

-- 
Best regards,
Vladimir