[PATCH 3/8] qapi: Clean up whitespace between definitions

Markus Armbruster posted 8 patches 2 weeks ago
There is a newer version of this series
[PATCH 3/8] qapi: Clean up whitespace between definitions
Posted by Markus Armbruster 2 weeks ago
Consistently separate definitions with a single blank line.
Consistently separate member descriptions with a blank line.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/acpi-hest.json | 1 -
 qapi/char.json      | 1 -
 qapi/crypto.json    | 1 +
 qapi/cxl.json       | 1 -
 qapi/migration.json | 3 +++
 qapi/misc-i386.json | 2 --
 qapi/net.json       | 3 ---
 qapi/qom.json       | 3 ---
 qapi/run-state.json | 1 -
 qapi/ui.json        | 2 +-
 qapi/virtio.json    | 2 --
 11 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/qapi/acpi-hest.json b/qapi/acpi-hest.json
index 88c53eaf1b..a01f1dee09 100644
--- a/qapi/acpi-hest.json
+++ b/qapi/acpi-hest.json
@@ -11,7 +11,6 @@
 # https://uefi.org/sites/default/files/resources/ACPI_6_1.pdf
 ##
 
-
 ##
 # @inject-ghes-v2-error:
 #
diff --git a/qapi/char.json b/qapi/char.json
index aaedbbb36c..5218a2e76b 100644
--- a/qapi/char.json
+++ b/qapi/char.json
@@ -694,7 +694,6 @@
 { 'struct': 'ChardevRingbufWrapper',
   'data': { 'data': 'ChardevRingbuf' } }
 
-
 ##
 # @ChardevPtyWrapper:
 #
diff --git a/qapi/crypto.json b/qapi/crypto.json
index 72ac718147..2b55befef9 100644
--- a/qapi/crypto.json
+++ b/qapi/crypto.json
@@ -547,6 +547,7 @@
   'base': 'TlsCredsProperties',
   'data': { '*sanity-check': 'bool',
             '*passwordid': 'str' } }
+
 ##
 # @QCryptoAkCipherAlgo:
 #
diff --git a/qapi/cxl.json b/qapi/cxl.json
index 52cc5d4f33..eeddb58d1d 100644
--- a/qapi/cxl.json
+++ b/qapi/cxl.json
@@ -262,7 +262,6 @@
 #
 # Since: 8.0
 ##
-
 { 'enum': 'CxlUncorErrorType',
   'data': ['cache-data-parity',
            'cache-address-parity',
diff --git a/qapi/migration.json b/qapi/migration.json
index 4dd1098219..022ac0c4ed 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -177,6 +177,7 @@
             'postcopy-recover-setup',
             'postcopy-recover', 'completed', 'failed', 'colo',
             'pre-switchover', 'device', 'wait-unplug' ] }
+
 ##
 # @VfioStats:
 #
@@ -523,6 +524,7 @@
 # Features:
 #
 # @unstable: Members @x-colo and @x-ignore-shared are experimental.
+#
 # @deprecated: Member @zero-blocks is deprecated as being part of
 #     block migration which was already removed.
 #
@@ -1702,6 +1704,7 @@
 # The migration channel-type request options.
 #
 # @main: Main outbound migration channel.
+#
 # @cpr: Checkpoint and restart state channel.
 #
 # Since: 8.1
diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json
index d1ce8caf25..05a94d6c41 100644
--- a/qapi/misc-i386.json
+++ b/qapi/misc-i386.json
@@ -122,7 +122,6 @@
       'sev': 'SevGuestInfo',
       'sev-snp': 'SevSnpGuestInfo' } }
 
-
 ##
 # @query-sev:
 #
@@ -418,7 +417,6 @@
            'pending': 'bool',
            'masked': 'bool'} }
 
-
 ##
 # @xen-event-list:
 #
diff --git a/qapi/net.json b/qapi/net.json
index 23911b75cd..70c0411837 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -1065,7 +1065,6 @@
 #
 # Since: 4.0
 ##
-
 { 'struct': 'AnnounceParameters',
   'data': { 'initial': 'int',
             'max': 'int',
@@ -1181,7 +1180,6 @@
 #     <- { "timestamp": {"seconds": 1739538638, "microseconds": 354181 },
 #          "event": "NETDEV_VHOST_USER_CONNECTED",
 #          "data": { "netdev-id": "netdev0", "chardev-id": "chr0" } }
-#
 ##
 { 'event': 'NETDEV_VHOST_USER_CONNECTED',
   'data': { 'netdev-id': 'str', 'chardev-id': 'str' } }
@@ -1200,7 +1198,6 @@
 #     <- { "timestamp": { "seconds": 1739538634, "microseconds": 920450 },
 #          "event": "NETDEV_VHOST_USER_DISCONNECTED",
 #          "data": { "netdev-id": "netdev0" } }
-#
 ##
 { 'event': 'NETDEV_VHOST_USER_DISCONNECTED',
   'data': { 'netdev-id': 'str' } }
diff --git a/qapi/qom.json b/qapi/qom.json
index d7dceaf2f8..6f5c9de0f0 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -75,7 +75,6 @@
 { 'struct': 'ObjectPropertiesValues',
   'data': { 'properties': [ 'ObjectPropertyValue' ] }}
 
-
 ##
 # @qom-list:
 #
@@ -244,7 +243,6 @@
 #
 # @typename: the type name of an object
 #
-#
 # .. note:: Objects can create properties at runtime, for example to
 #    describe links between different devices and/or objects.  These
 #    properties are not included in the output of this command.
@@ -1169,7 +1167,6 @@
   'data': { '*cpu-affinity': ['uint16'],
             '*node-affinity': ['uint16'] } }
 
-
 ##
 # @ObjectType:
 #
diff --git a/qapi/run-state.json b/qapi/run-state.json
index 2872bee06e..a6bc94a44b 100644
--- a/qapi/run-state.json
+++ b/qapi/run-state.json
@@ -618,7 +618,6 @@
 #     error information, as zero-terminated string.  Present when the
 #     "GPA valid" bit (bit 63) is set in @error-code.
 #
-#
 # Since: 10.1
 ##
 {'struct': 'GuestPanicInformationTdx',
diff --git a/qapi/ui.json b/qapi/ui.json
index 804b1ecc3b..e3da77632a 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -682,6 +682,7 @@
 ##
 { 'command': 'query-vnc', 'returns': 'VncInfo',
   'if': 'CONFIG_VNC' }
+
 ##
 # @query-vnc-servers:
 #
@@ -1094,7 +1095,6 @@
 { 'enum'  : 'InputMultiTouchType',
   'data'  : [ 'begin', 'update', 'end', 'cancel', 'data' ] }
 
-
 ##
 # @InputKeyEvent:
 #
diff --git a/qapi/virtio.json b/qapi/virtio.json
index 72790bcfb0..cd67c4f52e 100644
--- a/qapi/virtio.json
+++ b/qapi/virtio.json
@@ -964,7 +964,6 @@
 #
 # Since: 9.0
 ##
-
 { 'struct': 'IOThreadVirtQueueMapping',
   'data': { 'iothread': 'str', '*vqs': ['uint16'] } }
 
@@ -989,7 +988,6 @@
 #
 # Since: 9.0
 ##
-
 { 'struct': 'DummyVirtioForceArrays',
   'data': { 'unused-iothread-vq-mapping': ['IOThreadVirtQueueMapping'],
             'unused-virtio-gpu-output': ['VirtIOGPUOutput'] } }
-- 
2.49.0
Re: [PATCH 3/8] qapi: Clean up whitespace between definitions
Posted by Vladimir Sementsov-Ogievskiy 2 weeks ago
On 31.10.25 12:47, Markus Armbruster wrote:
> Consistently separate definitions with a single blank line.
> Consistently separate member descriptions with a blank line.
> 
> Signed-off-by: Markus Armbruster<armbru@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

-- 
Best regards,
Vladimir
Re: [PATCH 3/8] qapi: Clean up whitespace between definitions
Posted by Philippe Mathieu-Daudé 2 weeks ago
On 31/10/25 10:47, Markus Armbruster wrote:
> Consistently separate definitions with a single blank line.
> Consistently separate member descriptions with a blank line.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   qapi/acpi-hest.json | 1 -
>   qapi/char.json      | 1 -
>   qapi/crypto.json    | 1 +
>   qapi/cxl.json       | 1 -
>   qapi/migration.json | 3 +++
>   qapi/misc-i386.json | 2 --
>   qapi/net.json       | 3 ---
>   qapi/qom.json       | 3 ---
>   qapi/run-state.json | 1 -
>   qapi/ui.json        | 2 +-
>   qapi/virtio.json    | 2 --
>   11 files changed, 5 insertions(+), 15 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>