[PATCH 1/2] tests/functional: Mark the MIPS replay tests as flaky

Philippe Mathieu-Daudé posted 2 patches 2 weeks ago
Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>
[PATCH 1/2] tests/functional: Mark the MIPS replay tests as flaky
Posted by Philippe Mathieu-Daudé 2 weeks ago
MIPS test_replay.py often times out (likely hang) under GitLab CI:

  2/21 qemu:func-thorough+func-mips64el-thorough+thorough / func-mips64el-replay   TIMEOUT   180.12s   killed by signal 15 SIGTERM

The console.log file is empty, and recording.logs only shows:

  qemu-system-mips64el: terminating on signal 15 from pid 344

Since this is a long term issue affecting our CI, disable the tests.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/functional/mips/test_replay.py     | 2 ++
 tests/functional/mips64el/test_replay.py | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/tests/functional/mips/test_replay.py b/tests/functional/mips/test_replay.py
index 4327481e35b..747835bf008 100755
--- a/tests/functional/mips/test_replay.py
+++ b/tests/functional/mips/test_replay.py
@@ -5,6 +5,7 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
 from qemu_test import Asset, skipSlowTest
+from qemu_test import skipFlakyTest
 from replay_kernel import ReplayKernelBase
 
 
@@ -16,6 +17,7 @@ class MipsReplay(ReplayKernelBase):
          'linux-image-2.6.32-5-4kc-malta_2.6.32-48_mips.deb'),
         '16ca524148afb0626f483163e5edf352bc1ab0e4fc7b9f9d473252762f2c7a43')
 
+    @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2013")
     def test_replay_mips_malta(self):
         self.set_machine('malta')
         kernel_path = self.archive_extract(self.ASSET_KERNEL_2_63_2,
diff --git a/tests/functional/mips64el/test_replay.py b/tests/functional/mips64el/test_replay.py
index 26a6ccff3f7..05cc585f854 100755
--- a/tests/functional/mips64el/test_replay.py
+++ b/tests/functional/mips64el/test_replay.py
@@ -5,6 +5,7 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
 from qemu_test import Asset, skipUntrustedTest
+from qemu_test import skipFlakyTest
 from replay_kernel import ReplayKernelBase
 
 
@@ -16,6 +17,7 @@ class Mips64elReplay(ReplayKernelBase):
          'linux-image-2.6.32-5-5kc-malta_2.6.32-48_mipsel.deb'),
         '35eb476f03be589824b0310358f1c447d85e645b88cbcd2ac02b97ef560f9f8d')
 
+    @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2013")
     def test_replay_mips64el_malta(self):
         self.set_machine('malta')
         kernel_path = self.archive_extract(self.ASSET_KERNEL_2_63_2,
-- 
2.51.0


Re: [PATCH 1/2] tests/functional: Mark the MIPS replay tests as flaky
Posted by Thomas Huth 2 weeks ago
On 31/10/2025 10.41, Philippe Mathieu-Daudé wrote:
> MIPS test_replay.py often times out (likely hang) under GitLab CI:
> 
>    2/21 qemu:func-thorough+func-mips64el-thorough+thorough / func-mips64el-replay   TIMEOUT   180.12s   killed by signal 15 SIGTERM
> 
> The console.log file is empty, and recording.logs only shows:
> 
>    qemu-system-mips64el: terminating on signal 15 from pid 344
> 
> Since this is a long term issue affecting our CI, disable the tests.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tests/functional/mips/test_replay.py     | 2 ++
>   tests/functional/mips64el/test_replay.py | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/tests/functional/mips/test_replay.py b/tests/functional/mips/test_replay.py
> index 4327481e35b..747835bf008 100755
> --- a/tests/functional/mips/test_replay.py
> +++ b/tests/functional/mips/test_replay.py
> @@ -5,6 +5,7 @@
>   # SPDX-License-Identifier: GPL-2.0-or-later
>   
>   from qemu_test import Asset, skipSlowTest
> +from qemu_test import skipFlakyTest
>   from replay_kernel import ReplayKernelBase
>   
>   
> @@ -16,6 +17,7 @@ class MipsReplay(ReplayKernelBase):
>            'linux-image-2.6.32-5-4kc-malta_2.6.32-48_mips.deb'),
>           '16ca524148afb0626f483163e5edf352bc1ab0e4fc7b9f9d473252762f2c7a43')
>   
> +    @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2013")
>       def test_replay_mips_malta(self):
>           self.set_machine('malta')
>           kernel_path = self.archive_extract(self.ASSET_KERNEL_2_63_2,
> diff --git a/tests/functional/mips64el/test_replay.py b/tests/functional/mips64el/test_replay.py
> index 26a6ccff3f7..05cc585f854 100755
> --- a/tests/functional/mips64el/test_replay.py
> +++ b/tests/functional/mips64el/test_replay.py
> @@ -5,6 +5,7 @@
>   # SPDX-License-Identifier: GPL-2.0-or-later
>   
>   from qemu_test import Asset, skipUntrustedTest
> +from qemu_test import skipFlakyTest
>   from replay_kernel import ReplayKernelBase
>   
>   
> @@ -16,6 +17,7 @@ class Mips64elReplay(ReplayKernelBase):
>            'linux-image-2.6.32-5-5kc-malta_2.6.32-48_mipsel.deb'),
>           '35eb476f03be589824b0310358f1c447d85e645b88cbcd2ac02b97ef560f9f8d')
>   
> +    @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2013")
>       def test_replay_mips64el_malta(self):
>           self.set_machine('malta')
>           kernel_path = self.archive_extract(self.ASSET_KERNEL_2_63_2,

Thanks, this also bugs me since a while already (not enough to send a patch 
yet, so I'm glad you did it now)!

Reviewed-by: Thomas Huth <thuth@redhat.com>


Re: [PATCH 1/2] tests/functional: Mark the MIPS replay tests as flaky
Posted by Richard Henderson 2 weeks ago
On 10/31/25 10:41, Philippe Mathieu-Daudé wrote:
> +    @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2013")

If you're going to reference this, you might want to re-open it.

r~

Re: [PATCH 1/2] tests/functional: Mark the MIPS replay tests as flaky
Posted by Philippe Mathieu-Daudé 2 weeks ago
On 31/10/25 11:00, Richard Henderson wrote:
> On 10/31/25 10:41, Philippe Mathieu-Daudé wrote:
>> +    @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2013")
> 
> If you're going to reference this, you might want to re-open it.

I didn't notice it was closed (now re-opened).

Per commit 1f881ea4a44 ("replay: stop us hanging in rr_wait_io_event"):

     This fixes most of the failures in replay_kernel.py
                ^^^^