1. Patchew
  2. QEMU
  3. View series

[PATCH] tests/functional/ppc64: Fix class names to silence pylint warnings

Thomas Huth posted 1 patch 2 weeks, 2 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251029141946.86110-1-thuth@redhat.com
Maintainers: Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, BALATON Zoltan <balaton@eik.bme.hu>, Aditya Gupta <adityag@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>
tests/functional/ppc/test_74xx.py            | 2 +-
tests/functional/ppc/test_sam460ex.py        | 5 +++--
tests/functional/ppc64/test_powernv.py       | 2 +-
tests/functional/ppc64/test_pseries.py       | 2 +-
tests/functional/ppc64/test_reverse_debug.py | 2 +-
5 files changed, 7 insertions(+), 6 deletions(-)
[PATCH] tests/functional/ppc64: Fix class names to silence pylint warnings
Posted by Thomas Huth 2 weeks, 2 days ago 
From: Thomas Huth <thuth@redhat.com>

Pylint complains about inconsistent CamelCase names here, so let's
slightly change the names to make pylint happy again.

In the sam460ex test, also split a line where pylint was complaining
about it being too long.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/ppc/test_74xx.py            | 2 +-
 tests/functional/ppc/test_sam460ex.py        | 5 +++--
 tests/functional/ppc64/test_powernv.py       | 2 +-
 tests/functional/ppc64/test_pseries.py       | 2 +-
 tests/functional/ppc64/test_reverse_debug.py | 2 +-
 5 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/tests/functional/ppc/test_74xx.py b/tests/functional/ppc/test_74xx.py
index 5386016f261..219c7991aca 100755
--- a/tests/functional/ppc/test_74xx.py
+++ b/tests/functional/ppc/test_74xx.py
@@ -10,7 +10,7 @@
 from qemu_test import QemuSystemTest
 from qemu_test import wait_for_console_pattern
 
-class ppc74xxCpu(QemuSystemTest):
+class Ppc74xxCpu(QemuSystemTest):
 
     timeout = 5
 
diff --git a/tests/functional/ppc/test_sam460ex.py b/tests/functional/ppc/test_sam460ex.py
index 31cf9dd6de8..024406d155c 100755
--- a/tests/functional/ppc/test_sam460ex.py
+++ b/tests/functional/ppc/test_sam460ex.py
@@ -8,10 +8,11 @@
 from qemu_test import exec_command_and_wait_for_pattern
 
 
-class sam460exTest(LinuxKernelTest):
+class Sam460exTest(LinuxKernelTest):
 
     ASSET_BR2_SAM460EX_LINUX = Asset(
-        'https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main/buildroot/qemu_ppc_sam460ex-2023.11-8-gdcd9f0f6eb-20240105/vmlinux',
+        ('https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main'
+         '/buildroot/qemu_ppc_sam460ex-2023.11-8-gdcd9f0f6eb-20240105/vmlinux'),
         '6f46346f3e20e8b5fc050ff363f350f8b9d76a051b9e0bd7ea470cc680c14df2')
 
     def test_ppc_sam460ex_buildroot(self):
diff --git a/tests/functional/ppc64/test_powernv.py b/tests/functional/ppc64/test_powernv.py
index 9ada832b781..0ea6c93e428 100755
--- a/tests/functional/ppc64/test_powernv.py
+++ b/tests/functional/ppc64/test_powernv.py
@@ -10,7 +10,7 @@
 from qemu_test import LinuxKernelTest, Asset
 from qemu_test import wait_for_console_pattern
 
-class powernvMachine(LinuxKernelTest):
+class PowernvMachine(LinuxKernelTest):
 
     timeout = 90
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 console=hvc0 '
diff --git a/tests/functional/ppc64/test_pseries.py b/tests/functional/ppc64/test_pseries.py
index 67057934e8d..7840c4e3ff8 100755
--- a/tests/functional/ppc64/test_pseries.py
+++ b/tests/functional/ppc64/test_pseries.py
@@ -10,7 +10,7 @@
 from qemu_test import QemuSystemTest, Asset
 from qemu_test import wait_for_console_pattern
 
-class pseriesMachine(QemuSystemTest):
+class PseriesMachine(QemuSystemTest):
 
     timeout = 90
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 console=hvc0 '
diff --git a/tests/functional/ppc64/test_reverse_debug.py b/tests/functional/ppc64/test_reverse_debug.py
index 69551fb84df..4eef779936d 100755
--- a/tests/functional/ppc64/test_reverse_debug.py
+++ b/tests/functional/ppc64/test_reverse_debug.py
@@ -18,7 +18,7 @@
 from reverse_debugging import ReverseDebugging
 
 
-class ReverseDebugging_ppc64(ReverseDebugging):
+class ReverseDebuggingPpc64(ReverseDebugging):
 
     @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/1992")
     def test_ppc64_pseries(self):
-- 
2.51.0
Re: [PATCH] tests/functional/ppc64: Fix class names to silence pylint warnings
Posted by Miles Glenn 2 weeks, 2 days ago 
Reviewed-by: Glenn Miles <milesg@linux.ibm.com>

Thanks,

Glenn

On Wed, 2025-10-29 at 15:19 +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Pylint complains about inconsistent CamelCase names here, so let's
> slightly change the names to make pylint happy again.
> 
> In the sam460ex test, also split a line where pylint was complaining
> about it being too long.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/ppc/test_74xx.py            | 2 +-
>  tests/functional/ppc/test_sam460ex.py        | 5 +++--
>  tests/functional/ppc64/test_powernv.py       | 2 +-
>  tests/functional/ppc64/test_pseries.py       | 2 +-
>  tests/functional/ppc64/test_reverse_debug.py | 2 +-
>  5 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/functional/ppc/test_74xx.py b/tests/functional/ppc/test_74xx.py
> index 5386016f261..219c7991aca 100755
> --- a/tests/functional/ppc/test_74xx.py
> +++ b/tests/functional/ppc/test_74xx.py
> @@ -10,7 +10,7 @@
>  from qemu_test import QemuSystemTest
>  from qemu_test import wait_for_console_pattern
>  
> -class ppc74xxCpu(QemuSystemTest):
> +class Ppc74xxCpu(QemuSystemTest):
>  
>      timeout = 5
>  
> diff --git a/tests/functional/ppc/test_sam460ex.py b/tests/functional/ppc/test_sam460ex.py
> index 31cf9dd6de8..024406d155c 100755
> --- a/tests/functional/ppc/test_sam460ex.py
> +++ b/tests/functional/ppc/test_sam460ex.py
> @@ -8,10 +8,11 @@
>  from qemu_test import exec_command_and_wait_for_pattern
>  
>  
> -class sam460exTest(LinuxKernelTest):
> +class Sam460exTest(LinuxKernelTest):
>  
>      ASSET_BR2_SAM460EX_LINUX = Asset(
> -        'https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main/buildroot/qemu_ppc_sam460ex-2023.11-8-gdcd9f0f6eb-20240105/vmlinux',
> +        ('https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main'
> +         '/buildroot/qemu_ppc_sam460ex-2023.11-8-gdcd9f0f6eb-20240105/vmlinux'),
>          '6f46346f3e20e8b5fc050ff363f350f8b9d76a051b9e0bd7ea470cc680c14df2')
>  
>      def test_ppc_sam460ex_buildroot(self):
> diff --git a/tests/functional/ppc64/test_powernv.py b/tests/functional/ppc64/test_powernv.py
> index 9ada832b781..0ea6c93e428 100755
> --- a/tests/functional/ppc64/test_powernv.py
> +++ b/tests/functional/ppc64/test_powernv.py
> @@ -10,7 +10,7 @@
>  from qemu_test import LinuxKernelTest, Asset
>  from qemu_test import wait_for_console_pattern
>  
> -class powernvMachine(LinuxKernelTest):
> +class PowernvMachine(LinuxKernelTest):
>  
>      timeout = 90
>      KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 console=hvc0 '
> diff --git a/tests/functional/ppc64/test_pseries.py b/tests/functional/ppc64/test_pseries.py
> index 67057934e8d..7840c4e3ff8 100755
> --- a/tests/functional/ppc64/test_pseries.py
> +++ b/tests/functional/ppc64/test_pseries.py
> @@ -10,7 +10,7 @@
>  from qemu_test import QemuSystemTest, Asset
>  from qemu_test import wait_for_console_pattern
>  
> -class pseriesMachine(QemuSystemTest):
> +class PseriesMachine(QemuSystemTest):
>  
>      timeout = 90
>      KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 console=hvc0 '
> diff --git a/tests/functional/ppc64/test_reverse_debug.py b/tests/functional/ppc64/test_reverse_debug.py
> index 69551fb84df..4eef779936d 100755
> --- a/tests/functional/ppc64/test_reverse_debug.py
> +++ b/tests/functional/ppc64/test_reverse_debug.py
> @@ -18,7 +18,7 @@
>  from reverse_debugging import ReverseDebugging
>  
>  
> -class ReverseDebugging_ppc64(ReverseDebugging):
> +class ReverseDebuggingPpc64(ReverseDebugging):
>  
>      @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/1992")
>      def test_ppc64_pseries(self):

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.