[PULL v1 0/3] Microblaze signed division overflows

Edgar E. Iglesias posted 3 patches 2 weeks, 2 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20251029141749.1274729-1-edgar.iglesias@gmail.com
Maintainers: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
target/microblaze/cpu.h       |  1 +
target/microblaze/op_helper.c | 53 ++++++++++++++++++++++-------------
target/microblaze/translate.c | 12 ++------
3 files changed, 36 insertions(+), 30 deletions(-)
[PULL v1 0/3] Microblaze signed division overflows
Posted by Edgar E. Iglesias 2 weeks, 2 days ago
From: "Edgar E. Iglesias" <edgar.iglesias@amd.com>

The following changes since commit bc831f37398b51dfe65d99a67bcff9352f84a9d2:

  Merge tag 'hw-misc-20251028' of https://github.com/philmd/qemu into staging (2025-10-28 11:48:05 +0100)

are available in the Git repository at:

  https://gitlab.com/edgar.iglesias/qemu.git tags/edgar/xilinx-queue-2025-10-29.for-upstream

for you to fetch changes up to cfc1d54251d3b4c4cf21c4fa278c8aea2fe25a99:

  target/microblaze: Handle signed division overflows (2025-10-29 13:37:44 +0100)

----------------------------------------------------------------
Xilinx queue

----------------------------------------------------------------
Edgar E. Iglesias (3):
  target/microblaze: Remove unused arg from check_divz()
  target/microblaze: div: Break out raise_divzero()
  target/microblaze: Handle signed division overflows

 target/microblaze/cpu.h       |  1 +
 target/microblaze/op_helper.c | 53 ++++++++++++++++++++++-------------
 target/microblaze/translate.c | 12 ++------
 3 files changed, 36 insertions(+), 30 deletions(-)

-- 
2.43.0
Re: [PULL v1 0/3] Microblaze signed division overflows
Posted by Michael Tokarev 2 weeks ago
On 10/29/25 17:17, Edgar E. Iglesias wrote:
..
>    target/microblaze: Remove unused arg from check_divz()
>    target/microblaze: div: Break out raise_divzero()
>    target/microblaze: Handle signed division overflows
> 
>   target/microblaze/cpu.h       |  1 +
>   target/microblaze/op_helper.c | 53 ++++++++++++++++++++++-------------
>   target/microblaze/translate.c | 12 ++------
>   3 files changed, 36 insertions(+), 30 deletions(-)

Is it a qemu-stable material?  It feels like it is, even
if it's a sort-of "new feature".

Thanks,

/mjt
Re: [PULL v1 0/3] Microblaze signed division overflows
Posted by Edgar E. Iglesias 2 weeks ago
On Fri, Oct 31, 2025 at 01:23:38PM +0300, Michael Tokarev wrote:
> On 10/29/25 17:17, Edgar E. Iglesias wrote:
> ..
> >    target/microblaze: Remove unused arg from check_divz()
> >    target/microblaze: div: Break out raise_divzero()
> >    target/microblaze: Handle signed division overflows
> > 
> >   target/microblaze/cpu.h       |  1 +
> >   target/microblaze/op_helper.c | 53 ++++++++++++++++++++++-------------
> >   target/microblaze/translate.c | 12 ++------
> >   3 files changed, 36 insertions(+), 30 deletions(-)
> 
> Is it a qemu-stable material?  It feels like it is, even
> if it's a sort-of "new feature".
>

Yes, if no one opposes I'm in favor of backporting it.

Will you pick it up Michael? Or do you need anything more from me?

Cheers,
Edgar
Re: [PULL v1 0/3] Microblaze signed division overflows
Posted by Michael Tokarev 1 week, 6 days ago
On 10/31/25 17:11, Edgar E. Iglesias wrote:
> On Fri, Oct 31, 2025 at 01:23:38PM +0300, Michael Tokarev wrote:
..>> Is it a qemu-stable material?  It feels like it is, even
>> if it's a sort-of "new feature".
> 
> Yes, if no one opposes I'm in favor of backporting it.
> 
> Will you pick it up Michael? Or do you need anything more from me?

The only question is whenever microblaze is "useful enough", so a
stable qemu series is of interest to microblaze users.

I picked all 3 (since they stack on each other) for 10.0.x and 10.1.x,
they apply cleanly and seems to work fine (so far anyway).  But I don't
expect much breakage in this area.

Thank you for confirming!

/mjt
Re: [PULL v1 0/3] Microblaze signed division overflows
Posted by Richard Henderson 2 weeks ago
On 10/29/25 15:17, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"<edgar.iglesias@amd.com>
> 
> The following changes since commit bc831f37398b51dfe65d99a67bcff9352f84a9d2:
> 
>    Merge tag 'hw-misc-20251028' ofhttps://github.com/philmd/qemu into staging (2025-10-28 11:48:05 +0100)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/edgar.iglesias/qemu.git tags/edgar/xilinx-queue-2025-10-29.for-upstream
> 
> for you to fetch changes up to cfc1d54251d3b4c4cf21c4fa278c8aea2fe25a99:
> 
>    target/microblaze: Handle signed division overflows (2025-10-29 13:37:44 +0100)
> 
> ----------------------------------------------------------------
> Xilinx queue

Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/10.2 as appropriate.

r~