RFC: Drop qemu.qmp from qemu.git

[PATCH RFC 05/10] python/mkvenv: rename 'testdeps' to 'functests'

Posted by John Snow 2 weeks, 2 days ago

pygdmi is only needed for functional tests and not tests in general; to
prepare for more universally required test dependencies, rename this
dependency group "functests" instead.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 pythondeps.toml        | 2 +-
 tests/Makefile.include | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pythondeps.toml b/pythondeps.toml
index daf5a18989a..3d6907af799 100644
--- a/pythondeps.toml
+++ b/pythondeps.toml
@@ -31,6 +31,6 @@ meson = { accepted = ">=1.9.0", installed = "1.9.0", canary = "meson" }
 sphinx = { accepted = ">=3.4.3", installed = "6.2.1", canary = "sphinx-build" }
 sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }
 
-[testdeps]
+[functests]
 qemu_qmp = { accepted = ">=0.0.5", installed = "0.0.5" }
 pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" }
diff --git a/tests/Makefile.include b/tests/Makefile.include
index d4dfbf3716d..6f86eb283d3 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -98,7 +98,7 @@ quiet-venv-pip = $(quiet-@)$(call quiet-command-run, \
 
 $(TESTS_VENV_TOKEN): $(SRC_PATH)/pythondeps.toml
 	$(call quiet-venv-pip,install -e "$(SRC_PATH)/python/")
-	$(MKVENV_ENSUREGROUP) $< testdeps
+	$(MKVENV_ENSUREGROUP) $< functests
 	$(call quiet-command, touch $@)
 
 check-venv: $(TESTS_VENV_TOKEN)
-- 
2.51.0

Re: [PATCH RFC 05/10] python/mkvenv: rename 'testdeps' to 'functests'

Posted by Thomas Huth 2 weeks, 1 day ago

On 28/10/2025 23.03, John Snow wrote:
> pygdmi is only needed for functional tests and not tests in general; to
> prepare for more universally required test dependencies, rename this
> dependency group "functests" instead.
By the way, "check-venv" also seems to be still in use by 
tests/vm/Makefile.include ... not sure whether you want to mention it here 
somewhere, though.

  Thomas

Re: [PATCH RFC 05/10] python/mkvenv: rename 'testdeps' to 'functests'

Posted by Thomas Huth 2 weeks, 1 day ago

On 28/10/2025 23.03, John Snow wrote:
> pygdmi is only needed for functional tests and not tests in general; to
> prepare for more universally required test dependencies, rename this
> dependency group "functests" instead.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   pythondeps.toml        | 2 +-
>   tests/Makefile.include | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pythondeps.toml b/pythondeps.toml
> index daf5a18989a..3d6907af799 100644
> --- a/pythondeps.toml
> +++ b/pythondeps.toml
> @@ -31,6 +31,6 @@ meson = { accepted = ">=1.9.0", installed = "1.9.0", canary = "meson" }
>   sphinx = { accepted = ">=3.4.3", installed = "6.2.1", canary = "sphinx-build" }
>   sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }
>   
> -[testdeps]
> +[functests]
>   qemu_qmp = { accepted = ">=0.0.5", installed = "0.0.5" }
>   pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" }
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index d4dfbf3716d..6f86eb283d3 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -98,7 +98,7 @@ quiet-venv-pip = $(quiet-@)$(call quiet-command-run, \
>   
>   $(TESTS_VENV_TOKEN): $(SRC_PATH)/pythondeps.toml
>   	$(call quiet-venv-pip,install -e "$(SRC_PATH)/python/")
> -	$(MKVENV_ENSUREGROUP) $< testdeps
> +	$(MKVENV_ENSUREGROUP) $< functests
>   	$(call quiet-command, touch $@)
>   
>   check-venv: $(TESTS_VENV_TOKEN)

Reviewed-by: Thomas Huth <thuth@redhat.com>